AxioDL
/
tinyxml2
mirror of https://github.com/AxioDL/tinyxml2.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bools should really be implemented as self-closing <true /> and <false /> tags, not as 0/1 inside a tag, so removing those SetText variants again, in favor of SetBoolFirstChild() and BoolFirstChild() methods.

This commit is contained in:
Uli Kusterer 2014-01-21 02:23:20 +01:00
parent 7411c08e90
commit c1c20bb196
2 changed files with 28 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
tinyxml2.cpp
View File

@ -1297,19 +1297,6 @@ void XMLElement::SetText( unsigned inNum )
}
void XMLElement::SetText( bool inBool )
{
char buf[BUF_SIZE];
XMLUtil::ToStr( inBool, buf, BUF_SIZE );
if ( FirstChild() && FirstChild()->ToText() )
FirstChild()->SetValue( buf );
else {
XMLText* theText = GetDocument()->NewText( buf );
InsertFirstChild( theText );
}
}
void XMLElement::SetText( double inNum )
{
char buf[BUF_SIZE];
@ -1336,6 +1323,29 @@ void XMLElement::SetText( float inNum )
}
void XMLElement::SetBoolFirstChild( bool inBool )
{
if( FirstChild() && FirstChild()->ToElement()
&& (strcmp(FirstChild()->Value(),"true") == 0 || strcmp(FirstChild()->Value(),"false") == 0) ) {
FirstChild()->SetValue( inBool ? "true" : "false" );
}
else if( !FirstChild() ) {
XMLElement* theText = GetDocument()->NewElement( inBool ? "true" : "false" );
InsertFirstChild( theText );
}
}
bool XMLElement::BoolFirstChild()
{
if ( FirstChild() && FirstChild()->ToElement() ) {
return strcmp( FirstChild()->Value(), "true" ) == 0;
}
return false;
}
XMLError XMLElement::QueryIntText( int* ival ) const
{
if ( FirstChild() && FirstChild()->ToText() ) {

8
tinyxml2.h
View File

@ -1411,9 +1411,6 @@ public:
/// Sets the text to the given number.
void SetText( unsigned inNum );
/// Sets the text to the given boolean.
void SetText( bool inBool );
/// Sets the text to the given double.
void SetText( double inNum );
@ -1421,6 +1418,11 @@ public:
void SetText( float inNum );
/// Adds a sub-element equivalent to the given boolean.
void SetBoolFirstChild( bool inBool );
bool BoolFirstChild();
/**
Convenience method to query the value of a child text node. This is probably best
shown by example. Given you have a document is this form: