encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmake: handle warning flags properly (thanks to hgs3 for pointers.) 

fixes https://github.com/libsdl-org/SDL/issues/4983
This commit is contained in:
Ozkan Sezer 2021-11-23 18:56:50 +03:00
parent f8900583e5
commit b7f9c2089a
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
CMakeLists.txt
View File

@ -256,6 +256,15 @@ if(MSVC)
string(REGEX REPLACE "/RTC(su|[1su])" "" ${flag_var} "${${flag_var}}") string(REGEX REPLACE "/RTC(su|[1su])" "" ${flag_var} "${${flag_var}}")
endforeach(flag_var) endforeach(flag_var)
endif() endif()
if(MSVC_CLANG)
# clang-cl treats '/W4' as '-Wall -Wextra' -- we don't need -Wextra.
foreach(flag_var
CMAKE_C_FLAGS CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_RELEASE
CMAKE_C_FLAGS_MINSIZEREL CMAKE_C_FLAGS_RELWITHDEBINFO)
string(REGEX REPLACE "/W4" "/W3" ${flag_var} "${${flag_var}}")
endforeach(flag_var)
endif()
endif() endif()
# Those are used for pkg-config and friends, so that the SDL2.pc, sdl2-config, # Those are used for pkg-config and friends, so that the SDL2.pc, sdl2-config,
@ -495,8 +504,12 @@ endif()
# Compiler option evaluation # Compiler option evaluation
if(USE_GCC OR USE_CLANG) if(USE_GCC OR USE_CLANG)
# Check for -Wall first, so later things can override pieces of it. # Check for -Wall first, so later things can override pieces of it.
# Note: clang-cl treats -Wall as -Weverything (which is very loud),
# /W3 as -Wall, and /W4 as -Wall -Wextra. So: /W3 is enough.
check_c_compiler_flag(-Wall HAVE_GCC_WALL) check_c_compiler_flag(-Wall HAVE_GCC_WALL)
if(HAVE_GCC_WALL) if(MSVC_CLANG)
list(APPEND EXTRA_CFLAGS "/W3")
elseif(HAVE_GCC_WALL)
list(APPEND EXTRA_CFLAGS "-Wall") list(APPEND EXTRA_CFLAGS "-Wall")
if(HAIKU) if(HAIKU)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-multichar") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-multichar")