2021-07-13 12:18:13 +00:00
|
|
|
struct Inner {
|
|
|
|
int x;
|
|
|
|
};
|
|
|
|
|
transform: Fixes for DecomposeMemoryAccess
CloneContext::Replace(T* what, T* with) is bug-prone, as complex transforms may want to clone `what` multiple times, or not at all. In both cases, this will likely result in an ICE as either the replacement will be reachable multiple times, or not at all.
The CTS test: webgpu:shader,execution,robust_access:linear_memory:storageClass="storage";storageMode="read_write";access="read";atomic=true;baseType="i32"
Was triggering this brokenness with DecomposeMemoryAccess's use of CloneContext::Replace(T*, T*).
Switch the usage of CloneContext::Replace(T*, T*) to the new function form.
As std::function is copyable, it cannot hold a captured std::unique_ptr.
This prevented the Replace() lambdas from capturing the necessary `BufferAccess` data, as this held a `std::unique_ptr<Offset>`.
To fix this, use a `BlockAllocator` for Offsets, and use raw pointers instead.
Because the function passed to Replace() is called just before the node is cloned, insertion of new functions will occur just before the currently evaluated module-scope entity.
This allows us to remove the "insert_after" arguments to LoadFunc(), StoreFunc(), and AtomicFunc().
We can also kill the icky InsertGlobal() and TypeDeclOf() helpers.
Bug: tint:993
Change-Id: I60972bc13a2fa819a163ee2671f61e82d0e68d2a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/58222
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2021-07-15 20:29:09 +00:00
|
|
|
ByteAddressBuffer s : register(t0, space0);
|
|
|
|
|
2021-07-13 12:18:13 +00:00
|
|
|
float2x3 tint_symbol_6(ByteAddressBuffer buffer, uint offset) {
|
|
|
|
return float2x3(asfloat(buffer.Load3((offset + 0u))), asfloat(buffer.Load3((offset + 16u))));
|
|
|
|
}
|
|
|
|
|
2021-07-16 19:47:44 +00:00
|
|
|
float3x2 tint_symbol_7(ByteAddressBuffer buffer, uint offset) {
|
2021-07-13 12:18:13 +00:00
|
|
|
return float3x2(asfloat(buffer.Load2((offset + 0u))), asfloat(buffer.Load2((offset + 8u))), asfloat(buffer.Load2((offset + 16u))));
|
|
|
|
}
|
|
|
|
|
|
|
|
Inner tint_symbol_9(ByteAddressBuffer buffer, uint offset) {
|
|
|
|
const Inner tint_symbol_11 = {asint(buffer.Load((offset + 0u)))};
|
|
|
|
return tint_symbol_11;
|
|
|
|
}
|
|
|
|
|
2022-01-20 22:11:07 +00:00
|
|
|
typedef Inner tint_symbol_10_ret[4];
|
2021-07-13 12:18:13 +00:00
|
|
|
tint_symbol_10_ret tint_symbol_10(ByteAddressBuffer buffer, uint offset) {
|
2022-01-20 22:11:07 +00:00
|
|
|
Inner arr[4] = (Inner[4])0;
|
2021-07-16 19:47:44 +00:00
|
|
|
{
|
2022-09-29 16:53:58 +00:00
|
|
|
for(uint i_1 = 0u; (i_1 < 4u); i_1 = (i_1 + 1u)) {
|
2022-01-20 22:11:07 +00:00
|
|
|
arr[i_1] = tint_symbol_9(buffer, (offset + (i_1 * 4u)));
|
2021-07-16 19:47:44 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return arr;
|
2021-07-13 12:18:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
[numthreads(1, 1, 1)]
|
|
|
|
void main() {
|
|
|
|
const int3 a = asint(s.Load3(0u));
|
|
|
|
const int b = asint(s.Load(12u));
|
|
|
|
const uint3 c = s.Load3(16u);
|
|
|
|
const uint d = s.Load(28u);
|
|
|
|
const float3 e = asfloat(s.Load3(32u));
|
|
|
|
const float f = asfloat(s.Load(44u));
|
|
|
|
const float2x3 g = tint_symbol_6(s, 48u);
|
2021-07-16 19:47:44 +00:00
|
|
|
const float3x2 h = tint_symbol_7(s, 80u);
|
2021-07-13 12:18:13 +00:00
|
|
|
const Inner i = tint_symbol_9(s, 104u);
|
2022-01-20 22:11:07 +00:00
|
|
|
const Inner j[4] = tint_symbol_10(s, 108u);
|
2021-07-13 12:18:13 +00:00
|
|
|
return;
|
|
|
|
}
|