encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/docs/tint/origin-trial-changes.md

128 lines
6.1 KiB
Markdown
Raw Normal View History

Allow array size to be a module-scope constant Change ast::Array to use an ast::Expression for its `size` field. The WGSL frontend now parses the array size as an `primary_expression`, and the Resolver is responsible for validating the expression is a signed or unsigned integer, and either a literal or a non-overridable module-scope constant. The Resolver evaluates the constant value of the size expression, and so the resolved sem::Array type still has a constant size as before. Fixed: tint:1068 Fixed: tint:1117 Change-Id: Icfa141482ea1e47ea8c21a25e9eb48221f176e9a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/63061 Auto-Submit: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-09-02 13:49:59 +00:00
# Tint changes during Origin Trial
Remove @block attribute Since this was the only attribute allowed on structures, we can also remove the parsing code for them. However, we still need to have attributes on the struct AST node, since the AddSpirvBlockAttribute transform adds one. Fixed: tint:1324 Change-Id: I7966237765b1d8a58c59908b59e1f1152a8a0439 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83740 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2022-03-21 16:09:17 +00:00
## Changes for M102
wgsl: make if/switch parentheses optional Fixed: tint:1424 Change-Id: Id135c74fbbba941cce7fb96970d3c23417bc14ec Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/84340 Kokoro: Kokoro <noreply+kokoro@google.com> Auto-Submit: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-03-23 09:11:03 +00:00
### New Features
* Parentheses are no longer required around expressions for if and switch statements [tint:1424](crbug.com/tint/1424)
Remove @block attribute Since this was the only attribute allowed on structures, we can also remove the parsing code for them. However, we still need to have attributes on the struct AST node, since the AddSpirvBlockAttribute transform adds one. Fixed: tint:1324 Change-Id: I7966237765b1d8a58c59908b59e1f1152a8a0439 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83740 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2022-03-21 16:09:17 +00:00
### Breaking changes
wgsl: Separate struct members with commas Use of semicolons is still supported, but deprecated. Also updates the parsing methods for structures to better match the WGSL grammar. Bug: tint:1475 Change-Id: I7675ba42c13f91080b0ac173c352e0092021f80b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/84380 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-03-28 14:31:22 +00:00
* Struct members are now separated by commas. [tint:1475](crbug.com/tint/1475)
Remove @block attribute Since this was the only attribute allowed on structures, we can also remove the parsing code for them. However, we still need to have attributes on the struct AST node, since the AddSpirvBlockAttribute transform adds one. Fixed: tint:1324 Change-Id: I7966237765b1d8a58c59908b59e1f1152a8a0439 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83740 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2022-03-21 16:09:17 +00:00
* The `@block` attribute has been removed. [tint:1324](crbug.com/tint/1324)
Remove support for the @stride attribute We still use the StrideAttribute AST node in the SPIR-V reader for strided arrays and matrices, which are then removed by transforms. The WGSL parser no longer has to handle attributes on types. Bug: tint:1381 Change-Id: Ifa39575ce207d3fdfcbef7125fe6a3686fad5f20 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83963 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-03-21 16:09:17 +00:00
* The `@stride` attribute has been removed. [tint:1381](crbug.com/tint/1381)
Remove support for [[attribute]] syntax Fixed: tint:1382 Change-Id: I7bebeb59fd0a57a69929e9bf5aa768ae1ff8a33d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83961 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-03-21 16:09:17 +00:00
* Attributes using `[[attribute]]` syntax are no longer supported. [tint:1382](crbug.com/tint/1382)
Remove support for the elseif keyword This was deprecated in M99 and can now be removed. Fixed: tint:1289 Change-Id: I6513360c5615609a3cc36ae28d5ef8ebddece710 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83964 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-03-21 16:09:17 +00:00
* The `elseif` keyword is no longer supported. [tint:1289](crbug.com/tint/1289)
Remove @block attribute Since this was the only attribute allowed on structures, we can also remove the parsing code for them. However, we still need to have attributes on the struct AST node, since the AddSpirvBlockAttribute transform adds one. Fixed: tint:1324 Change-Id: I7966237765b1d8a58c59908b59e1f1152a8a0439 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/83740 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2022-03-21 16:09:17 +00:00
Minor fixups for unicode CL This didn't make the M100 release branch, so update the release notes. Fix a type in one of the E2E test names. Bug: tint:1437 Change-Id: I36c018a126f412607a55ff254add60dae4fa9ae5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/81200 Auto-Submit: James Price <jrprice@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-18 21:47:24 +00:00
## Changes for M101
### New Features
* Tint now supports unicode identifiers. [tint:1437](crbug.com/tint/1437)
Remove isNan, isInf, isFinite, and isNormal These were deprecated in M98. Fixed: tint:1312 Change-Id: Ieec17bfcc729f90d0a9aa8904a162167b9de54ed Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/82800 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-03-05 00:39:14 +00:00
### Breaking changes
* The `isNan()`, `isInf()`, `isFinite()`, and `isNormal()` builtins have been removed. [tint:1312](https://crbug.com/tint/1312)
validation: Require interpolate(flat) for integers This was made a warning in M97, and can now become a hard error. Fixed: tint:1224 Change-Id: Ied72f6e28b3dc64a6ab832e0eac53f62ce045d40 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/77700 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-01-25 01:01:39 +00:00
## Changes for M100
### Breaking changes
* The `@interpolate(flat)` attribute must now be specified on integral user-defined IO. [tint:1224](crbug.com/tint/1224)
intrinsics: Remove ignore() This has been deprecated since M97. Fixed: tint:1214 Change-Id: I970898f2ae8baf1916e2f8d43230d8b724641730 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/78785 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-01 17:21:52 +00:00
* The `ignore()` intrinsic has been removed. Use phoney-assignment instead: `ignore(expr);` -> `_ = expr;`.
resolver: Correctly validate 'break' inside 'continuing' We haven't been correctly checking the esoteric set of rules around breaks in continuing statements. Bug: chromium:1288919 Change-Id: Ica6a0e71d06d9b204c359fea5f778db2383e6fa1 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/78860 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-03 00:12:52 +00:00
* `break` statements in `continuing` blocks are now correctly validated.
validation: Require interpolate(flat) for integers This was made a warning in M97, and can now become a hard error. Fixed: tint:1224 Change-Id: Ied72f6e28b3dc64a6ab832e0eac53f62ce045d40 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/77700 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-01-25 01:01:39 +00:00
docs: document that OOO-decls is now supported Fixed: tint:1266 Change-Id: Ib78038bdf63dfeae6c2e328213560c37df41eb81 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80520 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-02-14 21:56:06 +00:00
### New Features
* Module-scope declarations can now be declared in any order. [tint:1266](crbug.com/tint/1266)
Add support for override keyword and @id attribute This replaces the @override keyword that was previously used for pipeline-overridable constants. Support for pipeline-overridable constants in Dawn is hidden behind the "disallow-unsafe-APIs" toggle, so we can make this change directly instead of deprecating and continuing to support the old syntax. Fixed: tint:1403 Change-Id: I9b2957a1e33b12772bfe449c0f3a31d929f8aa8b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80480 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-02-15 16:36:57 +00:00
* The `override` keyword and `@id()` attribute for pipeline-overridable constants are now supported, replacing the `@override` attribute. [tint:1403](crbug.com/tint/1403)
docs: document that OOO-decls is now supported Fixed: tint:1266 Change-Id: Ib78038bdf63dfeae6c2e328213560c37df41eb81 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80520 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-02-14 21:56:06 +00:00
docs: Move OT changes to M99 These missed the M98 boat. Change-Id: Ic15e8323457d78eea1ea3c59c104b2901c883b1b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72321 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2021-12-09 22:53:14 +00:00
## Changes for M99
validation: Error on obviously infinite loops Most of this change is fixing up the numerious tests that violated this rule. Fixed: tint:1365 Issue: tint:1374 Change-Id: I38da27c7367277fe60857208170fec017e80bd25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/76400 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-01-14 17:16:32 +00:00
### Breaking changes
Obviously infinite loops (no condition, no break) are now a validation error.
docs: Move OT changes to M99 These missed the M98 boat. Change-Id: Ic15e8323457d78eea1ea3c59c104b2901c883b1b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72321 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2021-12-09 22:53:14 +00:00
### Deprecated Features
wgsl: Replace 'elseif' with 'else if' Bug: tint:1289 Change-Id: I72432391e60cf5ff173aa51a6d4a2bc8ef58fbf2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75240 Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-01-04 20:06:49 +00:00
The following features have been deprecated and will be removed in M102:
* The `[[block]]` attribute has been deprecated. [tint:1324](https://crbug.com/tint/1324)
wgsl: Replace [[decoration]] with @decoration Deprecate the old syntax. Migrate everything to the new syntax. Bug: tint:1382 Change-Id: Ide12b2e927b17dc93b9714c7049090864cc568d3 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/77260 Reviewed-by: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: David Neto <dneto@google.com>
2022-01-19 22:46:57 +00:00
* Attributes now use the `@decoration` syntax instead of the `[[decoration]]` syntax. [tint:1382](https://crbug.com/tint/1382)
* `elseif` has been replaced with `else if`. [tint:1289](https://crbug.com/tint/1289)
Deprecate the @stride attribute Update validation error for invalid uniform array element alignment. Update tests to either remove the @stride attribute or use a different element type. Bug: tint:1381 Change-Id: I50b52cd78a34d9cd162fa5f2171a5fd35dcf3b79 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/77560 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-01-20 22:11:07 +00:00
* The `[[stride]]` attribute has been deprecated. [tint:1381](https://crbug.com/tint/1381)
docs: Move OT changes to M99 These missed the M98 boat. Change-Id: Ic15e8323457d78eea1ea3c59c104b2901c883b1b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72321 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2021-12-09 22:53:14 +00:00
### New Features
* Vector and matrix element type can now be inferred from constructor argument types. [tint:1334](https://crbug.com/tint/1334)
intrinsics: Add degrees() and radians() Fixed: tint:1329 Change-Id: I5fb927268fc9cb8047a2b365d26e813a8546605a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75423 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-01-05 20:11:00 +00:00
* Added builtins `degrees()` and `radians()` for converting between degrees and radians. [tint:1329](https://crbug.com/tint/1329)
Re-allow dynamic indexing of 'let' arrays and matrices Spec change: https://github.com/gpuweb/gpuweb/pull/2427 Reverses: tint:867 This reverts and fixes commits: b6fdcc54df6e012578e69550788e2b4b2b611c32 10442eff7db4271d53eed553795e655068488276 Added a bunch of end-to-end tests. Fixed: tint:1352 Change-Id: I34968243bbec1cab838c8ba50a6f027146bbfd06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75401 Reviewed-by: David Neto <dneto@google.com> Reviewed-by: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-01-06 18:11:01 +00:00
* `let` arrays and matrices can now be dynamically indexed. [tint:1352](https://crbug.com/tint/1352)
Add non-struct buffer types to the release notes Fixed: tint:1372 Change-Id: I394c33eb80ea1ce347794bc63965f6080ca92c61 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/76165 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-01-19 15:55:56 +00:00
* Storage and Uniform buffer types no longer have to be structures. [tint:1372](crbug.com/tint/1372)
wgsl: Do not require a semicolon after a struct Don't generate them either, which generated a lot of test churn. Fixed: tint:1380 Change-Id: I0a7cfdd2ef0ffe8e7fda111fbc57997b36b949e0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/77165 Auto-Submit: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2022-01-19 18:11:17 +00:00
* A struct declaration does not have to be followed by a semicolon. [tint:1380](crbug.com/tint/1380)
docs: Move OT changes to M99 These missed the M98 boat. Change-Id: Ic15e8323457d78eea1ea3c59c104b2901c883b1b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/72321 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2021-12-09 22:53:14 +00:00
transform: Fix PromoteInitializersToConstVar handling of for-loops PromoteInitializersToConstVar was erroring on for loops that contained array or structure constructor expressions. Added lots more tests. Fixed: tint:1364 Change-Id: I033eaad94756ea496fc8bc5f03f39c6dba4e3a88 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75580 Reviewed-by: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2022-01-06 21:32:41 +00:00
### Fixes
* Fixed an issue where for-loops that contain array or structure constructors in the loop initializer statements, condition expressions or continuing statements could fail to compile. [tint:1364](https://crbug.com/tint/1364)
Disallow taking the address of a vector component Update or remove tests that try to do this. Fixed: tint:491 Change-Id: I1f351a4abf68ae9bc6b100885fb1bcea08b31211 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68242 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-11-04 19:55:57 +00:00
## Changes for M98
### Breaking Changes
* Taking the address of a vector component is no longer allowed.
resolver: Forbid module-scope declarations from aliasing a builtin Fixed: tint:1318 Change-Id: Ifcb1aced6885bebcf3eb883f39bfbd0871dae7b0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70663 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-11-26 09:56:19 +00:00
* Module-scope declarations can no longer alias a builtin name. [tint:1318](https://crbug.com/tint/1318)
resolver: Migrate validation to behavior analysis Migrate some of the validation logic over to use the results of behavior analysis. The most significant changes are: * Unreachable-statements now consider merge-points of control flow. For example, if all branches of a if-statement or switch-statement either return or discard, the next statement will be considered unreachable. * Unreachable statements are no longer an error, but a warning. See https://github.com/gpuweb/gpuweb/issues/2378. * Statements that follow a loops that does not break, or have a conditional will now be considered unreachable. * Unreachable statements produced by the SPIR-V reader are now removed using the new RemoveUnreachableStatements transform. Some other new changes include additional validation for the continuing block for for-loops, to match the rules of a loop continuing block. The new cases this validation is testing for are not expressible in WGSL, but some transforms may produce complex continuing statements that might violate these rules. All the writers are able to decay these complex for-loop continuing statements to regular loops. Bug: tint:1302 Change-Id: I0d8a48c73d5d5c30a1cddf92cc3383a692a58e61 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71500 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-12-03 17:51:48 +00:00
* It is now an error to call a function either directly or transitively, from a loop continuing block, that uses `discard`. [tint:1302](https://crbug.com/tint/1302)
Disallow taking the address of a vector component Update or remove tests that try to do this. Fixed: tint:491 Change-Id: I1f351a4abf68ae9bc6b100885fb1bcea08b31211 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68242 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-11-04 19:55:57 +00:00
intrinsics: Deprecate isNan, isInf, isFinite, isNormal These have all been removed from the spec as we cannot guarantee they will behave as expected on the various backends. Bug: tint:1312 Change-Id: I9d7d81cfdc44489fffe08c5183ed8da84901a024 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70665 Reviewed-by: Antonio Maiorano <amaiorano@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-11-23 18:57:57 +00:00
### Deprecated Features
* The `isNan()`, `isInf()`, `isFinite()` and `isNormal()` builtins has been deprecated and will be removed in M101. [tint:1312](https://crbug.com/tint/1312)
instrinsics: Implement dot() for integer vector types Fixed: tint:1263 Change-Id: I642ea0b6c9be7f04930cf6ea1a8059825661e326 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68520 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-11-05 18:37:16 +00:00
### New Features
Implement textureGather, textureGatherCompare All writers implemented, along with resolving and validation. TODO: SPIR-V Reader. Bug: tint:1330 Change-Id: I8ba2f6023749474f80efb8a5422ac187e6c73a69 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71820 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com>
2021-12-08 19:54:08 +00:00
* New texture gather builtins: `textureGather()` and `textureGatherCompare()`. [tint:1330](https://crbug.com/tint/1330)
resolver: Support shadowing Add transform::Unshadow to renamed shadowed symbols. Required by a number of other transforms. Replace Resolver symbol resolution with dep-graph. The dependency graph now performs full symbol resolution before the regular resolver pass. Make use of this instead of duplicating the effort. Simplfies code, and actually performs variable shadowing consistently. Fixed: tint:819 Bug: tint:1266 Change-Id: I595d1812aebe1d79d2d32e724ff90de36e74cf4b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70523 Reviewed-by: David Neto <dneto@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-11-23 20:45:51 +00:00
* Shadowing is now fully supported. [tint:819](https://crbug.com/tint/819)
instrinsics: Implement dot() for integer vector types Fixed: tint:1263 Change-Id: I642ea0b6c9be7f04930cf6ea1a8059825661e326 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68520 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-11-05 18:37:16 +00:00
* The `dot()` builtin now supports integer vector types.
IntrinsicTable: remove double underscores '__' is reserved in C++, and the 'match__' and 'build__' functions are causing OSS-fuzz builds to fail. Add the change in tint behavior to the OT notes. Add end to end tests for underscores. While the GLSL and MSL compilers seem to accept leading and double underscores in identifiers, the tint build failure has highlighted we have more work to do here (crbug.com/tint/1319) Fixed: oss-fuzz:41214 Bug: tint:1292 Bug: tint:1319 Change-Id: I32b7bf4e0cff26e678b788457f90452c2503da50 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70480 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-11-22 15:24:16 +00:00
* Identifiers can now start with a single leading underscore. [tint:1292](https://crbug.com/tint/1292)
resolver: Migrate validation to behavior analysis Migrate some of the validation logic over to use the results of behavior analysis. The most significant changes are: * Unreachable-statements now consider merge-points of control flow. For example, if all branches of a if-statement or switch-statement either return or discard, the next statement will be considered unreachable. * Unreachable statements are no longer an error, but a warning. See https://github.com/gpuweb/gpuweb/issues/2378. * Statements that follow a loops that does not break, or have a conditional will now be considered unreachable. * Unreachable statements produced by the SPIR-V reader are now removed using the new RemoveUnreachableStatements transform. Some other new changes include additional validation for the continuing block for for-loops, to match the rules of a loop continuing block. The new cases this validation is testing for are not expressible in WGSL, but some transforms may produce complex continuing statements that might violate these rules. All the writers are able to decay these complex for-loop continuing statements to regular loops. Bug: tint:1302 Change-Id: I0d8a48c73d5d5c30a1cddf92cc3383a692a58e61 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71500 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-12-03 17:51:48 +00:00
* Control flow analysis has been improved, and functions no longer need to `return` if the statement is unreachable. [tint:1302](https://crbug.com/tint/1302)
* Unreachable statements now produce a warning instead of an error, to allow WGSL code to be updated to the new analysis behavior. These warnings may become errors in the future [gpuweb#2378](https://github.com/gpuweb/gpuweb/issues/2378)
instrinsics: Implement dot() for integer vector types Fixed: tint:1263 Change-Id: I642ea0b6c9be7f04930cf6ea1a8059825661e326 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68520 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-11-05 18:37:16 +00:00
resolver: Track global uses in function decorations Fixed: tint:1320 Change-Id: Ib92c37d4de0641d11e508be4d8e05d641e808be9 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70662 Reviewed-by: James Price <jrprice@google.com> Reviewed-by: David Neto <dneto@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-11-23 21:46:48 +00:00
### Fixes
* Fixed an issue where using a module-scoped `let` in a `workgroup_size` may result in a compilation error. [tint:1320](https://crbug.com/tint/1320)
docs: Fix origin trial number The listed changes aren't going to land into M97, as M96 has already been cut. Change-Id: I7b636bf7a6da3b831ad8f121acd0f8c3f87a1423 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/66381 Auto-Submit: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-10-14 03:17:32 +00:00
## Changes for M97
intrinsics: Remove deprecated modf & frexp overloads These have been deprecated for multiple chrome releases. Change-Id: I4cc05a74ff8f085e6d13f93aefb93077480e52f5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/66261 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-10-12 21:57:47 +00:00
### Breaking Changes
* Deprecated `modf()` and `frexp()` builtin overloads that take a pointer second parameter have been removed.
Resolver: Remove texture_storage read access The intrinsics that did anything useful with this were deprecated several releases ago. Change-Id: I79e3c901b6a78583853a067ec46cfa98e346517c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/66262 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-10-14 10:10:45 +00:00
* Deprecated texture builtin functions that accepted a `read` access controlled storage texture have been removed.
* Storage textures must now only use the `write` access control.
intrinsics: Remove deprecated modf & frexp overloads These have been deprecated for multiple chrome releases. Change-Id: I4cc05a74ff8f085e6d13f93aefb93077480e52f5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/66261 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-10-12 21:57:47 +00:00
Deprecate Ignore() It's been removed from the spec: https://github.com/gpuweb/gpuweb/pull/2127 Fixed: tint:1213 Change-Id: I163fe807765bb1ac0580b398f4897daea555216a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67067 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-10-22 06:23:12 +00:00
### Deprecated Features
* The `ignore()` builtin has been replaced with phony-assignment. [gpuweb#2127](https://github.com/gpuweb/gpuweb/pull/2127)
intrinsics: Add scalar overload of all() & any() Fixed: tint:1253 Change-Id: I0bdc865a9df9e0171c09daa9918b25bba033ba3b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67061 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@chromium.org>
2021-10-21 09:39:13 +00:00
### New Features
* `any()` and `all()` now support a `bool` parameter. These simply return the passed argument. [tint:1253](https://crbug.com/tint/1253)
resolver: Remove rule that call statements to functions must return void Fixed: tint:1256 Change-Id: Ibff78a1009d57afd7af8867952a9444daaf13a9c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67201 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-10-21 20:36:04 +00:00
* Call statements may now include functions that return a value (`ignore()` is no longer needed).
validation: Allow interpolate(flat) on integral IO Produce a warning if the attribute is missing for integral vertex outputs or fragment inputs. This will become an error in the future, as per the WGSL spec. Add the attribute to E2E tests. Bug: tint:1224 Change-Id: Ia1f353f36cb7db516cf9e8b4877423dec3b3e711 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67160 Auto-Submit: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-10-21 23:08:44 +00:00
* The `interpolate(flat)` attribute can now be specified on integral user-defined IO. It will eventually become an error to define integral user-defined IO without this attribute.
Add support for matrix construction from scalars Use a transform to convert these to the vector form for the MSL and SPIR-V backends. MSL only has the scalar form from version 2.0 onwards. Fixed: tint:1123 Change-Id: I384abd9872d9eae52a10a37cbd6aa96004692e9c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67360 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-10-25 19:20:31 +00:00
* Matrix construction from scalar element values is now supported.
intrinsics: Add scalar overload of all() & any() Fixed: tint:1253 Change-Id: I0bdc865a9df9e0171c09daa9918b25bba033ba3b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67061 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@chromium.org>
2021-10-21 09:39:13 +00:00
writer/msl: Fix swizzling on packed vectors Metal 1.x does not support swizzling on packed_vec types. Use array-index for single element selection (permitted on LHS and RHS of assignment) Cast the packed_vec to a vec for multiple element swizzles (not permitted as the LHS of an assignment). Fixed: tint:1249 Change-Id: I70cbb0c22a935b06b3905d24484bdc2edfb95fc2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67060 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-10-20 16:12:33 +00:00
### Fixes
* Swizzling of `vec3` types in `storage` and `uniform` buffers has been fixed for Metal 1.x. [tint:1249](https://crbug.com/tint/1249)
writer/hlsl: Do not emit `(void) call_expr;` Just emit `call_expr;` instead. Fixed: tint:1259 Change-Id: I84a2976d82f891e9263f3e11e5774fcb01ea09bd Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67381 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-10-25 11:00:44 +00:00
* Calling a function that returns an unused value no longer produces an FXC compilation error. [tint:1259](https://crbug.com/tint/1259)
tools roll-release: Bump branchLegacyCutoff to M96 The tool was getting slow, due to the number of branches being examined. M96 is the latest stable release. We aren't applying fixes to this or older branches. Also avoids an issue where the M95 branch was missing a cherry-pick, which the tool wanted to merge with each run. Change-Id: I8a8b1466c10633d9539725cd4f9b1b0514e41e93 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75067 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
2022-01-05 21:03:10 +00:00
* `abs()` fixed for unsigned integers on SPIR-V backend
writer/msl: Fix swizzling on packed vectors Metal 1.x does not support swizzling on packed_vec types. Use array-index for single element selection (permitted on LHS and RHS of assignment) Cast the packed_vec to a vec for multiple element swizzles (not permitted as the LHS of an assignment). Fixed: tint:1249 Change-Id: I70cbb0c22a935b06b3905d24484bdc2edfb95fc2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/67060 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-10-20 16:12:33 +00:00
Allow array size to be a module-scope constant Change ast::Array to use an ast::Expression for its `size` field. The WGSL frontend now parses the array size as an `primary_expression`, and the Resolver is responsible for validating the expression is a signed or unsigned integer, and either a literal or a non-overridable module-scope constant. The Resolver evaluates the constant value of the size expression, and so the resolved sem::Array type still has a constant size as before. Fixed: tint:1068 Fixed: tint:1117 Change-Id: Icfa141482ea1e47ea8c21a25e9eb48221f176e9a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/63061 Auto-Submit: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-09-02 13:49:59 +00:00
## Changes for M95
### New Features
writer/spirv: Fix abs() on unsigned integers GLSLstd450SAbs expects a *signed* integer. abs() of an unsigned number is now a no-op. Fixes WebGPU CTS tests: webgpu:shader,execution,robust_access_vertex:vertex_buffer_access:* Bug: tint:1194 Change-Id: I65c5e9f2f03aac0b788b9ba88c383cbec136d7c6 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/65620 Commit-Queue: Ben Clayton <bclayton@chromium.org> Kokoro: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-10-01 08:41:55 +00:00
Allow array size to be a module-scope constant Change ast::Array to use an ast::Expression for its `size` field. The WGSL frontend now parses the array size as an `primary_expression`, and the Resolver is responsible for validating the expression is a signed or unsigned integer, and either a literal or a non-overridable module-scope constant. The Resolver evaluates the constant value of the size expression, and so the resolved sem::Array type still has a constant size as before. Fixed: tint:1068 Fixed: tint:1117 Change-Id: Icfa141482ea1e47ea8c21a25e9eb48221f176e9a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/63061 Auto-Submit: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-09-02 13:49:59 +00:00
* The size of an array can now be defined using a non-overridable module-scope constant
Implement and test num_workgroups for all backends For HLSL, use the new NumWorkgroupsFromUniform transform, and expose the binding point to use for the generated uniform as a backend option. The MSL mapping is trivial, and it was already implemented for WGSL and SPIR-V. Bug: tint:752 Change-Id: I4bd37b5d26181629d72b152fe064a60caf8ecdc5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/63962 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-09-13 17:11:58 +00:00
* The `num_workgroups` builtin is now supported.
wgsl-reader: hex float: zero mantissa results in zero result When the magnitude is zero, then we don't care about the magnitude of the exponent. The result value is always zero, without emitting an error. Fixed: tint:1166 Change-Id: I303d7c336e7ea42719571854f0a22cbfd19da32c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/63520 Kokoro: Kokoro <noreply+kokoro@google.com> Auto-Submit: David Neto <dneto@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-09-08 13:46:51 +00:00
### Fixes
writer/spirv: Fix abs() on unsigned integers GLSLstd450SAbs expects a *signed* integer. abs() of an unsigned number is now a no-op. Fixes WebGPU CTS tests: webgpu:shader,execution,robust_access_vertex:vertex_buffer_access:* Bug: tint:1194 Change-Id: I65c5e9f2f03aac0b788b9ba88c383cbec136d7c6 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/65620 Commit-Queue: Ben Clayton <bclayton@chromium.org> Kokoro: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-10-01 08:41:55 +00:00
* Hex floats: now correctly errors when the magnitude is non-zero, and the exponent would cause overflow. [tint:1150](https://crbug.com/tint/1150), [tint:1166](https://crbug.com/tint/1166)
intrinsics: Remove deprecated modf & frexp overloads These have been deprecated for multiple chrome releases. Change-Id: I4cc05a74ff8f085e6d13f93aefb93077480e52f5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/66261 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-10-12 21:57:47 +00:00
* Identifiers beginning with an underscore are now correctly rejected. [tint:1179](https://crbug.com/tint/1179)