encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/BUILD.gn

664 lines
27 KiB
Plaintext
Raw Normal View History

Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
# Copyright 2021 The Tint Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import("//build_overrides/build.gni")
import("//testing/test.gni")
import("../tint_overrides_with_defaults.gni")
###############################################################################
# Gtest Gmock - Handle building inside and outside of Chromium.
###############################################################################
# When building outside of Chromium we need to define our own targets for GTest
# and GMock. However when compiling inside of Chromium we need to reuse the
# existing targets, both because Chromium has a special harness for swarming
# and because otherwise the "gn check" fails.
if (!build_with_chromium) {
# When we aren't in Chromium we define out own targets based on the location
# of the googletest repo.
config("gtest_config") {
include_dirs = [
"${tint_googletest_dir}/googletest",
"${tint_googletest_dir}/googletest/include",
]
}
static_library("gtest") {
testonly = true
sources = [ "${tint_googletest_dir}/googletest/src/gtest-all.cc" ]
public_configs = [ ":gtest_config" ]
}
config("gmock_config") {
include_dirs = [
"${tint_googletest_dir}/googlemock",
"${tint_googletest_dir}/googlemock/include",
"${tint_googletest_dir}/googletest/include",
]
}
static_library("gmock") {
testonly = true
sources = [ "${tint_googletest_dir}/googlemock/src/gmock-all.cc" ]
public_configs = [ ":gmock_config" ]
}
group("gmock_and_gtest") {
testonly = true
public_deps = [
":gmock",
":gtest",
]
}
} else {
# When we are in Chromium we reuse its targets, and also add some deps that
# are needed to launch the test in swarming mode.
group("gmock_and_gtest") {
testonly = true
public_deps = [
"//base",
"//base/test:test_support",
"//testing/gmock",
"//testing/gtest",
"//third_party/googletest:gmock",
]
}
}
###############################################################################
# Wrapping of Chromium targets
###############################################################################
# These targets are separated because they are Chromium sources files that
# can't use the tint_internal config, otherwise Tint's warning flags get
# applied while compiling a bunch of Chromium's //base (via header inclusion)
source_set("tint_unittests_main") {
testonly = true
deps = [ ":gmock_and_gtest" ]
if (build_with_chromium) {
sources = [ "//gpu/tint_unittests_main.cc" ]
} else {
sources = [ "../src/test_main.cc" ]
Add --dump-spirv option to tint_unittests The --dump-spirv option tells tint_unittests to output the SPIR-V assembly text for a module which did not make the SPIR-V reader fail. This lets us get extract a corpus of SPIR-V modules, and lets us more easily verify that the test shaders are valid in the first place. Also: - Add test/extract-spvasm.py to split that output to separate SPIR-V assembly files - Add optional second argument test/test-all.sh to specify a directory look for input files. - BUILD.gn: Add dependency from //test:tint_unittests_main to //test:tint_unittests_config to pick up source dependency on the internal header of the SPIRV-Tools optimizer, needed by the indirection through src/reader/spirv/parser_impl_test_helper.h This is useful for bulk testing Fixed: tint:756 Change-Id: I4fe232ac736003f7d9be35544328302d652381ea Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49605 Auto-Submit: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-05-05 09:46:31 +00:00
configs += [ ":tint_unittests_config" ]
Get `gn gen --check` actually working in repo Fixes an issue in the .gn that allows the check to run as expected. As well as fixes issues discovered from running the check. BUG=tint:735 Change-Id: I48cd01339d06132933c3da4f0e9d45cdbaff3b55 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48700 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2021-04-21 19:05:14 +00:00
deps += [
":tint_test_helpers",
":tint_unittests_hlsl_writer_src",
":tint_unittests_msl_writer_src",
Add --dump-spirv option to tint_unittests The --dump-spirv option tells tint_unittests to output the SPIR-V assembly text for a module which did not make the SPIR-V reader fail. This lets us get extract a corpus of SPIR-V modules, and lets us more easily verify that the test shaders are valid in the first place. Also: - Add test/extract-spvasm.py to split that output to separate SPIR-V assembly files - Add optional second argument test/test-all.sh to specify a directory look for input files. - BUILD.gn: Add dependency from //test:tint_unittests_main to //test:tint_unittests_config to pick up source dependency on the internal header of the SPIRV-Tools optimizer, needed by the indirection through src/reader/spirv/parser_impl_test_helper.h This is useful for bulk testing Fixed: tint:756 Change-Id: I4fe232ac736003f7d9be35544328302d652381ea Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49605 Auto-Submit: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-05-05 09:46:31 +00:00
":tint_unittests_spv_reader_src",
Get `gn gen --check` actually working in repo Fixes an issue in the .gn that allows the check to run as expected. As well as fixes issues discovered from running the check. BUG=tint:735 Change-Id: I48cd01339d06132933c3da4f0e9d45cdbaff3b55 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48700 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2021-04-21 19:05:14 +00:00
"${tint_root_dir}/src:libtint",
]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
}
###############################################################################
# Tests - For libtint core and optional modules
###############################################################################
config("tint_unittests_config") {
include_dirs = [
"${tint_googletest_dir}/googlemock/include",
"${tint_googletest_dir}/googletest/include",
]
configs = [
"${tint_root_dir}/src:tint_common_config",
"${tint_root_dir}/src:tint_public_config",
]
}
Fix gn check in Chromium - Move headers from libtint_sem_src into libtint_core_all_src so that there is no circular header dependency between headers of these two targets. libtint_sem_src is now just a hack to have a different name for a few .cc files. - Made libtint_core_src publicly depend on its deps so that headers of libtint_core_all_src are made visible through it. - Added spvtools dependencies in a couple places that were mistakenly removed in a previous commit. - Moved helpers common to multiple unittest targets out of tint_unittests_core_src and into a tint_test_helpers target that all tint_unittests_source_set depend on. - Ran GN format that reordered some lists a bit. Bug: None Change-Id: I544a73d73366be9dd2ac8e56c7593fd9f2b86cf8 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48600 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 09:18:52 +00:00
source_set("tint_test_helpers") {
Another attempt to fix failing `gn check --check` in Chromium Change-Id: I6d1690e5c6f8a4b0a8c5265cd3713698f0ee7cab Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48660 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 18:07:12 +00:00
testonly = true
Fix gn check in Chromium - Move headers from libtint_sem_src into libtint_core_all_src so that there is no circular header dependency between headers of these two targets. libtint_sem_src is now just a hack to have a different name for a few .cc files. - Made libtint_core_src publicly depend on its deps so that headers of libtint_core_all_src are made visible through it. - Added spvtools dependencies in a couple places that were mistakenly removed in a previous commit. - Moved helpers common to multiple unittest targets out of tint_unittests_core_src and into a tint_test_helpers target that all tint_unittests_source_set depend on. - Ran GN format that reordered some lists a bit. Bug: None Change-Id: I544a73d73366be9dd2ac8e56c7593fd9f2b86cf8 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48600 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 09:18:52 +00:00
sources = [
"../src/ast/intrinsic_texture_helper_test.cc",
"../src/ast/intrinsic_texture_helper_test.h",
"../src/transform/test_helper.h",
"../src/utils/command.h",
"../src/utils/tmpfile.h",
]
if (is_linux || is_mac) {
sources += [ "../src/utils/command_posix.cc" ]
sources += [ "../src/utils/tmpfile_posix.cc" ]
} else if (is_win) {
sources += [ "../src/utils/command_windows.cc" ]
sources += [ "../src/utils/tmpfile_windows.cc" ]
} else {
sources += [ "../src/utils/command_other.cc" ]
sources += [ "../src/utils/tmpfile_other.cc" ]
}
More BUILD.gn fixes for building Tint in Chromium Bug: None Change-Id: Ib9ed45e428aefd73eeefdbe34d03d9bc499d3679 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48605 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2021-04-21 14:58:42 +00:00
configs += [ ":tint_unittests_config" ]
Another attempt to fix failing `gn check --check` in Chromium Change-Id: I6d1690e5c6f8a4b0a8c5265cd3713698f0ee7cab Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48660 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 18:07:12 +00:00
public_deps = [
":gmock_and_gtest",
"${tint_root_dir}/src:libtint",
]
Fix gn check in Chromium - Move headers from libtint_sem_src into libtint_core_all_src so that there is no circular header dependency between headers of these two targets. libtint_sem_src is now just a hack to have a different name for a few .cc files. - Made libtint_core_src publicly depend on its deps so that headers of libtint_core_all_src are made visible through it. - Added spvtools dependencies in a couple places that were mistakenly removed in a previous commit. - Moved helpers common to multiple unittest targets out of tint_unittests_core_src and into a tint_test_helpers target that all tint_unittests_source_set depend on. - Ran GN format that reordered some lists a bit. Bug: None Change-Id: I544a73d73366be9dd2ac8e56c7593fd9f2b86cf8 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48600 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 09:18:52 +00:00
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
template("tint_unittests_source_set") {
source_set(target_name) {
forward_variables_from(invoker, "*", [ "configs" ])
if (defined(invoker.configs)) {
configs += invoker.configs
}
configs += [ ":tint_unittests_config" ]
if (build_with_chromium) {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
}
testonly = true
if (!defined(invoker.deps)) {
deps = []
}
Another attempt to fix failing `gn check --check` in Chromium Change-Id: I6d1690e5c6f8a4b0a8c5265cd3713698f0ee7cab Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48660 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 18:07:12 +00:00
deps += [ ":tint_test_helpers" ]
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
}
}
tint_unittests_source_set("tint_unittests_core_sem_src") {
sources = [ "../src/sem/intrinsic_test.cc" ]
}
tint_unittests_source_set("tint_unittests_core_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/access_control_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/access_decoration_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/alias_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/array_accessor_expression_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/array_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/assignment_statement_test.cc",
"../src/ast/binary_expression_test.cc",
"../src/ast/binding_decoration_test.cc",
"../src/ast/bitcast_expression_test.cc",
"../src/ast/block_statement_test.cc",
"../src/ast/bool_literal_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/bool_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/break_statement_test.cc",
"../src/ast/builtin_decoration_test.cc",
"../src/ast/call_expression_test.cc",
"../src/ast/call_statement_test.cc",
"../src/ast/case_statement_test.cc",
"../src/ast/continue_statement_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/depth_texture_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/discard_statement_test.cc",
"../src/ast/else_statement_test.cc",
Add ast::ExternalTexture Also create it in wgsl parser. With this, we now create all the AST type nodes in the wgsl parser. Bug: tint:724 Change-Id: I575c9eb0ffbd60c3e7aca0b00227d9833ef65d58 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48962 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-04-26 14:55:25 +00:00
"../src/ast/external_texture_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/f32_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/fallthrough_statement_test.cc",
"../src/ast/float_literal_test.cc",
"../src/ast/function_test.cc",
"../src/ast/group_decoration_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/i32_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/identifier_expression_test.cc",
"../src/ast/if_statement_test.cc",
"../src/ast/int_literal_test.cc",
"../src/ast/location_decoration_test.cc",
"../src/ast/loop_statement_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/matrix_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/member_accessor_expression_test.cc",
"../src/ast/module_clone_test.cc",
"../src/ast/module_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/multisampled_texture_test.cc",
Rename builtin constant_id to override There are no downstream usages, so we can skip deprecation. Allowing the ID to be omitted will be done in a separate patch. Fixed: tint:754 Change-Id: I3bd6de4d0f426fc3c66708bfd5b411a4051b375b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49581 Commit-Queue: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-04-30 17:14:19 +00:00
"../src/ast/override_decoration_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/pointer_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/return_statement_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/sampled_texture_test.cc",
"../src/ast/sampler_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/scalar_constructor_expression_test.cc",
"../src/ast/sint_literal_test.cc",
"../src/ast/stage_decoration_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/storage_texture_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/stride_decoration_test.cc",
Implement Default Struct Layout Implements https://github.com/gpuweb/gpuweb/pull/1447 SPIR-V Reader is still TODO, but continues to function as the offset decoration is still supported. Bug: tint:626 Bug: tint:629 Change-Id: Id574eb3a5c6729559382812de37b23f0c68fd406 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43640 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-03-15 10:43:11 +00:00
"../src/ast/struct_member_align_decoration_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/struct_member_offset_decoration_test.cc",
Implement Default Struct Layout Implements https://github.com/gpuweb/gpuweb/pull/1447 SPIR-V Reader is still TODO, but continues to function as the offset decoration is still supported. Bug: tint:626 Bug: tint:629 Change-Id: Id574eb3a5c6729559382812de37b23f0c68fd406 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43640 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-03-15 10:43:11 +00:00
"../src/ast/struct_member_size_decoration_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/struct_member_test.cc",
"../src/ast/struct_test.cc",
"../src/ast/switch_statement_test.cc",
"../src/ast/test_helper.h",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/texture_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/type_constructor_expression_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/u32_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/uint_literal_test.cc",
"../src/ast/unary_op_expression_test.cc",
"../src/ast/variable_decl_statement_test.cc",
"../src/ast/variable_test.cc",
ast: Add type nodes Copy all of the type classes from src/type into ast. Required the merging of: * type::Struct into the existing ast::Struct - ast::Struct now has a name. * type::AccessControl into the existing ast::AccessControl enumerator - The old ast::AccessControl enumerator is now ast::AccessControl::Access Bug: tint:724 Change-Id: Ibb950036ed551ec769c6d3d2c8fb411809cf6931 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48383 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-20 15:04:21 +00:00
"../src/ast/vector_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/ast/workgroup_decoration_test.cc",
"../src/block_allocator_test.cc",
"../src/castable_test.cc",
"../src/clone_context_test.cc",
"../src/debug_test.cc",
"../src/demangler_test.cc",
"../src/diagnostic/formatter_test.cc",
"../src/diagnostic/printer_test.cc",
"../src/inspector/inspector_test.cc",
"../src/intrinsic_table_test.cc",
"../src/program_builder_test.cc",
"../src/program_test.cc",
Resolver: Check that initializers and assignments are valid This performs very basic type verification for assignments and variable initializers. Pulls part of the validation logic out of the Validator into the Resolver. Involves fixing up a bunch of broken tests. Bug: tint:642 Fixed: tint:631 Change-Id: Ifbdc139ff7eeab810856e0ba9e3c380c6555ec20 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45281 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2021-03-18 21:14:44 +00:00
"../src/resolver/assignment_validation_test.cc",
sem: Add FunctionBlockStatement BlockStatement for the root block of a function Add some basic tests for this lot. Bug: tint:812 Change-Id: I26b65717798cbff576a44bd78fbcb5c8f0d013e6 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51368 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Alastair Donaldson <allydonaldson@googlemail.com>
2021-05-20 15:17:08 +00:00
"../src/resolver/block_test.cc",
Finish moving call validation from Validator to Resolver Call validation was already implemented in Resolver. This change completes it by deleting the relevant code in Validator, and moving and updating the builtins validation test to use the Resolver. Also added the "v-0004" error code for when detecting recursion, as was done for the similar error in the Validator. Bug: tint:642 Bug: tint:487 Change-Id: If7973bfd2d19681a0cbf48c6d427e17a3b927cde Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45463 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-22 17:42:06 +00:00
"../src/resolver/builtins_validation_test.cc",
Move Switch validation from Validator to Resolver * Formerly, we reported the same error message if we detected no default clause or more than one. I made it so that we output a different error message for each. This makes it more clear, and in the case of more than one, the error source location points at the second default clause, rather than at the switch statement. * Add functions to ProgramBuilder to more easily define switch and case statements. * Fix broken tests as a result of this change. Bug: tint:642 Change-Id: Iab4e610a563165862d9bc190772d32a4dd24ac45 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45880 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-03-25 12:55:27 +00:00
"../src/resolver/control_block_validation_test.cc",
Move struct validation from Validator to Resolver * Moved Validator::ValidateConstructedType, which only validated structs, to Resolver as ValidateStructure. * Moved relevant tests to new files, and also updated all failing tests to validate Source location. * Fixed other tests that broke now that we're validating structs. Bug: tint:642 Change-Id: Iefc08ef548f52d8c3798d814d2183c56d1236c2d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45160 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-18 17:59:54 +00:00
"../src/resolver/decoration_validation_test.cc",
[resolver] Add entry point IO validation Checks the following things: - Non-struct entry point parameters must have pipeline IO attributes - Non-struct entry point return type must have a pipeline IO attribute - Structs used as entry point parameters and return values much have pipeline IO attributes on every member - Structs used as entry point parameters and return values cannot have runtime array or nested struct members - Multiple pipeline IO attributes on a parameter, return type, or struct member is not allowed - Any given builtin and location attribute can only appear once for the return type, and across all parameters Removed tests for nested structs from the SPIR-V transform/backend. Fixed a couple of other tests with missing pipeline IO attributes. Fixed: tint:512 Change-Id: I4c48fe24099333c8c7fcd45934c09baa6830883c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46701 Auto-Submit: James Price <jrprice@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-06 15:51:47 +00:00
"../src/resolver/entry_point_validation_test.cc",
Move function validation from Validator to Resolver * Fixed many tests that now failed validation. Most of the time, functions declared that they returned a type, but with no return statement. * ProgramBuilder::WrapInFunction now returns the function is creates, and std::moves its StatementList. * ProgramBuilder: Added Return function to create ast::ReturnStatements more easily. Bug: tint:642 Change-Id: I3011314e66e264ebd7b89bf9271392391be6a0e5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45382 Reviewed-by: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-03-19 14:04:51 +00:00
"../src/resolver/function_validation_test.cc",
s/sharable/shareable Fixed: tint:660 Change-Id: I5b98597acb771f6b07a16a85d85d8ae5249e495d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45283 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-03-18 21:03:24 +00:00
"../src/resolver/host_shareable_validation_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/resolver/intrinsic_test.cc",
s/sharable/shareable Fixed: tint:660 Change-Id: I5b98597acb771f6b07a16a85d85d8ae5249e495d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45283 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-03-18 21:03:24 +00:00
"../src/resolver/is_host_shareable_test.cc",
Implement Default Struct Layout Implements https://github.com/gpuweb/gpuweb/pull/1447 SPIR-V Reader is still TODO, but continues to function as the offset decoration is still supported. Bug: tint:626 Bug: tint:629 Change-Id: Id574eb3a5c6729559382812de37b23f0c68fd406 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43640 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-03-15 10:43:11 +00:00
"../src/resolver/is_storeable_test.cc",
Implement Pointers and References This change implements pointers and references as described by the WGSL specification change in https://github.com/gpuweb/gpuweb/pull/1569. reader/spirv: * Now emits address-of `&expr` and indirection `*expr` operators as needed. * As an identifier may now resolve to a pointer or reference type depending on whether the declaration is a `var`, `let` or parameter, `Function::identifier_values_` has been changed from an ID set to an ID -> Type* map. resolver: * Now correctly resolves all expressions to either a value type, reference type or pointer type. * Validates pointer / reference rules on assignment, `var` and `let` construction, and usage. * Handles the address-of and indirection operators. * No longer does any implicit loads of pointer types. * Storage class validation is still TODO (crbug.com/tint/809) writer/spirv: * Correctly handles variables and expressions of pointer and reference types, emitting OpLoads where necessary. test: * Lots of new test cases Fixed: tint:727 Change-Id: I77d3281590e35e5a3122f5b74cdeb71a6fe51f74 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50740 Commit-Queue: Ben Clayton <bclayton@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-05-18 10:28:48 +00:00
"../src/resolver/ptr_ref_test.cc",
"../src/resolver/ptr_ref_validation_test.cc",
Revert "Add DuplicateStorageStruct transform" This reverts commit 594075a2f0dbffc1966e9396b3eb771d274fa4b5. Reason for revert: This is not a complete solution. It does not cover assignment of variables of the same struct type, but of different access types. For example: ``` [[block]] struct S{ i : 32; }; var<storage> gr : [[access(read)]] S; var<storage> gw : [[access(write)]] S; fn f() { var a : S; a = gr; gw = a; } ``` With my CL, we currently generate invalid assignments because the new types of 'S' for 'gr' and 'gw' are now all different types. We would need to generate functions to assign between them. In the end, we will drop this strategy, and instead, Dawn will be modified to not rely on names. Original change's description: > Add DuplicateStorageStruct transform > > This transform is currently required by Dawn for it's GLSL backend so > that SPIRV-Cross does not end up renaming the structures internally, > which it does to fix aliasing problems. We can remove this transform > if/once Dawn using binding numbers rather than names for uniform/storage > buffer data. > > Bug: tint:386 > Bug: tint:808 > > CloneContext: allow insert before/after of a node marked for removal > Change-Id: I3ff3b37bca62db07d5c759250dd4777e279b7a4f > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51403 > Commit-Queue: Ben Clayton <bclayton@google.com> > Kokoro: Kokoro <noreply+kokoro@google.com> > Reviewed-by: Ben Clayton <bclayton@google.com> TBR=bclayton@google.com,amaiorano@google.com,noreply+kokoro@google.com Change-Id: I695347b0ffe8be23b9dc44885af378be56512406 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: tint:386 Bug: tint:808 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51500 Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-05-19 12:22:59 +00:00
"../src/resolver/pipeline_overridable_constant_test.cc",
Fix gn check in Chromium - Move headers from libtint_sem_src into libtint_core_all_src so that there is no circular header dependency between headers of these two targets. libtint_sem_src is now just a hack to have a different name for a few .cc files. - Made libtint_core_src publicly depend on its deps so that headers of libtint_core_all_src are made visible through it. - Added spvtools dependencies in a couple places that were mistakenly removed in a previous commit. - Moved helpers common to multiple unittest targets out of tint_unittests_core_src and into a tint_test_helpers target that all tint_unittests_source_set depend on. - Ran GN format that reordered some lists a bit. Bug: None Change-Id: I544a73d73366be9dd2ac8e56c7593fd9f2b86cf8 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48600 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 09:18:52 +00:00
"../src/resolver/resolver_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/resolver/resolver_test_helper.cc",
"../src/resolver/resolver_test_helper.h",
Resolver: Validate <storage> var types https://gpuweb.github.io/gpuweb/wgsl/#variable-declaration Variables in the storage storage class and variables with a storage texture type must have an access attribute applied to the store type. https://gpuweb.github.io/gpuweb/wgsl/#module-scope-variables A variable in the storage storage class is a storage buffer variable. Its store type must be a host-shareable structure type with block attribute, satisfying the storage class constraints. Fixup tests, including those that were producing warnings about `var <in>` The WGSL writer seems to want to put a newline after every decoration block, leading to some ugly output. I'll fix this as a separate change. Fixes: tint:531 Fixes: tint:692 Change-Id: If09d987477247ab4a7c635f6ee6e616a06061515 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47763 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2021-04-16 09:26:14 +00:00
"../src/resolver/storage_class_validation_test.cc",
Implement Default Struct Layout Implements https://github.com/gpuweb/gpuweb/pull/1447 SPIR-V Reader is still TODO, but continues to function as the offset decoration is still supported. Bug: tint:626 Bug: tint:629 Change-Id: Id574eb3a5c6729559382812de37b23f0c68fd406 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43640 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-03-15 10:43:11 +00:00
"../src/resolver/struct_layout_test.cc",
[resolver] Track pipeline stage usages for structs This will be used by the generators to determine how to handle location decorations. Change-Id: Ib0e0ce852a5da3819781b402c5625a440c4c9544 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46400 Auto-Submit: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-03-31 15:42:17 +00:00
"../src/resolver/struct_pipeline_stage_use_test.cc",
Resolver: Track storage class usages of structures This will be used to validate layout rules, as well as preventing illegal types from being used in a uniform / storage buffer. Also: Cleanup logic around VariableDeclStatement This was spread across 3 places, entirely unnecessarily. Bug: tint:643 Change-Id: I9d309c3a5dfb5676984f49ce51763a97bcac93bb Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45125 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-03-17 22:47:33 +00:00
"../src/resolver/struct_storage_class_use_test.cc",
Add type inference support to Resolver There is still no way to spell this out in WGSL, but this adds support for VariableDecls with an ast::Variable that has nullptr type. In this case, the Resolver uses the type of the rhs (constructor expression), which is stored in semantic::Variable. Added tests for resolving inferred types from constructor, arithmetic, and call expressions. Bug: tint:672 Change-Id: I3dcfd18adecebc8b969373d2ac72c21891c21a87 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-03-31 12:46:52 +00:00
"../src/resolver/type_constructor_validation_test.cc",
Move struct validation from Validator to Resolver * Moved Validator::ValidateConstructedType, which only validated structs, to Resolver as ValidateStructure. * Moved relevant tests to new files, and also updated all failing tests to validate Source location. * Fixed other tests that broke now that we're validating structs. Bug: tint:642 Change-Id: Iefc08ef548f52d8c3798d814d2183c56d1236c2d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45160 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-18 17:59:54 +00:00
"../src/resolver/type_validation_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/resolver/validation_test.cc",
Implement Pointers and References This change implements pointers and references as described by the WGSL specification change in https://github.com/gpuweb/gpuweb/pull/1569. reader/spirv: * Now emits address-of `&expr` and indirection `*expr` operators as needed. * As an identifier may now resolve to a pointer or reference type depending on whether the declaration is a `var`, `let` or parameter, `Function::identifier_values_` has been changed from an ID set to an ID -> Type* map. resolver: * Now correctly resolves all expressions to either a value type, reference type or pointer type. * Validates pointer / reference rules on assignment, `var` and `let` construction, and usage. * Handles the address-of and indirection operators. * No longer does any implicit loads of pointer types. * Storage class validation is still TODO (crbug.com/tint/809) writer/spirv: * Correctly handles variables and expressions of pointer and reference types, emitting OpLoads where necessary. test: * Lots of new test cases Fixed: tint:727 Change-Id: I77d3281590e35e5a3122f5b74cdeb71a6fe51f74 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50740 Commit-Queue: Ben Clayton <bclayton@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-05-18 10:28:48 +00:00
"../src/resolver/var_let_test.cc",
"../src/resolver/var_let_validation_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/scope_stack_test.cc",
Move type/* files to sem/ directory Bug: tint:724 Change-Id: I45d83d32dbce1fbee265810615c18219ef879b20 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48363 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-19 22:54:43 +00:00
"../src/sem/bool_type_test.cc",
"../src/sem/depth_texture_type_test.cc",
"../src/sem/external_texture_type_test.cc",
"../src/sem/f32_type_test.cc",
"../src/sem/i32_type_test.cc",
"../src/sem/matrix_type_test.cc",
"../src/sem/multisampled_texture_type_test.cc",
"../src/sem/pointer_type_test.cc",
Add sem::Reference Bug: tint:727 Change-Id: I904d33b6c0678f478b4687fcc08589dc3cfd379d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50541 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-05-10 19:45:46 +00:00
"../src/sem/reference_type_test.cc",
Move type/* files to sem/ directory Bug: tint:724 Change-Id: I45d83d32dbce1fbee265810615c18219ef879b20 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48363 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-19 22:54:43 +00:00
"../src/sem/sampled_texture_type_test.cc",
"../src/sem/sampler_type_test.cc",
sem: Fold together sem::Array and sem::ArrayType There's now no need to have both. Removes a whole bunch of Sem().Get() smell, and simplifies the resolver. Also fixes a long-standing issue where an array with an explicit, but equal-to-implicit-stride attribute would result in a different type to an array without the decoration. Bug: tint:724 Fixed: tint:782 Change-Id: I0202459009cd45be427cdb621993a5a3b07ff51e Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50301 Reviewed-by: Antonio Maiorano <amaiorano@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-05-07 20:58:34 +00:00
"../src/sem/sem_array_test.cc",
sem: Fold together sem::Struct and sem::StructType There's now no need to have both. Removes a whole bunch of Sem().Get() smell, and simplifies the resolver. Bug: tint:724 Fixed: tint:761 Change-Id: I756a32680ac52441fd6eebf6fc53dd507ef5e538 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49961 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-05-07 14:49:34 +00:00
"../src/sem/sem_struct_test.cc",
Move type/* files to sem/ directory Bug: tint:724 Change-Id: I45d83d32dbce1fbee265810615c18219ef879b20 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48363 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-19 22:54:43 +00:00
"../src/sem/storage_texture_type_test.cc",
"../src/sem/texture_type_test.cc",
"../src/sem/type_manager_test.cc",
"../src/sem/u32_type_test.cc",
"../src/sem/vector_type_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/symbol_table_test.cc",
"../src/symbol_test.cc",
"../src/traits_test.cc",
Add transform::BindingRemapper A transform to replace binding points and access control flags. Required by Dawn for the HLSL and MSL backends Fixed: tint:104 Fixed: tint:621 Fixed: tint:671 Change-Id: Ic6ccc4a8a7724697cc4af0fad25394a1973eeb22 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46262 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-03-29 21:25:45 +00:00
"../src/transform/binding_remapper_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/transform/bound_array_accessors_test.cc",
Add transform::CalculateArrayLength Used to used to replace calls to arrayLength() with a value calculated from the size of the storage buffer. Bug: tint:185 Change-Id: If7ddc8dad2ed3d20c1d76b5f48bfd2c7634f96e2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46877 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-04-09 10:28:48 +00:00
"../src/transform/calculate_array_length_test.cc",
Add a transform for canonicalizing entry point interfaces After the transform, an entry point's parameters will be aggregated into a single struct, and its return type will either be a struct or void. All structs in the module that have entry point IO decorations will have exactly one pipeline stage usage. This will be used to sanitize entry points for the MSL and HLSL generators. Change-Id: I7d2fcfba961d2e20326086964207747d573b6e05 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46500 Auto-Submit: James Price <jrprice@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-03-31 17:44:27 +00:00
"../src/transform/canonicalize_entry_point_io_test.cc",
Add transform::DecomposeStorageAccess Used to breakdown storage buffer reads and writes into primitive loads and stores. Bug: tint:683 Change-Id: I92983deef7485bc1a6a5d9921ec82f8e19b09744 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46876 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: James Price <jrprice@google.com>
2021-04-09 09:10:38 +00:00
"../src/transform/decompose_storage_access_test.cc",
Add Transform For External Textures Adds a transform to reclassify single-plane texture_external types into 2d sampled textures. Adds a unit test for the transform. Bug: dawn:728 Change-Id: Id1f88565aeacbfea47b140181c78ad122edbdae8 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49641 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-05-05 16:38:12 +00:00
"../src/transform/external_texture_transform_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/transform/first_index_offset_test.cc",
hlsl: Pointer support Add `transform::InlinePointerLets` - a Transform that moves all usage of function-scope `let` statements of a pointer type into their places of usage. Make the HLSL writer transform pointer parameters to `inout`. Fixed: tint:183 Change-Id: I0a7552fa6cd31c7b7691e64feae3170a81cc6c49 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51281 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com>
2021-05-19 19:16:32 +00:00
"../src/transform/inline_pointer_lets_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/transform/renamer_test.cc",
Add transform to strip entry points from a module Remove the Generator::GenerateEntryPoint() APIs as they were mostly unimplemented and not used by anything except the Tint sample app, which now uses the new transform. Change-Id: I1ccb303d6c3aa15e622c193d33b753e22bf39a95 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com>
2021-04-28 15:33:03 +00:00
"../src/transform/single_entry_point_test.cc",
Add Transform::CreateASTTypeFor() Reconstructs the AST nodes needed to build the given semantic type. Bug: tint:724 Change-Id: Iadf97a47b68088a6a1eb1e6871fb3a7248676417 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49745 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2021-05-04 18:13:21 +00:00
"../src/transform/transform_test.cc",
Add transform::VarForDynamicIndex Use this as part of the Spirv sanitizer. Cleans up buggy dynamic array indexing logic in the SPIR-V writer. Fixed: tint:824 Change-Id: Ia408e49bd808bc8dbf3a1897eb47f9b33b71fdfb Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51780 Commit-Queue: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2021-05-20 11:55:28 +00:00
"../src/transform/var_for_dynamic_index_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/transform/vertex_pulling_test.cc",
"../src/utils/command_test.cc",
CloneContext: Don't create named symbols from unnamed Registering a new Symbol with the NameFor() of the source symbol creates a new *named* symbol. When mixing these with unnamed symbols we can have collisions. Update CloneContext::Clone(Symbol) to properly clone unnamed symbols. Update (most) the transforms to ctx.Clone() the symbols instead of registering the names directly. Fix up the tests where the symbol IDs have changed. Note: We can still have symbol collisions if a program is authored with identifiers like 'tint_symbol_3'. This will be fixed up in a later change. Change-Id: I0ce559644da3d60e1060f2eef185fa55ae284521 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46866 Commit-Queue: Ben Clayton <bclayton@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-04-07 11:16:01 +00:00
"../src/utils/get_or_create_test.cc",
Add utils/hash.h Contains hash combining functions borrowed and tweaked from Dawn Change-Id: I0bc9478bcdba0b923d0b01825c275290ffa29976 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46268 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-03-29 15:13:55 +00:00
"../src/utils/hash_test.cc",
Add src/utils/math.h Move the RoundUp() and IsPowerOfTwo() methods from Resolver.cc to this file. Add tests Change-Id: Ib7af53dfa5e69083ec4fc2484da92a84c9468818 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44682 Auto-Submit: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2021-03-15 13:37:41 +00:00
"../src/utils/math_test.cc",
utils: Add TINT_SCOPED_ASSIGNMENT() A helper class and macro used to simplify scope-based assignment of variables. Change-Id: I02b3a05240a2c4628f813de931c40d8fba3cb07b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51480 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-05-19 16:11:04 +00:00
"../src/utils/scoped_assignment_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/utils/tmpfile_test.cc",
"../src/utils/unique_vector_test.cc",
AppendVector() - support pointer args Add tests. Fixed: tint:639 Change-Id: I6718a1fcf5a46aca36209bec037633a862d8e568 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45600 Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-03-22 21:05:47 +00:00
"../src/writer/append_vector_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/writer/float_to_string_test.cc",
]
deps = [
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
":tint_unittests_core_sem_src",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"${tint_root_dir}/src:libtint_wgsl_reader_src",
"${tint_root_dir}/src:libtint_wgsl_writer_src",
]
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
tint_unittests_source_set("tint_unittests_spv_reader_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
"../src/reader/spirv/enum_converter_test.cc",
"../src/reader/spirv/fail_stream_test.cc",
"../src/reader/spirv/function_arithmetic_test.cc",
"../src/reader/spirv/function_bit_test.cc",
"../src/reader/spirv/function_call_test.cc",
"../src/reader/spirv/function_cfg_test.cc",
"../src/reader/spirv/function_composite_test.cc",
"../src/reader/spirv/function_conversion_test.cc",
"../src/reader/spirv/function_decl_test.cc",
"../src/reader/spirv/function_glsl_std_450_test.cc",
"../src/reader/spirv/function_logical_test.cc",
"../src/reader/spirv/function_memory_test.cc",
"../src/reader/spirv/function_misc_test.cc",
"../src/reader/spirv/function_var_test.cc",
"../src/reader/spirv/namer_test.cc",
Implement barrier intrinsics Fixed: tint:658 Change-Id: I28d5225f42dacb2b6b0cb51ce9f15951b31f0fc9 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45284 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Alan Baker <alanbaker@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-03-22 19:27:06 +00:00
"../src/reader/spirv/parser_impl_barrier_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/reader/spirv/parser_impl_convert_member_decoration_test.cc",
"../src/reader/spirv/parser_impl_convert_type_test.cc",
"../src/reader/spirv/parser_impl_function_decl_test.cc",
"../src/reader/spirv/parser_impl_get_decorations_test.cc",
"../src/reader/spirv/parser_impl_handle_test.cc",
"../src/reader/spirv/parser_impl_import_test.cc",
"../src/reader/spirv/parser_impl_module_var_test.cc",
"../src/reader/spirv/parser_impl_named_types_test.cc",
"../src/reader/spirv/parser_impl_test.cc",
Add --dump-spirv option to tint_unittests The --dump-spirv option tells tint_unittests to output the SPIR-V assembly text for a module which did not make the SPIR-V reader fail. This lets us get extract a corpus of SPIR-V modules, and lets us more easily verify that the test shaders are valid in the first place. Also: - Add test/extract-spvasm.py to split that output to separate SPIR-V assembly files - Add optional second argument test/test-all.sh to specify a directory look for input files. - BUILD.gn: Add dependency from //test:tint_unittests_main to //test:tint_unittests_config to pick up source dependency on the internal header of the SPIRV-Tools optimizer, needed by the indirection through src/reader/spirv/parser_impl_test_helper.h This is useful for bulk testing Fixed: tint:756 Change-Id: I4fe232ac736003f7d9be35544328302d652381ea Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49605 Auto-Submit: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-05-05 09:46:31 +00:00
"../src/reader/spirv/parser_impl_test_helper.cc",
"../src/reader/spirv/parser_impl_test_helper.h",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/reader/spirv/parser_impl_user_name_test.cc",
"../src/reader/spirv/parser_test.cc",
Remove sem::AccessControl In preparation for implementing https://github.com/gpuweb/gpuweb/issues/1604, this change removes the sem::AccessControl node. Instead, the ast::AccessControl::Access enum is now on the sem::StorageTexture class, as well as on sem::Variable. For sem::Variable, the field is set when the variable's type is either a storage buffer or a storage texture. Bug: tint:802 Change-Id: Id479af36b401d067b015027923f4e715f5f69f25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51020 Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-05-14 17:51:13 +00:00
"../src/reader/spirv/parser_type_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/reader/spirv/spirv_tools_helpers_test.cc",
"../src/reader/spirv/spirv_tools_helpers_test.h",
"../src/reader/spirv/usage_test.cc",
]
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
deps = [ "${tint_root_dir}/src:libtint_spv_reader_src" ]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
tint_unittests_source_set("tint_unittests_spv_writer_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
"../src/transform/spirv_test.cc",
"../src/writer/spirv/binary_writer_test.cc",
"../src/writer/spirv/builder_accessor_expression_test.cc",
"../src/writer/spirv/builder_assign_test.cc",
"../src/writer/spirv/builder_binary_expression_test.cc",
"../src/writer/spirv/builder_bitcast_expression_test.cc",
"../src/writer/spirv/builder_block_test.cc",
"../src/writer/spirv/builder_call_test.cc",
"../src/writer/spirv/builder_constructor_expression_test.cc",
"../src/writer/spirv/builder_discard_test.cc",
"../src/writer/spirv/builder_entry_point_test.cc",
"../src/writer/spirv/builder_format_conversion_test.cc",
"../src/writer/spirv/builder_function_decoration_test.cc",
"../src/writer/spirv/builder_function_test.cc",
"../src/writer/spirv/builder_function_variable_test.cc",
"../src/writer/spirv/builder_global_variable_test.cc",
"../src/writer/spirv/builder_ident_expression_test.cc",
"../src/writer/spirv/builder_if_test.cc",
"../src/writer/spirv/builder_intrinsic_test.cc",
"../src/writer/spirv/builder_intrinsic_texture_test.cc",
"../src/writer/spirv/builder_literal_test.cc",
"../src/writer/spirv/builder_loop_test.cc",
"../src/writer/spirv/builder_return_test.cc",
"../src/writer/spirv/builder_switch_test.cc",
"../src/writer/spirv/builder_test.cc",
"../src/writer/spirv/builder_type_test.cc",
"../src/writer/spirv/builder_unary_op_expression_test.cc",
"../src/writer/spirv/instruction_test.cc",
"../src/writer/spirv/operand_test.cc",
writer/spirv: Clean up constant generation Requiring a temporary stack-allocated ast::Literal is an unpleasant requirement to generate a SPIR-V constant value. GenerateU32Literal() was also creating an invalid AST - the type was U32, yet an an ast::SintLiteral was used. Instead add Constant for holding a constant value, and use this as the map key. This also removes the last remaining use of ast::NullLiteral, which will be removed in the next change. Change-Id: Ia85732784075f153503dbef101ba95018eaa4bf5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45342 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-03-22 15:32:35 +00:00
"../src/writer/spirv/scalar_constant_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/writer/spirv/spv_dump.cc",
"../src/writer/spirv/spv_dump.h",
"../src/writer/spirv/test_helper.h",
]
Fix gn check in Chromium - Move headers from libtint_sem_src into libtint_core_all_src so that there is no circular header dependency between headers of these two targets. libtint_sem_src is now just a hack to have a different name for a few .cc files. - Made libtint_core_src publicly depend on its deps so that headers of libtint_core_all_src are made visible through it. - Added spvtools dependencies in a couple places that were mistakenly removed in a previous commit. - Moved helpers common to multiple unittest targets out of tint_unittests_core_src and into a tint_test_helpers target that all tint_unittests_source_set depend on. - Ran GN format that reordered some lists a bit. Bug: None Change-Id: I544a73d73366be9dd2ac8e56c7593fd9f2b86cf8 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48600 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-04-21 09:18:52 +00:00
deps = [
"${tint_root_dir}/src:libtint_spv_writer_src",
"${tint_spirv_tools_dir}/:spvtools",
]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
tint_unittests_source_set("tint_unittests_wgsl_reader_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
"../src/reader/wgsl/lexer_test.cc",
"../src/reader/wgsl/parser_impl_additive_expression_test.cc",
"../src/reader/wgsl/parser_impl_and_expression_test.cc",
"../src/reader/wgsl/parser_impl_argument_expression_list_test.cc",
"../src/reader/wgsl/parser_impl_assignment_stmt_test.cc",
"../src/reader/wgsl/parser_impl_body_stmt_test.cc",
"../src/reader/wgsl/parser_impl_break_stmt_test.cc",
"../src/reader/wgsl/parser_impl_bug_cases_test.cc",
"../src/reader/wgsl/parser_impl_call_stmt_test.cc",
"../src/reader/wgsl/parser_impl_case_body_test.cc",
"../src/reader/wgsl/parser_impl_const_expr_test.cc",
"../src/reader/wgsl/parser_impl_const_literal_test.cc",
"../src/reader/wgsl/parser_impl_continue_stmt_test.cc",
"../src/reader/wgsl/parser_impl_continuing_stmt_test.cc",
"../src/reader/wgsl/parser_impl_depth_texture_type_test.cc",
"../src/reader/wgsl/parser_impl_else_stmt_test.cc",
"../src/reader/wgsl/parser_impl_elseif_stmt_test.cc",
"../src/reader/wgsl/parser_impl_equality_expression_test.cc",
"../src/reader/wgsl/parser_impl_error_msg_test.cc",
"../src/reader/wgsl/parser_impl_error_resync_test.cc",
"../src/reader/wgsl/parser_impl_exclusive_or_expression_test.cc",
Add texture_external parsing and intrinsic overloads Adds texture_external to ParserImpl. Adds texture_external overloads to TextureSample, TextureLoad, and TextureDimensions to the intrisic table. Adds corresponding tests. Bug: dawn:728 Change-Id: I5e5557a10327f8c3d3044319decd748f812ecf3e Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48722 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
2021-04-22 22:47:03 +00:00
"../src/reader/wgsl/parser_impl_external_texture_type_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/reader/wgsl/parser_impl_for_stmt_test.cc",
"../src/reader/wgsl/parser_impl_function_decl_test.cc",
"../src/reader/wgsl/parser_impl_function_decoration_list_test.cc",
"../src/reader/wgsl/parser_impl_function_decoration_test.cc",
"../src/reader/wgsl/parser_impl_function_header_test.cc",
"../src/reader/wgsl/parser_impl_function_type_decl_test.cc",
"../src/reader/wgsl/parser_impl_global_constant_decl_test.cc",
"../src/reader/wgsl/parser_impl_global_decl_test.cc",
"../src/reader/wgsl/parser_impl_global_variable_decl_test.cc",
"../src/reader/wgsl/parser_impl_if_stmt_test.cc",
"../src/reader/wgsl/parser_impl_image_storage_type_test.cc",
"../src/reader/wgsl/parser_impl_inclusive_or_expression_test.cc",
"../src/reader/wgsl/parser_impl_logical_and_expression_test.cc",
"../src/reader/wgsl/parser_impl_logical_or_expression_test.cc",
"../src/reader/wgsl/parser_impl_loop_stmt_test.cc",
"../src/reader/wgsl/parser_impl_multiplicative_expression_test.cc",
"../src/reader/wgsl/parser_impl_param_list_test.cc",
"../src/reader/wgsl/parser_impl_paren_rhs_stmt_test.cc",
"../src/reader/wgsl/parser_impl_pipeline_stage_test.cc",
"../src/reader/wgsl/parser_impl_primary_expression_test.cc",
"../src/reader/wgsl/parser_impl_relational_expression_test.cc",
"../src/reader/wgsl/parser_impl_sampled_texture_type_test.cc",
"../src/reader/wgsl/parser_impl_sampler_type_test.cc",
"../src/reader/wgsl/parser_impl_shift_expression_test.cc",
reader/wgsl: match spec rules for function calls Function calls should be parsed in `primary_expression`. Renames the old `postfix_expression` to `singular_expression`, with the recursive part now becoming `postfix_expression`. Fixed: tint:170 Change-Id: I1afad794880916db38a25d73447cdaf84abd6584 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49464 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: James Price <jrprice@google.com>
2021-04-29 15:02:15 +00:00
"../src/reader/wgsl/parser_impl_singular_expression_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/reader/wgsl/parser_impl_statement_test.cc",
"../src/reader/wgsl/parser_impl_statements_test.cc",
"../src/reader/wgsl/parser_impl_storage_class_test.cc",
"../src/reader/wgsl/parser_impl_storage_texture_type_test.cc",
"../src/reader/wgsl/parser_impl_struct_body_decl_test.cc",
"../src/reader/wgsl/parser_impl_struct_decl_test.cc",
"../src/reader/wgsl/parser_impl_struct_decoration_decl_test.cc",
"../src/reader/wgsl/parser_impl_struct_decoration_test.cc",
"../src/reader/wgsl/parser_impl_struct_member_decoration_decl_test.cc",
"../src/reader/wgsl/parser_impl_struct_member_decoration_test.cc",
"../src/reader/wgsl/parser_impl_struct_member_test.cc",
"../src/reader/wgsl/parser_impl_switch_body_test.cc",
"../src/reader/wgsl/parser_impl_switch_stmt_test.cc",
"../src/reader/wgsl/parser_impl_test.cc",
"../src/reader/wgsl/parser_impl_test_helper.cc",
"../src/reader/wgsl/parser_impl_test_helper.h",
"../src/reader/wgsl/parser_impl_texture_sampler_types_test.cc",
"../src/reader/wgsl/parser_impl_type_alias_test.cc",
"../src/reader/wgsl/parser_impl_type_decl_test.cc",
"../src/reader/wgsl/parser_impl_unary_expression_test.cc",
"../src/reader/wgsl/parser_impl_variable_decl_test.cc",
"../src/reader/wgsl/parser_impl_variable_decoration_list_test.cc",
"../src/reader/wgsl/parser_impl_variable_decoration_test.cc",
"../src/reader/wgsl/parser_impl_variable_ident_decl_test.cc",
"../src/reader/wgsl/parser_impl_variable_stmt_test.cc",
"../src/reader/wgsl/parser_impl_variable_storage_decoration_test.cc",
"../src/reader/wgsl/parser_test.cc",
"../src/reader/wgsl/token_test.cc",
]
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
deps = [ "${tint_root_dir}/src:libtint_wgsl_reader_src" ]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
tint_unittests_source_set("tint_unittests_wgsl_writer_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
"../src/writer/wgsl/generator_impl_alias_type_test.cc",
"../src/writer/wgsl/generator_impl_array_accessor_test.cc",
"../src/writer/wgsl/generator_impl_assign_test.cc",
"../src/writer/wgsl/generator_impl_binary_test.cc",
"../src/writer/wgsl/generator_impl_bitcast_test.cc",
"../src/writer/wgsl/generator_impl_block_test.cc",
"../src/writer/wgsl/generator_impl_break_test.cc",
"../src/writer/wgsl/generator_impl_call_test.cc",
"../src/writer/wgsl/generator_impl_case_test.cc",
"../src/writer/wgsl/generator_impl_cast_test.cc",
"../src/writer/wgsl/generator_impl_constructor_test.cc",
"../src/writer/wgsl/generator_impl_continue_test.cc",
"../src/writer/wgsl/generator_impl_discard_test.cc",
"../src/writer/wgsl/generator_impl_fallthrough_test.cc",
"../src/writer/wgsl/generator_impl_function_test.cc",
"../src/writer/wgsl/generator_impl_global_decl_test.cc",
"../src/writer/wgsl/generator_impl_identifier_test.cc",
"../src/writer/wgsl/generator_impl_if_test.cc",
"../src/writer/wgsl/generator_impl_loop_test.cc",
"../src/writer/wgsl/generator_impl_member_accessor_test.cc",
"../src/writer/wgsl/generator_impl_return_test.cc",
"../src/writer/wgsl/generator_impl_switch_test.cc",
"../src/writer/wgsl/generator_impl_test.cc",
"../src/writer/wgsl/generator_impl_type_test.cc",
"../src/writer/wgsl/generator_impl_unary_op_test.cc",
"../src/writer/wgsl/generator_impl_variable_decl_statement_test.cc",
"../src/writer/wgsl/generator_impl_variable_test.cc",
"../src/writer/wgsl/test_helper.h",
]
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
deps = [ "${tint_root_dir}/src:libtint_wgsl_writer_src" ]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
tint_unittests_source_set("tint_unittests_msl_writer_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
"../src/transform/msl_test.cc",
"../src/writer/msl/generator_impl_array_accessor_test.cc",
"../src/writer/msl/generator_impl_assign_test.cc",
"../src/writer/msl/generator_impl_binary_test.cc",
"../src/writer/msl/generator_impl_bitcast_test.cc",
"../src/writer/msl/generator_impl_block_test.cc",
"../src/writer/msl/generator_impl_break_test.cc",
"../src/writer/msl/generator_impl_call_test.cc",
"../src/writer/msl/generator_impl_case_test.cc",
"../src/writer/msl/generator_impl_cast_test.cc",
"../src/writer/msl/generator_impl_constructor_test.cc",
"../src/writer/msl/generator_impl_continue_test.cc",
"../src/writer/msl/generator_impl_discard_test.cc",
"../src/writer/msl/generator_impl_function_entry_point_data_test.cc",
"../src/writer/msl/generator_impl_function_test.cc",
"../src/writer/msl/generator_impl_identifier_test.cc",
"../src/writer/msl/generator_impl_if_test.cc",
"../src/writer/msl/generator_impl_import_test.cc",
"../src/writer/msl/generator_impl_intrinsic_test.cc",
"../src/writer/msl/generator_impl_intrinsic_texture_test.cc",
"../src/writer/msl/generator_impl_loop_test.cc",
"../src/writer/msl/generator_impl_member_accessor_test.cc",
"../src/writer/msl/generator_impl_module_constant_test.cc",
"../src/writer/msl/generator_impl_return_test.cc",
"../src/writer/msl/generator_impl_switch_test.cc",
"../src/writer/msl/generator_impl_test.cc",
"../src/writer/msl/generator_impl_type_test.cc",
"../src/writer/msl/generator_impl_unary_op_test.cc",
"../src/writer/msl/generator_impl_variable_decl_statement_test.cc",
[msl-writer] Support MSL compiler validation in unit tests The MSL writer GTest harness (TestHelper) now provides a function to invoke the XCode SDK Metal compiler for the MSL output of a given tint::Program. The tint_unittests binary now provides the `--validate-msl` and `--xcrun-path` command-line flags to optionally enable MSL validation and to configure its path. The MSL validation logic itself is conditionally compiled based on the TINT_BUILD_MSL_WRITER define. The TINT_BUILD_* flags were previously not propagated to the GTest binary which this CL addresses by linking the common/public tint configs when building the tint_unittests_main target. Bug: tint:535 Fixed: tint:696 Change-Id: I08b1c36ba59c606ef6cffa5fa5454fd8cf8b035d Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45800 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Arman Uguray <armansito@chromium.org>
2021-04-14 15:36:58 +00:00
"../src/writer/msl/test_helper.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/writer/msl/test_helper.h",
]
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
deps = [ "${tint_root_dir}/src:libtint_msl_writer_src" ]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
tint_unittests_source_set("tint_unittests_hlsl_writer_src") {
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
sources = [
"../src/transform/hlsl_test.cc",
"../src/writer/hlsl/generator_impl_array_accessor_test.cc",
"../src/writer/hlsl/generator_impl_assign_test.cc",
"../src/writer/hlsl/generator_impl_binary_test.cc",
"../src/writer/hlsl/generator_impl_bitcast_test.cc",
"../src/writer/hlsl/generator_impl_block_test.cc",
"../src/writer/hlsl/generator_impl_break_test.cc",
"../src/writer/hlsl/generator_impl_call_test.cc",
"../src/writer/hlsl/generator_impl_case_test.cc",
"../src/writer/hlsl/generator_impl_cast_test.cc",
"../src/writer/hlsl/generator_impl_constructor_test.cc",
"../src/writer/hlsl/generator_impl_continue_test.cc",
"../src/writer/hlsl/generator_impl_discard_test.cc",
"../src/writer/hlsl/generator_impl_function_entry_point_data_test.cc",
"../src/writer/hlsl/generator_impl_function_test.cc",
"../src/writer/hlsl/generator_impl_identifier_test.cc",
"../src/writer/hlsl/generator_impl_if_test.cc",
"../src/writer/hlsl/generator_impl_import_test.cc",
"../src/writer/hlsl/generator_impl_intrinsic_test.cc",
"../src/writer/hlsl/generator_impl_intrinsic_texture_test.cc",
"../src/writer/hlsl/generator_impl_loop_test.cc",
"../src/writer/hlsl/generator_impl_member_accessor_test.cc",
"../src/writer/hlsl/generator_impl_module_constant_test.cc",
"../src/writer/hlsl/generator_impl_return_test.cc",
"../src/writer/hlsl/generator_impl_sanitizer_test.cc",
"../src/writer/hlsl/generator_impl_switch_test.cc",
"../src/writer/hlsl/generator_impl_test.cc",
"../src/writer/hlsl/generator_impl_type_test.cc",
"../src/writer/hlsl/generator_impl_unary_op_test.cc",
"../src/writer/hlsl/generator_impl_variable_decl_statement_test.cc",
writer/hlsl: Emit workgroup variables Fixed: tint:688 Change-Id: I3f0f3fd24734421f8d36a94c501aed9881ec10b0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/46379 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-03-30 20:55:08 +00:00
"../src/writer/hlsl/generator_impl_workgroup_var_test.cc",
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
"../src/writer/hlsl/test_helper.cc",
"../src/writer/hlsl/test_helper.h",
]
Rename sem_*.cc to *.cc This makes the .cc files match the header file name, which allows for the text editor "header flip" feature to actually work. The reason these files were named this way was because GN doesn't allow name conflicts in the same source set, despite the files being in different directories. This change splits the files into different source sets. To do so, we use GN templates, which also reduces duplication in each target definition. Bug: tint:724 Change-Id: I9a7ed3912e4b85b2b38d360805203f3488b86c4c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48160 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 15:20:03 +00:00
deps = [ "${tint_root_dir}/src:libtint_hlsl_writer_src" ]
Split BUILD.gn into per-subdirectory BUILD.gns This will allow Tint's dependent to depend on libtint without GN discovering Tint's test and try to build them. In particular it will help use Tint in Dawn in Skia's standalone build which doesn't have //testing. Bug: dawn:706 Change-Id: Idd28662b89aa75df7704eaae205328dce0b96fef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44540 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-03-15 08:43:11 +00:00
}
source_set("tint_unittests_src") {
testonly = true
deps = [ ":tint_unittests_core_src" ]
if (tint_build_spv_reader) {
deps += [ ":tint_unittests_spv_reader_src" ]
}
if (tint_build_spv_writer) {
deps += [ ":tint_unittests_spv_writer_src" ]
}
if (tint_build_wgsl_reader) {
deps += [ ":tint_unittests_wgsl_reader_src" ]
}
if (tint_build_wgsl_writer) {
deps += [ ":tint_unittests_wgsl_writer_src" ]
}
if (tint_build_msl_writer) {
deps += [ ":tint_unittests_msl_writer_src" ]
}
if (tint_build_hlsl_writer) {
deps += [ ":tint_unittests_hlsl_writer_src" ]
}
configs += [ ":tint_unittests_config" ]
if (build_with_chromium) {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
}
}
test("tint_unittests") {
deps = [
":gmock_and_gtest",
":tint_unittests_src",
"${tint_spirv_tools_dir}/:spvtools",
"${tint_spirv_tools_dir}/:spvtools_opt",
"${tint_spirv_tools_dir}/:spvtools_val",
]
deps += [ ":tint_unittests_main" ]
configs += [ ":tint_unittests_config" ]
if (build_with_chromium) {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
}
testonly = true
}