encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove redundant virtual. 

This CL removes a redundant virtual and enables the
readability/inheritance lint in src/dawn

Bug: dawn:1339
Change-Id: I3dcc84894b8d308461219a5ea206ca31300de297
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86504
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
dan sinclair 2022-04-13 08:53:36 +00:00 committed by Dawn LUCI CQ
parent ca11c03824
commit 031e529714
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/dawn/CPPLINT.cfg
View File

@ -2,7 +2,6 @@ filter=-build/include_order
filter=-build/include_what_you_use filter=-build/include_what_you_use
filter=-build/namespaces filter=-build/namespaces
filter=-readability/casting filter=-readability/casting
filter=-readability/inheritance
filter=-readability/namespace filter=-readability/namespace
filter=-runtime/explicit filter=-runtime/explicit
filter=-runtime/indentation_namespace filter=-runtime/indentation_namespace

2
src/dawn/native/d3d12/BufferD3D12.h
View File

@ -62,7 +62,7 @@ namespace dawn::native::d3d12 {
void UnmapImpl() override; void UnmapImpl() override;
void DestroyImpl() override; void DestroyImpl() override;
bool IsCPUWritableAtCreation() const override; bool IsCPUWritableAtCreation() const override;
virtual MaybeError MapAtCreationImpl() override; MaybeError MapAtCreationImpl() override;
void* GetMappedPointerImpl() override; void* GetMappedPointerImpl() override;
MaybeError MapInternal(bool isWrite, size_t start, size_t end, const char* contextInfo); MaybeError MapInternal(bool isWrite, size_t start, size_t end, const char* contextInfo);