encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable more `gn check` results. 

This PR fixes one gn include issue and widens the GN check results
to test all but one of the GN targets. The remaining target is
disabled due to our absl configuration.

Bug: dawn:1372
Change-Id: I6e92a7aa777c3508e57d1e7138c73b7a92756db1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88680
Reviewed-by: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-05-04 17:44:19 +00:00 committed by Dawn LUCI CQ
parent ccd9fc055f
commit 085fcea6b7
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.gn
View File

@ -34,10 +34,7 @@ default_args = {
vma_vulkan_headers_dir = "//third_party/vulkan-deps/vulkan-headers/src" vma_vulkan_headers_dir = "//third_party/vulkan-deps/vulkan-headers/src"
} }
check_targets = [ no_check_targets = [
# Everything in BUILD.gn # TODO(crbug.com/dawn/1404): Issue with the Absl headers
"//:*", "//src/dawn/tests:dawn_unittests",
# Everything in third_party/BUILD.gn
"//third_party/:*",
] ]

1
src/dawn/samples/BUILD.gn
View File

@ -34,6 +34,7 @@ static_library("utils") {
# Export all of these as public deps so that `gn check` allows includes # Export all of these as public deps so that `gn check` allows includes
public_deps = [ public_deps = [
"${dawn_root}/src/dawn:cpp", "${dawn_root}/src/dawn:cpp",
"${dawn_root}/src/dawn:proc_shared",
"${dawn_root}/src/dawn/common", "${dawn_root}/src/dawn/common",
"${dawn_root}/src/dawn/native", "${dawn_root}/src/dawn/native",
"${dawn_root}/src/dawn/utils", "${dawn_root}/src/dawn/utils",