encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reenable D3D12 texture tests with tint generator 

Issues now resolved

Fixed: tint:684
Fixed: tint:689
Fixed: tint:690
Fixed: tint:691
Change-Id: Ib348ed52a17538a023fdd3c8f2cd0c2d847a09ad
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/47427
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ben Clayton 2021-04-12 18:41:54 +00:00 committed by Commit Bot service account
parent 3e2476967d
commit 10ec9a706f
4 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/end2end/DepthStencilSamplingTests.cpp
View File

@ -57,9 +57,6 @@ class DepthStencilSamplingTest : public DawnTest {
void SetUp() override { void SetUp() override {
DawnTest::SetUp(); DawnTest::SetUp();
// TODO(crbug.com/tint/684): Shaders compile, tests fail.
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
wgpu::BufferDescriptor uniformBufferDesc; wgpu::BufferDescriptor uniformBufferDesc;
uniformBufferDesc.usage = wgpu::BufferUsage::Uniform | wgpu::BufferUsage::CopyDst; uniformBufferDesc.usage = wgpu::BufferUsage::Uniform | wgpu::BufferUsage::CopyDst;
uniformBufferDesc.size = sizeof(float); uniformBufferDesc.size = sizeof(float);

2
src/tests/end2end/SamplerFilterAnisotropicTests.cpp
View File

@ -268,8 +268,6 @@ class SamplerFilterAnisotropicTest : public DawnTest {
}; };
TEST_P(SamplerFilterAnisotropicTest, SlantedPlaneMipmap) { TEST_P(SamplerFilterAnisotropicTest, SlantedPlaneMipmap) {
// TODO(crbug.com/tint/691): shader compiles, but output is unexpected
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// TODO(crbug.com/dawn/740): Test output is wrong with D3D12 + WARP. // TODO(crbug.com/dawn/740): Test output is wrong with D3D12 + WARP.
DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP()); DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP());

3
src/tests/end2end/StorageTextureTests.cpp
View File

@ -1049,9 +1049,6 @@ TEST_P(StorageTextureTests, ReadonlyAndWriteonlyStorageTexturePingPong) {
// Test that multiple dispatches to increment values by ping-ponging between a sampled texture and // Test that multiple dispatches to increment values by ping-ponging between a sampled texture and
// a write-only storage texture are synchronized in one pass. // a write-only storage texture are synchronized in one pass.
TEST_P(StorageTextureTests, SampledAndWriteonlyStorageTexturePingPong) { TEST_P(StorageTextureTests, SampledAndWriteonlyStorageTexturePingPong) {
// TODO(crbug.com/tint/690): shaders compile, but output is unexpected
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
constexpr wgpu::TextureFormat kTextureFormat = wgpu::TextureFormat::R32Uint; constexpr wgpu::TextureFormat kTextureFormat = wgpu::TextureFormat::R32Uint;
wgpu::Texture storageTexture1 = CreateTexture( wgpu::Texture storageTexture1 = CreateTexture(
kTextureFormat, kTextureFormat,

7
src/tests/end2end/TextureFormatTests.cpp
View File

@ -113,13 +113,6 @@ class ExpectFloat16 : public detail::Expectation {
class TextureFormatTest : public DawnTest { class TextureFormatTest : public DawnTest {
protected: protected:
void SetUp() {
DawnTest::SetUp();
// TODO(crbug.com/tint/689): shaders compile, but produces unexpected output.
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
}
// Structure containing all the information that tests need to know about the format. // Structure containing all the information that tests need to know about the format.
struct FormatTestInfo { struct FormatTestInfo {
wgpu::TextureFormat format; wgpu::TextureFormat format;