encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable some whitebox tests if implicit device sync is enabled. 

Whitebox tests call internal functions directly. However, when
implicit device synchronization feature is turned on, some of these
functions will expect that the device is already locked. Thus leading
to assertion failures.

So we need to disable the tests when this feature is turned on.

Bug: dawn:1662
Change-Id: I1d65b4779c933313b5835f1bddbc57703b3ced53
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/127180
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
This commit is contained in:
Le Hoang Quyen 2023-04-25 09:08:34 +00:00 committed by Dawn LUCI CQ
parent c1b3c74316
commit 20e3e34ce7
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn/tests/white_box/QueryInternalShaderTests.cpp
View File

@ -89,6 +89,12 @@ class QueryInternalShaderTests : public DawnTest {
DAWN_TEST_UNSUPPORTED_IF(UsesWire());
DAWN_TEST_UNSUPPORTED_IF(HasToggleEnabled("disable_timestamp_query_conversion"));
// If implicit device synchronization is turned on, EncodeConvertTimestampsToNanoseconds
// will expect the device to be locked. But we are calling it directly without going through
// wgpu API, hence the device won't be locked on this route. This would lead to assertion
// failure. So disable the test if this feature is turned on.
DAWN_TEST_UNSUPPORTED_IF(IsImplicitDeviceSyncEnabled());
}
// Original timestamp values in query set for testing