encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suppress BufferSetSubDataTests.ManySetSubData on Mac Intel 

This test started failing on the macOS 10.14 builders as soon as it was
re-enabled. Suppress them while we investigate.

TBR=kainino@chromium.org
BUG=dawn:108

Change-Id: I7470a751d74c97558128cbbc90574b3d05629a3e
Reviewed-on: https://dawn-review.googlesource.com/c/4821
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2019-02-18 09:37:53 +00:00 committed by Commit Bot service account
parent 81da14f45c
commit 2f321dd4ab
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/end2end/BufferTests.cpp
View File

@ -180,6 +180,10 @@ TEST_P(BufferSetSubDataTests, SmallDataAtOffset) {
// Stress test for many calls to SetSubData // Stress test for many calls to SetSubData
TEST_P(BufferSetSubDataTests, ManySetSubData) { TEST_P(BufferSetSubDataTests, ManySetSubData) {
// Test failing on Mac Metal Intel, maybe because Metal runs out of space to encode commands.
// See https://bugs.chromium.org/p/dawn/issues/detail?id=108
DAWN_SKIP_TEST_IF(IsMacOS() && IsMetal() && IsIntel());
// Note: Increasing the size of the buffer will likely cause timeout issues. // Note: Increasing the size of the buffer will likely cause timeout issues.
// In D3D12, timeout detection occurs when the GPU scheduler tries but cannot preempt the task // In D3D12, timeout detection occurs when the GPU scheduler tries but cannot preempt the task
// executing these commands in-flight. If this takes longer than ~2s, a device reset occurs and // executing these commands in-flight. If this takes longer than ~2s, a device reset occurs and