Add more information on renderBundle<->pass attachment state mismatch
Bug: dawn:563 Change-Id: I8f68f27bf0f4864018ec8c58eae6754671031db8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85761 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org>
This commit is contained in:
parent
3a279a84e7
commit
40b4ece211
|
@ -237,8 +237,6 @@ namespace dawn::native {
|
|||
if (IsValidationEnabled()) {
|
||||
DAWN_TRY(GetDevice()->ValidateObject(pipeline));
|
||||
|
||||
// TODO(dawn:563): More detail about why the states are incompatible would be
|
||||
// nice.
|
||||
DAWN_INVALID_IF(pipeline->GetAttachmentState() != mAttachmentState.Get(),
|
||||
"Attachment state of %s is not compatible with %s.\n"
|
||||
"%s expects an attachment state of %s.\n"
|
||||
|
|
|
@ -281,12 +281,13 @@ namespace dawn::native {
|
|||
for (uint32_t i = 0; i < count; ++i) {
|
||||
DAWN_TRY(GetDevice()->ValidateObject(renderBundles[i]));
|
||||
|
||||
// TODO(dawn:563): Give more detail about why the states are incompatible.
|
||||
DAWN_INVALID_IF(
|
||||
attachmentState != renderBundles[i]->GetAttachmentState(),
|
||||
"Attachment state of renderBundles[%i] (%s) is not compatible with "
|
||||
"attachment state of %s.",
|
||||
i, renderBundles[i], this);
|
||||
DAWN_INVALID_IF(attachmentState != renderBundles[i]->GetAttachmentState(),
|
||||
"Attachment state of renderBundles[%i] (%s) is not "
|
||||
"compatible with %s.\n"
|
||||
"%s expects an attachment state of %s.\n"
|
||||
"renderBundles[%i] (%s) has an attachment state of %s.",
|
||||
i, renderBundles[i], this, this, attachmentState, i,
|
||||
renderBundles[i], renderBundles[i]->GetAttachmentState());
|
||||
|
||||
bool depthReadOnlyInBundle = renderBundles[i]->IsDepthReadOnly();
|
||||
DAWN_INVALID_IF(
|
||||
|
|
Loading…
Reference in New Issue