Fix CMake build, fix doxygen warning

inspector_test.cc: Remove unused method
test_helper.h: Fix comment type on member

Change-Id: I53b1392fa1fa8154efdcd471d1df1bbf27e04dc9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41728
Commit-Queue: Ben Clayton <bclayton@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Ben Clayton 2021-02-16 20:56:21 +00:00 committed by Commit Bot service account
parent f97b9c9310
commit 45b18ce064
2 changed files with 1 additions and 16 deletions

View File

@ -631,21 +631,6 @@ class InspectorHelper : public ProgramBuilder {
return {texture_type, subtype, access_control}; return {texture_type, subtype, access_control};
} }
/// Generates appropriate types for a Write-Only StorageTexture
/// @param dim the texture dimension of the storage texture
/// @param format the image format of the storage texture
/// @returns the storage texture type, subtype & access control type
std::tuple<type::StorageTexture*, type::Type*, type::AccessControl*>
MakeWriteOnlyStorageTextureTypes(type::TextureDimension dim,
type::ImageFormat format) {
type::StorageTexture* texture_type;
type::Type* subtype;
std::tie(texture_type, subtype) = MakeStorageTextureTypes(dim, format);
auto* access_control = create<type::AccessControl>(
ast::AccessControl::kWriteOnly, texture_type);
return {texture_type, subtype, access_control};
}
/// Adds a storage texture variable to the program /// Adds a storage texture variable to the program
/// @param name the name of the variable /// @param name the name of the variable
/// @param type the type to use /// @param type the type to use

View File

@ -50,7 +50,7 @@ class TestHelperBase : public BASE, public ProgramBuilder {
/// The type determiner /// The type determiner
TypeDeterminer td; TypeDeterminer td;
// The program built with a call to Build() /// The program built with a call to Build()
std::unique_ptr<Program> program; std::unique_ptr<Program> program;
private: private: