encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-08-09 05:29:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove suppression for BindGroupTests.MultipleBindLayouts on Metal

Browse Source 
The padded matrix issue in MSL has been fixed in SPIRV-Cross, and
it's updated in https://dawn-review.googlesource.com/c/dawn/+/13421,
so we can add BindGroupTests.MultipleBindLayouts back.

Bug: dawn:33
Change-Id: I8847ab536ebfd779219a1c6d0e1a9a128adf7e85
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13560
Commit-Queue: Hao Li <hao.x.li@intel.com>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Li, Hao 2020-01-10 14:55:18 +00:00 committed by Commit Bot service account
parent f12c9dba6d
commit 4950095ac9
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/end2end/BindGroupTests.cpp
View File

@ -332,10 +332,6 @@ TEST_P(BindGroupTests, UBOSamplerAndTexture) {
} }
TEST_P(BindGroupTests, MultipleBindLayouts) { TEST_P(BindGroupTests, MultipleBindLayouts) {
// Test fails on Metal.
// https://bugs.chromium.org/p/dawn/issues/detail?id=33
DAWN_SKIP_TEST_IF(IsMetal());
utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize); utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize);
wgpu::ShaderModule vsModule = wgpu::ShaderModule vsModule =