encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove redundant override in include/dawn. 

This CL removes two redundant override annotations in the include/dawn
folder. The override is redundant due to the final attribute.

This fixes readability/inheritance in include/dawn.

Bug: dawn:1339
Change-Id: I8d58d099ec36f379b2f0beb55007aafc64dab7c1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86445
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-04-12 17:53:11 +00:00 committed by Dawn LUCI CQ
parent 265761220b
commit 51bab8067a
3 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/dawn/CPPLINT.cfg
View File

@ -1,2 +1 @@
filter=-readability/inheritance
filter=-runtime/indentation_namespace filter=-runtime/indentation_namespace

3
include/dawn/wire/WireClient.h
View File

@ -68,8 +68,7 @@ namespace dawn::wire {
explicit WireClient(const WireClientDescriptor& descriptor); explicit WireClient(const WireClientDescriptor& descriptor);
~WireClient() override; ~WireClient() override;
const volatile char* HandleCommands(const volatile char* commands, const volatile char* HandleCommands(const volatile char* commands, size_t size) final;
size_t size) override final;
ReservedTexture ReserveTexture(WGPUDevice device); ReservedTexture ReserveTexture(WGPUDevice device);
ReservedSwapChain ReserveSwapChain(WGPUDevice device); ReservedSwapChain ReserveSwapChain(WGPUDevice device);

3
include/dawn/wire/WireServer.h
View File

@ -39,8 +39,7 @@ namespace dawn::wire {
explicit WireServer(const WireServerDescriptor& descriptor); explicit WireServer(const WireServerDescriptor& descriptor);
~WireServer() override; ~WireServer() override;
const volatile char* HandleCommands(const volatile char* commands, const volatile char* HandleCommands(const volatile char* commands, size_t size) final;
size_t size) override final;
bool InjectTexture(WGPUTexture texture, bool InjectTexture(WGPUTexture texture,
uint32_t id, uint32_t id,