encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't use incremental build in webgpu-cts/scripts/list.py 

The incremental build can become stale for unknown reasons,
breaking presubmits. Disable it for now.

Bug: dawn:1395
Change-Id: I83a71da0006ee3184b8df2996d8e53b6efbcc20a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89640
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Austin Eng 2022-05-10 18:17:54 +00:00 committed by Dawn LUCI CQ
parent 0a3cda9911
commit 552045a559
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webgpu-cts/scripts/compile_src.py
View File

@ -32,7 +32,7 @@ finally:
def compile_src(out_dir): def compile_src(out_dir):
# First, clean the output directory so deleted files are pruned from old builds. # First, clean the output directory so deleted files are pruned from old builds.
shutil.rmtree(out_dir) shutil.rmtree(out_dir, ignore_errors=True)
run_tsc_ignore_errors([ run_tsc_ignore_errors([
"--project", "--project",
@ -56,7 +56,7 @@ def compile_src_for_node(out_dir, additional_args=None, clean=True):
additional_args = additional_args or [] additional_args = additional_args or []
if clean: if clean:
# First, clean the output directory so deleted files are pruned from old builds. # First, clean the output directory so deleted files are pruned from old builds.
shutil.rmtree(out_dir) shutil.rmtree(out_dir, ignore_errors=True)
args = [ args = [
"--project", "--project",

8
webgpu-cts/scripts/list.py
View File

@ -35,11 +35,9 @@ def list_testcases(query, js_out_dir=None):
try: try:
logging.info('WebGPU CTS: Transpiling tools...') logging.info('WebGPU CTS: Transpiling tools...')
compile_src_for_node(js_out_dir, [ # TODO(crbug.com/dawn/1395): Bring back usage of an incremental build to
'--incremental', '--tsBuildInfoFile', # speed up this operation. It was disabled due to flakiness.
os.path.join(js_out_dir, 'build.tsbuildinfo') compile_src_for_node(js_out_dir)
],
clean=False)
old_sys_path = sys.path old_sys_path = sys.path
try: try: