encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Re-enable Mac ShaderTests 

Issues with log2 on Metal/Intel were actually due to floating point
precision not being guaranteed and the tests not accounting to that.
This has been corrected.

BUG=dawn:663

Change-Id: I401d22898e69ea6b3f96f3d2c57a28b1dc682ed5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/40243
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ryan Harrison 2021-02-03 20:26:13 +00:00 committed by Commit Bot service account
parent 5451b11fb5
commit 59024a62f6
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/end2end/ShaderTests.cpp
View File

@ -23,9 +23,6 @@ class ShaderTests : public DawnTest {};
// Test that log2 is being properly calculated, base on crbug.com/1046622 // Test that log2 is being properly calculated, base on crbug.com/1046622
TEST_P(ShaderTests, ComputeLog2) { TEST_P(ShaderTests, ComputeLog2) {
// TODO(crbug.com/dawn/663): log2(32) is currently being incorrectly calculated.
DAWN_SKIP_TEST_IF(IsMacOS() && IsIntel());
uint32_t const kSteps = 19; uint32_t const kSteps = 19;
std::vector<uint32_t> data(kSteps, 0); std::vector<uint32_t> data(kSteps, 0);
std::vector<uint32_t> expected{0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 32}; std::vector<uint32_t> expected{0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 32};