Update some forward declarations.

This CL removes some forward declarations which are no longer needed
and adds one missing declaration which was pulled in from other headers.

These were found by the clang-tidy bugprone-forward-declaration-namespace
check.

Bug: dawn:1414
Change-Id: I8906861e472f2d64a1547c8c6de348cd4151ffb5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91742
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

.clang-tidy

@@ -7,7 +7,6 @@ Checks: "-*,\
           -bugprone-branch-clone,\
           -bugprone-copy-constructor-init,\
           -bugprone-easily-swappable-parameters,\
-          -bugprone-forward-declaration-namespace,\
           -bugprone-forwarding-reference-overload,\
           -bugprone-implicit-widening-of-multiplication-result,\
           -bugprone-lambda-function-name,\

src/dawn/native/opengl/GLFormat.h

@@ -20,8 +20,6 @@
 
 namespace dawn::native::opengl {
 
-class Device;
-
 struct GLFormat {
     GLenum internalFormat = 0;
     GLenum format = 0;

src/tint/ast/node.h

@@ -19,15 +19,6 @@
 
 #include "src/tint/clone_context.h"
 
-// Forward declarations
-namespace tint {
-class CloneContext;
-}  // namespace tint
-namespace tint::sem {
-class Type;
-class Info;
-}  // namespace tint::sem
-
 namespace tint::ast {
 
 /// AST base class node

src/tint/inspector/resource_binding.h

@@ -20,6 +20,11 @@
 #include "src/tint/ast/storage_texture.h"
 #include "src/tint/ast/texture.h"
 
+// Forward declarations
+namespace tint::sem {
+class Type;
+}  // namespace tint::sem
+
 namespace tint::inspector {
 
 /// Container for information about how a resource is bound

src/tint/sem/array.h

@@ -21,11 +21,6 @@
 #include "src/tint/sem/node.h"
 #include "src/tint/sem/type.h"
 
-// Forward declarations
-namespace tint::ast {
-class Array;
-}  // namespace tint::ast
-
 namespace tint::sem {
 
 /// Array holds the semantic information for Array nodes.

src/tint/sem/block_statement.h

@@ -24,7 +24,6 @@
 namespace tint::ast {
 class BlockStatement;
 class ContinueStatement;
-class Function;
 class Variable;
 }  // namespace tint::ast
 

src/tint/sem/module.h

@@ -23,7 +23,6 @@
 // Forward declarations
 namespace tint::ast {
 class Node;
-class Module;
 }  // namespace tint::ast
 
 namespace tint::sem {

src/tint/sem/statement.h

@@ -20,7 +20,6 @@
 
 // Forward declarations
 namespace tint::ast {
-class Function;
 class Statement;
 }  // namespace tint::ast
 namespace tint::sem {

src/tint/writer/glsl/generator.h

@@ -32,9 +32,6 @@
 namespace tint {
 class Program;
 }  // namespace tint
-namespace tint::writer::glsl {
-class GeneratorImpl;
-}  // namespace tint::writer::glsl
 
 namespace tint::writer::glsl {
 

src/tint/writer/hlsl/generator.h

@@ -30,9 +30,6 @@
 namespace tint {
 class Program;
 }  // namespace tint
-namespace tint::writer::hlsl {
-class GeneratorImpl;
-}  // namespace tint::writer::hlsl
 
 namespace tint::writer::hlsl {
 

src/tint/writer/msl/generator.h

@@ -28,9 +28,6 @@
 namespace tint {
 class Program;
 }  // namespace tint
-namespace tint::writer::msl {
-class GeneratorImpl;
-}  // namespace tint::writer::msl
 
 namespace tint::writer::msl {