encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Convert SerialStorage::Iterator over to being explicit. 

This CL adds the attribute and fixes up the call sites to work with the
constructors being explicit.

Bug: dawn:1339
Change-Id: Ic584477c064411e42143dfc6179bbddb0d6a69c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86871
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-04-19 23:15:14 +00:00 committed by Dawn LUCI CQ
parent fb5a492787
commit 649687497f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/dawn/common/SerialStorage.h
View File

@ -35,7 +35,7 @@ class SerialStorage {
public: public:
class Iterator { class Iterator {
public: public:
Iterator(StorageIterator start); explicit Iterator(StorageIterator start);
Iterator& operator++(); Iterator& operator++();
bool operator==(const Iterator& other) const; bool operator==(const Iterator& other) const;
@ -52,7 +52,7 @@ class SerialStorage {
class ConstIterator { class ConstIterator {
public: public:
ConstIterator(ConstStorageIterator start); explicit ConstIterator(ConstStorageIterator start);
ConstIterator& operator++(); ConstIterator& operator++();
bool operator==(const ConstIterator& other) const; bool operator==(const ConstIterator& other) const;
@ -198,12 +198,12 @@ SerialStorage<Derived>::BeginEnd::BeginEnd(typename SerialStorage<Derived>::Stor
template <typename Derived> template <typename Derived>
typename SerialStorage<Derived>::Iterator SerialStorage<Derived>::BeginEnd::begin() const { typename SerialStorage<Derived>::Iterator SerialStorage<Derived>::BeginEnd::begin() const {
return {mStartIt}; return SerialStorage::Iterator(mStartIt);
} }
template <typename Derived> template <typename Derived>
typename SerialStorage<Derived>::Iterator SerialStorage<Derived>::BeginEnd::end() const { typename SerialStorage<Derived>::Iterator SerialStorage<Derived>::BeginEnd::end() const {
return {mEndIt}; return SerialStorage::Iterator(mEndIt);
} }
// SerialStorage::Iterator // SerialStorage::Iterator