Temporarily avoid error message formatting failure

For unknown reasons formatting of a error context message fails in
RenderEncoderBase::APISetBindGroup fails if the bind group is printed
as a string in the message. This despite the exact same code working as
intended in ComputePassEncoder::APISetBindGroup. Replacing it with a
static "[BindGroup]" to allow the rest of the message to format
correctly until the reason for the failure can be determined.

Bug: dawn:1190
Change-Id: I31105acff4d08849a34e406c6b8e85fab28f17b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/73280
Auto-Submit: Brandon Jones <bajones@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
This commit is contained in:
Brandon Jones 2021-12-21 00:07:01 +00:00 committed by Dawn LUCI CQ
parent 13f4129ec1
commit 67a2d57e3f
1 changed files with 5 additions and 1 deletions

View File

@ -403,7 +403,11 @@ namespace dawn_native {
return {};
},
"encoding %s.SetBindGroup(%u, %s, %u, ...).", this, groupIndexIn, group,
// TODO(dawn:1190): For unknown reasons formatting this message fails if `group` is used
// as a string value in the message. This despite the exact same code working as
// intended in ComputePassEncoder::APISetBindGroup. Replacing with a static [BindGroup]
// until the reason for the failure can be determined.
"encoding %s.SetBindGroup(%u, [BindGroup], %u, ...).", this, groupIndexIn,
dynamicOffsetCount);
}