encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove validator.h 

With this change, the Validator is fully removed from Tint, including
from it's public API.

Fix: tint:642
Change-Id: Id4867cc3866bb2ea09eff499537d58b938d18f43
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47125
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
This commit is contained in:
Antonio Maiorano 2021-04-09 13:26:38 +00:00 committed by Commit Bot service account
parent e2c775f4bb
commit 71512e30ca
4 changed files with 0 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/tint/tint.h
View File

@ -32,7 +32,6 @@
#include "src/transform/renamer.h" #include "src/transform/renamer.h"
#include "src/transform/vertex_pulling.h" #include "src/transform/vertex_pulling.h"
#include "src/type/type_manager.h" #include "src/type/type_manager.h"
#include "src/validator/validator.h"
#include "src/writer/writer.h" #include "src/writer/writer.h"
#if TINT_BUILD_SPV_READER #if TINT_BUILD_SPV_READER

1
src/BUILD.gn
View File

@ -465,7 +465,6 @@ source_set("libtint_core_src") {
"utils/hash.h", "utils/hash.h",
"utils/math.h", "utils/math.h",
"utils/unique_vector.h", "utils/unique_vector.h",
"validator/validator.h",
"writer/append_vector.cc", "writer/append_vector.cc",
"writer/append_vector.h", "writer/append_vector.h",
"writer/float_to_string.cc", "writer/float_to_string.cc",

1
src/CMakeLists.txt
View File

@ -280,7 +280,6 @@ set(TINT_LIB_SRCS
utils/hash.h utils/hash.h
utils/math.h utils/math.h
utils/unique_vector.h utils/unique_vector.h
validator/validator.h
writer/append_vector.cc writer/append_vector.cc
writer/append_vector.h writer/append_vector.h
writer/float_to_string.cc writer/float_to_string.cc

53
src/validator/validator.h
View File

@ -1,53 +0,0 @@
// Copyright 2020 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#ifndef SRC_VALIDATOR_VALIDATOR_H_
#define SRC_VALIDATOR_VALIDATOR_H_
#include <string>
#include "src/diagnostic/diagnostic.h"
namespace tint {
class Program;
// TODO(amaiorano): This class is deprecated. Delete after removing its usage in
// Dawn.
/// Determines if the program is complete and valid
class Validator {
public:
/// Runs the validator
/// @param program the program to validate
/// @returns true if the validation was successful
bool Validate(const Program* program) {
(void)program;
return true;
}
/// @returns error messages from the validator
std::string error() { return {}; }
/// @returns true if an error was encountered
bool has_error() const { return false; }
/// @returns the full list of diagnostic messages.
const diag::List& diagnostics() const { return diags_; }
private:
diag::List diags_;
};
} // namespace tint
#endif // SRC_VALIDATOR_VALIDATOR_H_