encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip BufferUploadPerf 16MB SetSubData on all backends. 

This test is flaky on all backends.

Bug: dawn:239, chromium:1014946
TBR=cwallez@chromium.org

Change-Id: I77dd261420c78d4b7f21a9e54b835ee3466df97d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12360
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
This commit is contained in:
Austin Eng 2019-10-16 18:59:04 +00:00 committed by Commit Bot service account
parent f104ec23bc
commit 7f426898ef
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/tests/perf_tests/BufferUploadPerf.cpp
View File

@ -147,11 +147,8 @@ void BufferUploadPerf::Step() {
} }
TEST_P(BufferUploadPerf, Run) { TEST_P(BufferUploadPerf, Run) {
// TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail on some // TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail.
// configurations. DAWN_SKIP_TEST_IF(GetParam().uploadMethod == UploadMethod::SetSubData &&
DAWN_SKIP_TEST_IF(IsMetal() && GetParam().uploadMethod == UploadMethod::SetSubData &&
GetParam().uploadSize == UploadSize::BufferSize_16MB);
DAWN_SKIP_TEST_IF(IsVulkan() && GetParam().uploadMethod == UploadMethod::SetSubData &&
GetParam().uploadSize == UploadSize::BufferSize_16MB); GetParam().uploadSize == UploadSize::BufferSize_16MB);
RunTest(); RunTest();