encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove the deprecated toggle DEPRECATED_DumpTranslatedShaders 

Bug: dawn:792
Change-Id: I2eee16490617c3371bfd65a69aca678aa4a6f3dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97780
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
This commit is contained in:
Jiawei Shao 2022-08-02 01:45:34 +00:00 committed by Dawn LUCI CQ
parent cbadf96e79
commit 8c590acda0
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/dawn/native/Toggles.cpp
View File

@ -203,8 +203,6 @@ static constexpr ToggleEnumAndInfoList kToggleNameAndInfoList = {{
"Dump shaders for debugging purposes. Dumped shaders will be log via EmitLog, thus printed " "Dump shaders for debugging purposes. Dumped shaders will be log via EmitLog, thus printed "
"in Chrome console or consumed by user-defined callback function.", "in Chrome console or consumed by user-defined callback function.",
"https://crbug.com/dawn/792"}}, "https://crbug.com/dawn/792"}},
{Toggle::DEPRECATED_DumpTranslatedShaders,
{"dump_translated_shaders", "Deprecated. Use dump_shaders", "https://crbug.com/dawn/792"}},
{Toggle::ForceWGSLStep, {Toggle::ForceWGSLStep,
{"force_wgsl_step", {"force_wgsl_step",
"When ingesting SPIR-V shaders, force a first conversion to WGSL. This allows testing Tint's " "When ingesting SPIR-V shaders, force a first conversion to WGSL. This allows testing Tint's "
@ -297,19 +295,12 @@ static constexpr ToggleEnumAndInfoList kToggleNameAndInfoList = {{
} // anonymous namespace } // anonymous namespace
void TogglesSet::Set(Toggle toggle, bool enabled) { void TogglesSet::Set(Toggle toggle, bool enabled) {
if (toggle == Toggle::DEPRECATED_DumpTranslatedShaders) {
Set(Toggle::DumpShaders, enabled);
return;
}
ASSERT(toggle != Toggle::InvalidEnum); ASSERT(toggle != Toggle::InvalidEnum);
const size_t toggleIndex = static_cast<size_t>(toggle); const size_t toggleIndex = static_cast<size_t>(toggle);
toggleBitset.set(toggleIndex, enabled); toggleBitset.set(toggleIndex, enabled);
} }
bool TogglesSet::Has(Toggle toggle) const { bool TogglesSet::Has(Toggle toggle) const {
if (toggle == Toggle::DEPRECATED_DumpTranslatedShaders) {
return Has(Toggle::DumpShaders);
}
ASSERT(toggle != Toggle::InvalidEnum); ASSERT(toggle != Toggle::InvalidEnum);
const size_t toggleIndex = static_cast<size_t>(toggle); const size_t toggleIndex = static_cast<size_t>(toggle);
return toggleBitset.test(toggleIndex); return toggleBitset.test(toggleIndex);

1
src/dawn/native/Toggles.h
View File

@ -59,7 +59,6 @@ enum class Toggle {
EmitHLSLDebugSymbols, EmitHLSLDebugSymbols,
DisallowSpirv, DisallowSpirv,
DumpShaders, DumpShaders,
DEPRECATED_DumpTranslatedShaders, // Use DumpShaders
ForceWGSLStep, ForceWGSLStep,
DisableWorkgroupInit, DisableWorkgroupInit,
DisableSymbolRenaming, DisableSymbolRenaming,