encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded GN config removal after generated file cleanup 

We now have a build step that ensures only the allowed generated file
directories are present so we don't need to remove the default includes
config anymore.

BUG=dawn:22

Change-Id: Id835d1bbb1f52a46ea6502f33b419e70207bba10
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12420
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
This commit is contained in:
Corentin Wallez 2019-10-17 15:51:38 +00:00 committed by Commit Bot service account
parent 919812ed1c
commit 8d000e0cc2
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/dawn_component.gni
View File

@ -95,13 +95,6 @@ template("dawn_component") {
defines = [] defines = []
} }
defines += [ "${invoker.DEFINE_PREFIX}_IMPLEMENTATION" ] defines += [ "${invoker.DEFINE_PREFIX}_IMPLEMENTATION" ]
# TODO(cwallez@chromium.org): Remove this when we are sure the bots have
# been clobbered. This is necessary because when moving generated files
# around we ended up with bad generated files in cached build
# directories that get picked up because of the default inclusion of
# target_gen_dir as an include directory.
configs -= [ "//build/config/compiler:default_include_dirs" ]
} }
static_library("${libname}_static") { static_library("${libname}_static") {
@ -114,13 +107,6 @@ template("dawn_component") {
if (defined(invoker.configs)) { if (defined(invoker.configs)) {
configs += invoker.configs configs += invoker.configs
} }
# TODO(cwallez@chromium.org): Remove this when we are sure the bots have
# been clobbered. This is necessary because when moving generated files
# around we ended up with bad generated files in cached build
# directories that get picked up because of the default inclusion of
# target_gen_dir as an include directory.
configs -= [ "//build/config/compiler:default_include_dirs" ]
} }
group(libname) { group(libname) {