encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable CopyTextureForBrowserTests on Vulkan/Metal Backend 

CopyTextureForBrowser end2end tests had been skipped on Vulkan/Metal
backends due to crbug.com/tint/63.

Because this issue has been fixed, enable CopyTextureForBrowserTests on
Vulkan/Metal backends.

However, D3D12 backend with validation layer still stucks. Raise issue
crbug.com/dawn/592 and keep tests skip.

BUG=dawn:465

Change-Id: I819b3608d07ea7467b33263004e9e19158e73eff
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/34440
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Yan, Shaobo 2020-12-01 07:57:47 +00:00 committed by Commit Bot service account
parent a827aa2c29
commit a6a7e46e54
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/tests/end2end/CopyTextureForBrowserTests.cpp
View File

@ -157,9 +157,7 @@ class CopyTextureForBrowserTests : public DawnTest {
// Verify CopyTextureForBrowserTests works with internal pipeline. // Verify CopyTextureForBrowserTests works with internal pipeline.
// The case do copy without any transform. // The case do copy without any transform.
TEST_P(CopyTextureForBrowserTests, PassthroughCopy) { TEST_P(CopyTextureForBrowserTests, PassthroughCopy) {
// These tests fails due to crbug.com/tint/63. // Tests skip due to crbug.com/dawn/592.
DAWN_SKIP_TEST_IF(IsSwiftshader());
DAWN_SKIP_TEST_IF(IsVulkan());
DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled());
// OpenGL tests fails due to 'WriteTexture' unimplemented. // OpenGL tests fails due to 'WriteTexture' unimplemented.
@ -177,9 +175,7 @@ TEST_P(CopyTextureForBrowserTests, PassthroughCopy) {
} }
TEST_P(CopyTextureForBrowserTests, VerifyCopyOnXDirection) { TEST_P(CopyTextureForBrowserTests, VerifyCopyOnXDirection) {
// These tests fails due to crbug.com/tint/63. // Tests skip due to crbug.com/dawn/592.
DAWN_SKIP_TEST_IF(IsSwiftshader());
DAWN_SKIP_TEST_IF(IsVulkan());
DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled());
// OpenGL tests fails due to 'WriteTexture' unimplemented. // OpenGL tests fails due to 'WriteTexture' unimplemented.
@ -197,9 +193,7 @@ TEST_P(CopyTextureForBrowserTests, VerifyCopyOnXDirection) {
} }
TEST_P(CopyTextureForBrowserTests, VerifyCopyOnYDirection) { TEST_P(CopyTextureForBrowserTests, VerifyCopyOnYDirection) {
// These tests fails due to crbug.com/tint/63. // Tests skip due to crbug.com/dawn/592.
DAWN_SKIP_TEST_IF(IsSwiftshader());
DAWN_SKIP_TEST_IF(IsVulkan());
DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled());
// OpenGL tests fails due to 'WriteTexture' unimplemented. // OpenGL tests fails due to 'WriteTexture' unimplemented.
@ -217,9 +211,7 @@ TEST_P(CopyTextureForBrowserTests, VerifyCopyOnYDirection) {
} }
TEST_P(CopyTextureForBrowserTests, VerifyCopyFromLargeTexture) { TEST_P(CopyTextureForBrowserTests, VerifyCopyFromLargeTexture) {
// These tests fails due to crbug.com/tint/63. // Tests skip due to crbug.com/dawn/592.
DAWN_SKIP_TEST_IF(IsSwiftshader());
DAWN_SKIP_TEST_IF(IsVulkan());
DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled()); DAWN_SKIP_TEST_IF(IsD3D12() && IsBackendValidationEnabled());
// OpenGL tests fails due to 'WriteTexture' unimplemented. // OpenGL tests fails due to 'WriteTexture' unimplemented.