encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[spirv-reader] Add TODO for ArrayStride 

Bug: tint:3
Change-Id: I9655ddbe48f2660f88be68bc52c9467d805043ab
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/18080
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
This commit is contained in:
David Neto 2020-03-27 21:11:05 +00:00
parent 48442a6cee
commit a8bcec3ac1
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/reader/spirv/parser_impl.cc
View File

@ -183,6 +183,7 @@ ast::type::Type* ParserImpl::ConvertType(uint32_t type_id) {
break; break;
} }
case spvtools::opt::analysis::Type::kRuntimeArray: { case spvtools::opt::analysis::Type::kRuntimeArray: {
// TODO(dneto): Handle ArrayStride. Blocked by crbug.com/tint/30
const auto* rtarr_ty = spirv_type->AsRuntimeArray(); const auto* rtarr_ty = spirv_type->AsRuntimeArray();
auto* ast_elem_ty = auto* ast_elem_ty =
ConvertType(type_mgr_->GetId(rtarr_ty->element_type())); ConvertType(type_mgr_->GetId(rtarr_ty->element_type()));
@ -194,6 +195,7 @@ ast::type::Type* ParserImpl::ConvertType(uint32_t type_id) {
break; break;
} }
case spvtools::opt::analysis::Type::kArray: { case spvtools::opt::analysis::Type::kArray: {
// TODO(dneto): Handle ArrayStride. Blocked by crbug.com/tint/30
const auto* arr_ty = spirv_type->AsArray(); const auto* arr_ty = spirv_type->AsArray();
auto* ast_elem_ty = ConvertType(type_mgr_->GetId(arr_ty->element_type())); auto* ast_elem_ty = ConvertType(type_mgr_->GetId(arr_ty->element_type()));
if (ast_elem_ty == nullptr) { if (ast_elem_ty == nullptr) {