encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip dawn_end2end_tests on d3d11 NVIDIA 

Suspect causing undefined behavior seen in crbug.com/1448982

The D3D11 backend is producing validation layers errors, so
that could be the root cause.

Bug: chromium:1448982, dawn:1847
Change-Id: I3fa943f6f9fb48f6cf05da0e571041e6d0c48bed
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134542
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Austin Eng 2023-05-26 03:18:14 +00:00 committed by Dawn LUCI CQ
parent 7d6abb70b2
commit ab6a9b9906
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/dawn/tests/DawnTest.cpp
View File

@ -456,6 +456,14 @@ void DawnTestEnvironment::SelectPreferredAdapterProperties(const dawn::native::I
// All adapters are selected by default. // All adapters are selected by default.
bool selected = true; bool selected = true;
// TODO(chromium:1448982, dawn:1847): Suspect causing undefined behavior due to
// incorrect API usage. Re-enable after fixing.
if (properties.backendType == wgpu::BackendType::D3D11 &&
dawn::gpu_info::IsNvidia(properties.vendorID)) {
selected = false;
}
// The adapter is deselected if: // The adapter is deselected if:
if (mHasBackendTypeFilter) { if (mHasBackendTypeFilter) {
// It doesn't match the backend type, if present. // It doesn't match the backend type, if present.