encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable tests in GpuMemorySynchronizationTests.cpp 

The blocking issues in Tint for the tests in this file have been
resolved, so they can be re-enabled.

There is one outstanding TODO related to Tint in the file about
re-writting one of the shaders, which the root issue for is still
open.

BUG=tint:398

Change-Id: Ia173a33d7ea88b6355dff8b02fd8394f2fa61fd7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39120
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ryan Harrison 2021-01-27 22:15:14 +00:00 committed by Commit Bot service account
parent aae37c2ea3
commit b033c9da8e
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/tests/end2end/GpuMemorySynchronizationTests.cpp
View File

@ -21,13 +21,6 @@
class GpuMemorySyncTests : public DawnTest { class GpuMemorySyncTests : public DawnTest {
protected: protected:
void SetUp() override {
DawnTest::SetUp();
// TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
}
wgpu::Buffer CreateBuffer() { wgpu::Buffer CreateBuffer() {
wgpu::BufferDescriptor srcDesc; wgpu::BufferDescriptor srcDesc;
srcDesc.size = 4; srcDesc.size = 4;
@ -308,13 +301,6 @@ DAWN_INSTANTIATE_TEST(GpuMemorySyncTests,
class StorageToUniformSyncTests : public DawnTest { class StorageToUniformSyncTests : public DawnTest {
protected: protected:
void SetUp() override {
DawnTest::SetUp();
// TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
}
void CreateBuffer() { void CreateBuffer() {
wgpu::BufferDescriptor bufferDesc; wgpu::BufferDescriptor bufferDesc;
bufferDesc.size = sizeof(float); bufferDesc.size = sizeof(float);