encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suppress BufferUploadPerf for setSubData of 16MB on Vulkan 

TBR=enga@chromium.org
BUG=dawn:239

Change-Id: Ie6dda6df45326d57d7ea8f04670904afee25b51d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12161
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2019-10-14 12:38:10 +00:00 committed by Commit Bot service account
parent c44b2d4881
commit b6acae6d35
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/tests/perf_tests/BufferUploadPerf.cpp
View File

@ -147,9 +147,12 @@ void BufferUploadPerf::Step() {
} }
TEST_P(BufferUploadPerf, Run) { TEST_P(BufferUploadPerf, Run) {
// TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail on Metal. // TODO(crbug.com/dawn/239): Investigate why large buffer uploads via SetSubData fail on some
// configurations.
DAWN_SKIP_TEST_IF(IsMetal() && GetParam().uploadMethod == UploadMethod::SetSubData && DAWN_SKIP_TEST_IF(IsMetal() && GetParam().uploadMethod == UploadMethod::SetSubData &&
GetParam().uploadSize == UploadSize::BufferSize_16MB); GetParam().uploadSize == UploadSize::BufferSize_16MB);
DAWN_SKIP_TEST_IF(IsVulkan() && GetParam().uploadMethod == UploadMethod::SetSubData &&
GetParam().uploadSize == UploadSize::BufferSize_16MB);
RunTest(); RunTest();
} }