Fixup whitespace lint issues.
This CL fixes a few blank_line, todo, and comment whitespace errors. Bug: dawn:1339 Change-Id: Iba524396c2fb6750503cbf18e830dac3257beada Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86960 Auto-Submit: Dan Sinclair <dsinclair@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
parent
d1b9d5cc4f
commit
b92f31bf53
|
@ -8,6 +8,3 @@ filter=-runtime/explicit
|
||||||
filter=-runtime/indentation_namespace
|
filter=-runtime/indentation_namespace
|
||||||
filter=-runtime/int
|
filter=-runtime/int
|
||||||
filter=-runtime/threadsafe_fn
|
filter=-runtime/threadsafe_fn
|
||||||
filter=-whitespace/blank_line
|
|
||||||
filter=-whitespace/comments
|
|
||||||
filter=-whitespace/todo
|
|
||||||
|
|
|
@ -308,7 +308,7 @@ namespace dawn::native {
|
||||||
// external textures have been expanded into their underlying contents. For this reason
|
// external textures have been expanded into their underlying contents. For this reason
|
||||||
// we must identify external texture binding entries by checking the bind group entry
|
// we must identify external texture binding entries by checking the bind group entry
|
||||||
// itself.
|
// itself.
|
||||||
// TODO:(dawn:1293): Store external textures in
|
// TODO(dawn:1293): Store external textures in
|
||||||
// BindGroupLayoutBase::BindingDataPointers::bindings so checking external textures can
|
// BindGroupLayoutBase::BindingDataPointers::bindings so checking external textures can
|
||||||
// be moved in the switch below.
|
// be moved in the switch below.
|
||||||
const ExternalTextureBindingEntry* externalTextureBindingEntry = nullptr;
|
const ExternalTextureBindingEntry* externalTextureBindingEntry = nullptr;
|
||||||
|
|
|
@ -86,7 +86,7 @@ namespace dawn::native {
|
||||||
Ref<BindGroupLayoutBase> mLayout;
|
Ref<BindGroupLayoutBase> mLayout;
|
||||||
BindGroupLayoutBase::BindingDataPointers mBindingData;
|
BindGroupLayoutBase::BindingDataPointers mBindingData;
|
||||||
|
|
||||||
// TODO:(dawn:1293): Store external textures in
|
// TODO(dawn:1293): Store external textures in
|
||||||
// BindGroupLayoutBase::BindingDataPointers::bindings
|
// BindGroupLayoutBase::BindingDataPointers::bindings
|
||||||
std::vector<Ref<ExternalTextureBase>> mBoundExternalTextures;
|
std::vector<Ref<ExternalTextureBase>> mBoundExternalTextures;
|
||||||
};
|
};
|
||||||
|
|
|
@ -203,7 +203,7 @@ namespace dawn::native {
|
||||||
// increment the binding counts for an additional sampled textures and a
|
// increment the binding counts for an additional sampled textures and a
|
||||||
// sampler so that an external texture will occupy the correct number of
|
// sampler so that an external texture will occupy the correct number of
|
||||||
// slots for correct validation of shader binding limits.
|
// slots for correct validation of shader binding limits.
|
||||||
// TODO:(dawn:1082): Consider removing this and instead making a change to
|
// TODO(dawn:1082): Consider removing this and instead making a change to
|
||||||
// the validation.
|
// the validation.
|
||||||
constexpr uint32_t kUnimplementedSampledTexturesPerExternalTexture = 2;
|
constexpr uint32_t kUnimplementedSampledTexturesPerExternalTexture = 2;
|
||||||
constexpr uint32_t kUnimplementedSamplersPerExternalTexture = 1;
|
constexpr uint32_t kUnimplementedSamplersPerExternalTexture = 1;
|
||||||
|
|
|
@ -24,7 +24,6 @@ namespace dawn::native {
|
||||||
// Allocation method determines how memory was sub-divided.
|
// Allocation method determines how memory was sub-divided.
|
||||||
// Used by the device to get the allocator that was responsible for the allocation.
|
// Used by the device to get the allocator that was responsible for the allocation.
|
||||||
enum class AllocationMethod {
|
enum class AllocationMethod {
|
||||||
|
|
||||||
// Memory not sub-divided.
|
// Memory not sub-divided.
|
||||||
kDirect,
|
kDirect,
|
||||||
|
|
||||||
|
|
|
@ -306,7 +306,6 @@ namespace dawn::native::d3d12 {
|
||||||
}
|
}
|
||||||
|
|
||||||
D3D12_MESSAGE_ID denyIds[] = {
|
D3D12_MESSAGE_ID denyIds[] = {
|
||||||
|
|
||||||
//
|
//
|
||||||
// Permanent IDs: list of warnings that are not applicable
|
// Permanent IDs: list of warnings that are not applicable
|
||||||
//
|
//
|
||||||
|
|
|
@ -32,7 +32,6 @@ namespace dawn::native::d3d12 {
|
||||||
// https://docs.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_heap_flags
|
// https://docs.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_heap_flags
|
||||||
// https://docs.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_heap_type
|
// https://docs.microsoft.com/en-us/windows/win32/api/d3d12/ne-d3d12-d3d12_heap_type
|
||||||
enum ResourceHeapKind {
|
enum ResourceHeapKind {
|
||||||
|
|
||||||
// Resource heap tier 2
|
// Resource heap tier 2
|
||||||
// Allows resource heaps to contain all buffer and textures types.
|
// Allows resource heaps to contain all buffer and textures types.
|
||||||
// This enables better heap re-use by avoiding the need for separate heaps and
|
// This enables better heap re-use by avoiding the need for separate heaps and
|
||||||
|
|
|
@ -1135,8 +1135,8 @@ TEST_P(BufferZeroInitTest, SetVertexBuffer) {
|
||||||
// draw call. A backend which implements robust buffer access via clamping should
|
// draw call. A backend which implements robust buffer access via clamping should
|
||||||
// still see zeros at the end of the buffer.
|
// still see zeros at the end of the buffer.
|
||||||
TEST_P(BufferZeroInitTest, PaddingInitialized) {
|
TEST_P(BufferZeroInitTest, PaddingInitialized) {
|
||||||
DAWN_SUPPRESS_TEST_IF(IsANGLE()); // TODO(crbug.com/dawn/1084).
|
DAWN_SUPPRESS_TEST_IF(IsANGLE()); // TODO(crbug.com/dawn/1084)
|
||||||
DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsNvidia()); // TODO(crbug.com/dawn/1214).
|
DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsNvidia()); // TODO(crbug.com/dawn/1214)
|
||||||
|
|
||||||
constexpr wgpu::TextureFormat kColorAttachmentFormat = wgpu::TextureFormat::RGBA8Unorm;
|
constexpr wgpu::TextureFormat kColorAttachmentFormat = wgpu::TextureFormat::RGBA8Unorm;
|
||||||
// A small sub-4-byte format means a single vertex can fit entirely within the padded buffer,
|
// A small sub-4-byte format means a single vertex can fit entirely within the padded buffer,
|
||||||
|
|
|
@ -91,11 +91,11 @@ std::vector<uint8_t> VideoViewsTests::GetTestTextureData(wgpu::TextureFormat for
|
||||||
|
|
||||||
// clang-format off
|
// clang-format off
|
||||||
return {
|
return {
|
||||||
Wy, Wy, Ry, Ry, // plane 0, start + 0
|
Wy, Wy, Ry, Ry, // plane 0, start + 0
|
||||||
Wy, Wy, Ry, Ry,
|
Wy, Wy, Ry, Ry,
|
||||||
Yy, Yy, By, By,
|
Yy, Yy, By, By,
|
||||||
Yy, Yy, By, By,
|
Yy, Yy, By, By,
|
||||||
Wu, Wv, Ru, Rv, // plane 1, start + 16
|
Wu, Wv, Ru, Rv, // plane 1, start + 16
|
||||||
Yu, Yv, Bu, Bv,
|
Yu, Yv, Bu, Bv,
|
||||||
};
|
};
|
||||||
// clang-format on
|
// clang-format on
|
||||||
|
|
|
@ -130,7 +130,7 @@ TEST(StackContainer, BufferAlignment) {
|
||||||
#if !defined(DAWN_COMPILER_GCC) || defined(__x86_64__) || defined(__i386__)
|
#if !defined(DAWN_COMPILER_GCC) || defined(__x86_64__) || defined(__i386__)
|
||||||
// It seems that non-X86 gcc doesn't respect greater than 16 byte alignment.
|
// It seems that non-X86 gcc doesn't respect greater than 16 byte alignment.
|
||||||
// See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33721 for details.
|
// See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33721 for details.
|
||||||
// TODO(sbc):re-enable this if GCC starts respecting higher alignments.
|
// TODO(sbc): Re-enable this if GCC starts respecting higher alignments.
|
||||||
StackVector<AlignedData<256>, 1> aligned256;
|
StackVector<AlignedData<256>, 1> aligned256;
|
||||||
aligned256->push_back(AlignedData<256>());
|
aligned256->push_back(AlignedData<256>());
|
||||||
EXPECT_ALIGNED(&aligned256[0], 256);
|
EXPECT_ALIGNED(&aligned256[0], 256);
|
||||||
|
|
Loading…
Reference in New Issue