encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[validation] Add a disabled test for re-assigning a constant. 

Bug:6
Change-Id: Ic2cd1d0eed82354e605e15aec2ba350c15773e51
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/25522
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Sarah Mashayekhi 2020-07-24 14:50:51 +00:00
parent 095523020a
commit ce973e355c
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/validator_test.cc
View File

@ -162,5 +162,28 @@ TEST_F(ValidatorTest, AssignCompatibleTypes_Pass) {
EXPECT_TRUE(v.ValidateAssign(assign));
}
TEST_F(ValidatorTest, DISABLED_AssignToConstant_Fail) {
// v-0021: Cannot re-assign a constant.
// const a :i32 = 1;
// a = 2;
ast::type::I32Type i32;
ast::Variable var("a", ast::StorageClass::kPrivate, &i32);
var.set_constructor(std::make_unique<ast::ScalarConstructorExpression>(
std::make_unique<ast::SintLiteral>(&i32, 1)));
var.set_is_const(true);
auto lhs = std::make_unique<ast::IdentifierExpression>("a");
auto rhs = std::make_unique<ast::ScalarConstructorExpression>(
std::make_unique<ast::SintLiteral>(&i32, 2));
ast::AssignmentStatement assign(std::move(lhs), std::move(rhs));
tint::ValidatorImpl v;
// TODO(SarahM0): Invalidate assignments to a constant.
ASSERT_TRUE(v.has_error());
EXPECT_EQ(v.error(), "2:1: v-0021: cannot re-assign a constant");
}
} // namespace
} // namespace tint