tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL

Change-Id: I18c807b2449dc2842cb9dbfaeba98dae640d2355
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102621
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>

test/tint/expressions/binary/mod/vec3-scalar/f16.wgsl.expected.dxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const vector<float16_t, 3> a = vector<float16_t, 3>(float16_t(1.0h), float16_t(2.0h), float16_t(3.0h));
-  const vector<float16_t, 3> r = (a % float16_t(4.0h));
+  const float16_t b = float16_t(4.0h);
+  const vector<float16_t, 3> r = (a % b);
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/f16.wgsl.expected.glsl

@@ -8,7 +8,8 @@ f16vec3 tint_float_modulo(f16vec3 lhs, float16_t rhs) {
 
 void f() {
   f16vec3 a = f16vec3(1.0hf, 2.0hf, 3.0hf);
-  f16vec3 r = tint_float_modulo(a, 4.0hf);
+  float16_t b = 4.0hf;
+  f16vec3 r = tint_float_modulo(a, b);
 }
 
 layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;

test/tint/expressions/binary/mod/vec3-scalar/f32.wgsl.expected.dxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const float3 a = float3(1.0f, 2.0f, 3.0f);
-  const float3 r = (a % 4.0f);
+  const float b = 4.0f;
+  const float3 r = (a % b);
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/f32.wgsl.expected.fxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const float3 a = float3(1.0f, 2.0f, 3.0f);
-  const float3 r = (a % 4.0f);
+  const float b = 4.0f;
+  const float3 r = (a % b);
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/f32.wgsl.expected.glsl

@@ -7,7 +7,8 @@ vec3 tint_float_modulo(vec3 lhs, float rhs) {
 
 void f() {
   vec3 a = vec3(1.0f, 2.0f, 3.0f);
-  vec3 r = tint_float_modulo(a, 4.0f);
+  float b = 4.0f;
+  vec3 r = tint_float_modulo(a, b);
 }
 
 layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;

test/tint/expressions/binary/mod/vec3-scalar/i32.wgsl.expected.dxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const int3 a = int3(1, 2, 3);
-  const int3 r = (a % 4);
+  const int b = 4;
+  const int3 r = (a % (b == 0 ? 1 : b));
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/i32.wgsl.expected.fxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const int3 a = int3(1, 2, 3);
-  const int3 r = (a % 4);
+  const int b = 4;
+  const int3 r = (a % (b == 0 ? 1 : b));
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/i32.wgsl.expected.glsl

@@ -2,7 +2,8 @@
 
 void f() {
   ivec3 a = ivec3(1, 2, 3);
-  ivec3 r = (a % 4);
+  int b = 4;
+  ivec3 r = (a % b);
 }
 
 layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;

test/tint/expressions/binary/mod/vec3-scalar/u32.wgsl.expected.dxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const uint3 a = uint3(1u, 2u, 3u);
-  const uint3 r = (a % 4u);
+  const uint b = 4u;
+  const uint3 r = (a % (b == 0u ? 1u : b));
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/u32.wgsl.expected.fxc.hlsl

@@ -1,6 +1,7 @@
 [numthreads(1, 1, 1)]
 void f() {
   const uint3 a = uint3(1u, 2u, 3u);
-  const uint3 r = (a % 4u);
+  const uint b = 4u;
+  const uint3 r = (a % (b == 0u ? 1u : b));
   return;
 }

test/tint/expressions/binary/mod/vec3-scalar/u32.wgsl.expected.glsl

@@ -2,7 +2,8 @@
 
 void f() {
   uvec3 a = uvec3(1u, 2u, 3u);
-  uvec3 r = (a % 4u);
+  uint b = 4u;
+  uvec3 r = (a % b);
 }
 
 layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;