encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-04 12:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add assertions to ServerInlineMemoryTransferService to catch corrupted states while fuzzing with DawnWireServerFuzzer and tests."

Browse Source 
This reverts commit f3666c45f3362c7faf7cbdd9328ac76d21327a2a.

Reason for revert: Did not realize these assertions could knowingly be reached after this fix for crbug.com/1340654

Original change's description:
> Add assertions to ServerInlineMemoryTransferService to catch corrupted states while fuzzing with DawnWireServerFuzzer and tests.
>
> Bug: chromium:1340654,chromium:1374495,chromium:1376477
> Change-Id: Icfb008a1cd6dbd8af32f3aedc90ef29e29a0465b
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106041
> Commit-Queue: Brendon Tiszka <tiszka@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1340654,chromium:1374495
Change-Id: I5bff56e32266721ec418a545ad72c1065c73d526
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109461
Commit-Queue: Brendon Tiszka <tiszka@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Brendon Tiszka 2022-11-17 22:08:23 +00:00 committed by Dawn LUCI CQ
parent 83cef52eb7
commit e32457fa11
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dawn/wire/server/ServerInlineMemoryTransferService.cpp
View File

@ -51,8 +51,6 @@ class InlineMemoryTransferService : public MemoryTransferService {
size_t deserializeSize, size_t deserializeSize,
size_t offset, size_t offset,
size_t size) override { size_t size) override {
ASSERT(offset <= mDataLength);
ASSERT(size <= mDataLength - offset);
if (deserializeSize != size || mTargetData == nullptr || if (deserializeSize != size || mTargetData == nullptr ||
deserializePointer == nullptr) { deserializePointer == nullptr) {
return false; return false;