Set depthWriteEnabled to default in ExpectAttachmentDepthStencilTestData
This patch sets depthWriteEnabled to its default value (false) in the helper function DawnTest::ExpectAttachmentDepthStencilTestData() as all the tests can pass with depthWriteEnabled == false on the Linux Intel bots now. Note that previously using depthWriteEnabled == false and writing into FragDepth will cause Linux Intel Mesa driver crash on Mesa 19.0.2. BUG=dawn:821 TEST=dawn_end2end_tests Change-Id: I22cc0dcdb8521fd8eae436d99a7c06167af89b09 Change-Id: Id0dd1c31099c6aafad175bde038ba9662b02a160 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85322 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
This commit is contained in:
parent
f09b03bfee
commit
eab5300e87
|
@ -1375,11 +1375,6 @@ std::ostringstream& DawnTestBase::ExpectAttachmentDepthStencilTestData(
|
|||
if (depthDataTexture) {
|
||||
// Pass the depth test only if the depth is equal.
|
||||
depthStencil->depthCompare = wgpu::CompareFunction::Equal;
|
||||
|
||||
// TODO(jiawei.shao@intel.com): The Intel Mesa Vulkan driver can't set gl_FragDepth unless
|
||||
// depthWriteEnabled == true. This either needs to be fixed in the driver or restricted by
|
||||
// the WebGPU API.
|
||||
depthStencil->depthWriteEnabled = true;
|
||||
}
|
||||
|
||||
if (expectedStencil != nullptr) {
|
||||
|
|
Loading…
Reference in New Issue