Adding a TODO for updating textureLoad on storage images
Change-Id: I1d724a1743caa94ba040aca804dfac6abbb2d6e5 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/28360 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Tomek Ponitka <tommek@google.com>
This commit is contained in:
parent
b6adc5bd42
commit
ed0527a016
|
@ -588,6 +588,8 @@ bool TypeDeterminer::DetermineIntrinsic(const std::string& name,
|
|||
return true;
|
||||
}
|
||||
if (ast::intrinsic::IsTextureOperationIntrinsic(name)) {
|
||||
// TODO: Remove the LOD param from textureLoad on storage textures when
|
||||
// https://github.com/gpuweb/gpuweb/pull/1032 gets merged.
|
||||
uint32_t num_of_params =
|
||||
(name == "textureLoad" || name == "textureSample") ? 3 : 4;
|
||||
if (expr->params().size() != num_of_params) {
|
||||
|
|
|
@ -1529,6 +1529,8 @@ uint32_t Builder::GenerateTextureIntrinsic(const std::string& name,
|
|||
->UnwrapAliasPtrAlias()
|
||||
->AsTexture();
|
||||
|
||||
// TODO: Remove the LOD param from textureLoad on storage textures when
|
||||
// https://github.com/gpuweb/gpuweb/pull/1032 gets merged.
|
||||
if (name == "textureLoad") {
|
||||
auto spirv_params = {std::move(wgsl_params[0]),
|
||||
std::move(wgsl_params[1]),
|
||||
|
|
Loading…
Reference in New Issue