encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixup readability/braces lint warning. 

This CL removes some trailing ;'s which aren't needed to enables the
readability/braces warning.

Bug: dawn:1339
Change-Id: I776267b4282b1345e6b4258d1aff3d7de9fecb8a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86210
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-04-11 14:25:11 +00:00 committed by Dawn LUCI CQ
parent 69347de37b
commit fd64b10b0d
5 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/dawn/CPPLINT.cfg
View File

@ -4,7 +4,6 @@ filter=-build/include_order
filter=-build/include_what_you_use
filter=-build/namespaces
filter=-legal/copyright
filter=-readability/braces
filter=-readability/casting
filter=-readability/inheritance
filter=-readability/namespace

2
src/dawn/node/binding/AsyncRunner.h
View File

@ -58,7 +58,7 @@ namespace wgpu::binding {
// Calls AsyncRunner::Begin()
inline AsyncTask(std::shared_ptr<AsyncRunner> runner) : runner_(std::move(runner)) {
runner_->Begin();
};
}
// Destructor.
// Calls AsyncRunner::End()

4
src/dawn/node/binding/GPUDevice.cpp
View File

@ -487,11 +487,11 @@ namespace wgpu::binding {
std::variant<std::string, interop::UndefinedType> GPUDevice::getLabel(Napi::Env) {
UNIMPLEMENTED();
};
}
void GPUDevice::setLabel(Napi::Env, std::variant<std::string, interop::UndefinedType> value) {
UNIMPLEMENTED();
};
}
interop::Interface<interop::EventHandler> GPUDevice::getOnuncapturederror(Napi::Env) {
// TODO(dawn:1348): Implement support for the "unhandlederror" event.

2
src/dawn/node/binding/GPUTextureView.cpp
View File

@ -31,6 +31,6 @@ namespace wgpu::binding {
void GPUTextureView::setLabel(Napi::Env,
std::variant<std::string, interop::UndefinedType> value) {
UNIMPLEMENTED();
};
}
} // namespace wgpu::binding

6
src/dawn/node/interop/Core.h
View File

@ -340,7 +340,7 @@ namespace wgpu::interop {
return Success;
}
return Error("value is not a ArrayBuffer");
};
}
static inline Napi::Value ToJS(Napi::Env, ArrayBuffer value) {
return value;
}
@ -355,7 +355,7 @@ namespace wgpu::interop {
return Success;
}
return Error("value is not a TypedArray");
};
}
static inline Napi::Value ToJS(Napi::Env, ArrayBuffer value) {
return value;
}
@ -391,7 +391,7 @@ namespace wgpu::interop {
return Error("value is not a TypedArray of the correct element type");
}
return Error("value is not a TypedArray");
};
}
static inline Napi::Value ToJS(Napi::Env, ArrayBuffer value) {
return value;
}