The issue causing these tests to fail was resolved in
https://chromium-review.googlesource.com/c/chromium/src/+/3716961
Bug: 1069302
Change-Id: Iacf06539a0415431b3355bc4b2345c2eb7cab61a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94761
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brandon Jones <bajones@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Now that the test harness serves resources from the new path at
BUILD_DIR/gen/third_party/dawn, remove the other import of the
framework/resources.js script from the old path.
Bug: chromium:1338672
Change-Id: I854e8276f30924a50cc1631f1b28520f16bb5558
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94700
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Changes the test page to expect files to be served from BUILD_DIR
to BUILD_DIR/gen/third_party/dawn. Serving only the subdirectory
shaves multiple seconds off of harness startup in local builds.
Bug: chromium:1338672
Change-Id: I29927e8d0928874fe780f9b15910b0d2eed97833
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94580
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@google.com>
Adds the duration of WebGPU CTS tests to the payload sent
to the test harness so that it can be reported to ResultDB.
Bug: chromium:1336333
Change-Id: I06e16be2c51807c8fbe37730008ed2bd68f82f6c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94520
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Suppresses failures found when switching from 11.5.2 to 12.4
on the Intel Mac Minis.
Bug: dawn:1461, dawn:1462, dawn:1463, chromium:1334335
Change-Id: Ie0d42a1b4aa81f457145a53eebb1501a5eb77fbe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93308
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Update expectations and ts_sources
d275c5e1e3..fee6d96eb3
- fee6d9 Roll @webgpu/types to 0.1.18 (#1506)
- 70df7a Add api,validation,resource_usages,buffer,in_pass_encoder:* - Part V (#1496) (#1502)
- 6302a6 Change importExternalTexture,destroy to importExternalTexture,expired (#1474)
- f188c0 Fix unnecessary imports
- 8afdd9 Update texture format tests to expect exceptions
Created with './tools/run cts roll'
Change-Id: I8bcbca1747f0a2f1414b883860144817a1e16a8a
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92721
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Update expectations and ts_sources
70091fdb8d..d275c5e1e3
- d275c5 Factor copyToTexture:canvas tests common code. (#1497)
- e4ee0a Add api,validation,resource_usages,buffer,in_pass_encoder:* - Part IV (#1496)
- 24c2a7 Add api,validation,resource_usages,buffer,in_pass_encoder:* - Part III (#1480)
Created with './tools/run cts roll'
Change-Id: I95e875667222fcd3f262ed253ac9179f1cd941f2
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92260
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
The CTS runner can randomly pick between these two GPUs, leading to unstable expectations.
Just use 'intel' for now. We might get a more targetted tag in the future, but this will do for today.
Bug: dawn:1387
Bug: dawn:1444
Change-Id: I2c77ab0060976c40e34b1597b5594894867b7edd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92242
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Check that the parsed number fits in an abstract-integer.
Refactor the unit tests so that they're maintainable. Add missing tests.
Bug: tint:1504
Change-Id: I04b6604820d527da66e3f6fcb47391efc0c3330a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91701
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
Update expectations and ts_sources
5f05d6d5e6..70091fdb8d
- 70091f Draw buffer validation test for unused and overlapped cases (#1475)
- cc8668 Revise ExternalTexture Video Test Expectations (#1471)
Created with './tools/run cts roll'
Change-Id: I9d46b7b6582301daaf1f74ddbc41f2ef3bb6b31f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91848
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
The following are now all passing:
• webgpu:shader,execution,expression,call,builtin,ceil:*
• webgpu:shader,execution,expression,call,builtin,floor:*
• webgpu:shader,execution,expression,call,builtin,fract:*
Remove the `KEEP` for the bulk of the shader execution failures.
This will enable the chunk to remove rules for tests when they start passing.
Bug: dawn:1546
Change-Id: I927804b81192efaed00b95aeebd268ec15f358c9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90521
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This is still under investigation, but let's skip for now as it makes
the CTS run very long.
Bug: tint:1524
Change-Id: Ic238ea22119f6165a3d22582bfb93ffd57efed3b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90560
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
Bug: dawn:1410
Change-Id: I0ad4873474614bcd62638583bf905ff2742eaae2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89821
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
The incremental build can become stale for unknown reasons,
breaking presubmits. Disable it for now.
Bug: dawn:1395
Change-Id: I83a71da0006ee3184b8df2996d8e53b6efbcc20a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89640
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Update expectations and ts_sources
547d67bc22..249f2b797b
- 249f2b Don't block on subcases until the end of a testcase (#1335)
- 170d7b Sparse color attachment fix (#1344)
- 423df1 DevicePool: merge default holder into the DescriptorToHolderMap (#1343)
- 10ce93 remove doInit/doFinalize (#1342)
- d5cf9a Handle backends flushing inputs in `atan2` tests (#1340)
- 318d3d Move test device selection to an optional before clause (#1333)
- ece4eb Fix non-object-type test-parameter values (#1336)
- 5906dc Add --colors flag for enabling color output (#1338)
Created with './tools/run cts roll'
Change-Id: I070d813ffe3017e1bd4e425247f1ea174ee63887
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88720
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
This workaround replaces the toggle that forbids creating mipmapped
R8Unorm and RG8Unorm textures on Metal. Instead it adds a Metal render
pass workaround that renders to a temporary texture under certain
conditions, then copies back to the correct mip level.
The texture lazy-clearing code is also changed to use the helper that
does workarounds for Metal render passes.
A test is added that triggers the issue with a small amount of code, but
more extensive coverage is left to the CTS. For example texture_zero
tests caught multiple issues during the creation of this CL.
Bug: dawn:1071
Change-Id: I7ef1151524e71e5a9a8e8f5205d9b554bee438b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87864
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
It is failing for a single format when trying to copy to a buffer
because the depth-specific format for depth23unorm-stencil8 buffer is
depth24plus which is not copyable.
Bug: dawn:1388
Change-Id: I034145bf55d42403ded23b1b9acf974d85770d42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87701
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
intel-0x3e92 was not added, but intel-0x5912 was - leading
to flaky CQ rejection depending on what bot happened to run
the task.
Generalize this expectation since it fails on all platforms
anyway.
Bug: dawn:1387
Change-Id: Iccd4806de456a817edf538041445ee2ac93099e7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87675
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Update expectations and ts_sources
a06666e000..45d2ccd250
- 45d2cc Fixed TS errors
- 5eacfb Take new createView() dimension default logic into account
- cbdcbd Explicitly destroy devices created by requestDevice_limits
Created with './tools/run cts roll'
Change-Id: I701bc9e6fa6b1996b1ed40b08766cc9dedaf20d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87621
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
• Remove a number of expectations that are no longer needed.
• Change a number of expectation tags to be more specific.
• Sort the expectations per chunk.
• Add a few more wide-wildcard 'Failure' rules for tests that commonly flake.
Bug: dawn:1342
Change-Id: I0e23cd546f7ab54a5720e24c52e3782b5df6b99f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87520
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Adds support for non-zero first/baseVertex on Draw[Indexed]Indirect by
duplicating the first/baseVertex indirect parameter onto a root
constant in the indirect buffer.
Change-Id: I280149065179806d3e57b07f1a396f9e2e4e8fcb
Bug: dawn:548
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84240
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Enrico Galli <enrico.galli@intel.com>
Auto-Submit: Enrico Galli <enrico.galli@intel.com>
The current presubmit has the filter inverted so it would only attempt
to match the filtered files. The file name also has to be converted to
`LocalPath` otherwise it's attempting to compare a python object to a
string and always fails to match.
Bug: dawn:1339
Change-Id: Ie7712dee60f6b9df2cb78c9feab11769f7ea1f02
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87080
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Fixed: dawn:1370
Change-Id: I395b3e6e2506608ca4aefdbcef18443b90ca75ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87302
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
These are known crashes from the old WebGPUExpectations. Running
them is a waste of resources.
Bug: chromium:1309194, chromium:1234041, chromium:1236130, chromium:1315987
Change-Id: I7bbf70d0bc5abd09ebf47e2e65521d4a4fa5363e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86844
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Updates the CTS test runner JS to split logs into multiple
pieces if they're in danger of running into the payload
size limit that the test harness has.
crrev.com/c/3584705 must land in Chromium first.
Bug: chromium:1315658
Change-Id: I30ff416741515ce784116a2cbfbf193b6a4d71f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86509
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
dcba3ac6b8..5e83d8349b
$ git log dcba3ac6b..5e83d8349 --date=short --no-merges --format='%ad %ae %s'
2022-04-13 cwallez Reduce the length of subresource test names (#1164)
2022-04-13 cwallez zero_init: add constant zero to prevent driver unrolling loops. (#1163)
2022-04-13 jiawei.shao Add validation,resource_usages,texture,in_render_misc:* - Part II (#1161)
2022-04-13 jiawei.shao Add validation,resource_usages,texture,in_render_misc:* - Part I (#1157)
2022-04-11 enga Test view format reinterpretation (#1126)
2022-04-11 litherum Only 2D textures can be marked as render targets (#1155)
2022-04-08 cwallez operation,image_copy: Add support for depth16unorm (#1154)
2022-04-08 cwallez image_copy,mip_levels: reduce the mip level count. (#1151)
2022-04-08 cwallez depth_compare_func: Don't use 0.5 as depth16unorm rounds either way (#1152)
2022-04-08 cwallez Fix tests trying to copy aspects of depth-stencil textures. (#1146)
2022-04-08 cwallez depth_clip_clamp: only set stencilLoadOp and friends when needed. (#1153)
2022-04-08 cwallez Fix validation errors with depth/StencilLoad/StoreOp set when not allowed. (#1145)
2022-04-08 enga Shorten test and param lengths in resource_usages,texture,in_render_common:* (#1144)
2022-04-08 jiawei.shao Add validation,resource_usages,texture,in_render_common:* - Part V (#1150)
2022-04-06 cwallez val,buffer,create: Buffer sizes don't have to be multiple of 4. (#1140)
2022-04-06 cwallez image_copy: Ensure bufferOffset % 4 == 0 for depth-stencil. (#1139)
2022-04-06 jiawei.shao Add validation,resource_usages,texture,in_render_common:* - Part IV (#1132)
2022-04-05 enga Fix infinite recursion in CopyExternalImageToTexture.spec.ts (#1143)
2022-04-05 cwallez Use globalThis instead of self. (#1141)
2022-04-05 cwallez val/copyT2T,format_compat: Don't assume compressed is always 4x4 (#1134)
2022-04-05 cwallez Fix DSAttachment load/store ops being specified when disallowed. (#1136)
2022-04-05 cwallez Fix test of BGL binding limits to correctly check limits (#1137)
2022-04-04 cwallez Fix a validation error caused by WriteTexture bytesPerRow: t.width (#1133)
2022-04-04 cwallez Add unicode tests for entryPoint matching. (#1131)
2022-04-04 cwallez writeBuffer: an unaligned bufferOffset is a validation error. (#1129)
Created with:
roll-dep third_party/webgpu-cts
Change-Id: I048afcaf3d33bcd67401412bf235181013ebf6d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86533
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
So we can begin running the CTS on SwiftShader and add targeted
suppressions when necessary.
Bug: chromium:1315703
Change-Id: Ic68e43ad0d79830b3ef5559ea1de0133d48ea43c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86626
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Roll CTS to dcba3ac6b819abb0920e589ca1809ae5b5f87119
Update ts_sources.txt
Regenerate expectations
Change-Id: Ifa0cae3fa1abf9da9e4fbd63acf9cefe2683f50d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85560
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Adds a script to take a CTS queries, expand them to individual test case
names, and append them to the end of expectations.txt as valid
expectations.
Bug: chromium:1306640
Change-Id: I55067c8c49aeb4360d488841da12c06d88346b8a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84740
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Austin Eng
Brandon Jones
Brian Sheedy
Ben Clayton
Corentin Wallez
Yunchao He
Antonio Maiorano
Enrico Galli
Jiawei Shao
dan sinclair
Shrek Shao