Works around issues on Metal Intel where CopyB2T and WriteTexture
with depth/stencil textures do not work correctly.
Fixes test failures with depth16unorm in the CTS.
Deletes UseTempTextureInStencilTextureToBufferCopy in favor of
the stencil blit. The former supposedly fixes a problem where
the stencil data is not flushed into the real stencil texture
by performing another T2T copy. This only works because the Metal
Intel backend also happens to allocate s8 as d32s8. Copying
the depth aspect as well seems to make the driver remember to
flush the data.
The stencil blit is a better fix for the problem since entirely
avoids getting the driver into a bad state where the stencil data
is not in sync.
Fixed: dawn:1389
Change-Id: If34b1d58996157036c164a5bc329e38b5e53f67a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117910
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Adds a toggle to workaround another issue where Metal fails to set
the depth/stencil attachment correctly for a combined depth stencil
format if just one of the attachments is used. The workaround forces
both attachments to be set, giving the unused one LoadOp::Load and
StoreOp::Store so its contents are preserved.
Bug: dawn:1389
Change-Id: Iacbefcc57b33bf11ca8fcacb03506301646fe59d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117175
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
This CL updates a few shader expectations with the relevant issue
number.
Change-Id: I8c38857a51276f4cc3206ee8617f3edda747a301
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117480
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Stencil to buffer copies don't capture contents
written in a rendering stage. Copying through an
intermediate texture fixes this problem on Metal Intel.
Add test for the code path that found the issue:
Nonzero-mip stencil copy, discard, then read
Bug: dawn:1389
Change-Id: I63d982df6bace4b5053d3c643b8abda1682490d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116851
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Stencil8 textures don't work correctly on some drivers. Workaround
by allocating a combined depth-stencil texture instead.
Suppress newly added test on Windows ANGLE
Bug: dawn:1389, dawn:1637
Change-Id: Iea03e8f3e5e7f663ffc7b344ab007a73836557cc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116846
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Regenerated:
- expectations.txt
- ts_sources.txt
- test_list.txt
- cache_list.txt
- resource_files.txt
- webtest .html files
0d52602a41..941695197d
- 941695 Make objectEquals(NaN, NaN) return true (#2153)
- 23b860 Make it possible to simply run the wpt ref tests
- 1b9cc1 Fix Buffer.mapState op tests (#2145)
- 0cb55f Use takeScreenshotDelayed in canvas_image_rendering-ref.html
- 9adf83 Remove phantom dependency on reftest-wait.js, copy code into CTS
- ce6e91 Maximize the acceptance interval size for `dot` (#2151)
- d1093e If subcase can't be added to .message, use .stack (#2144)
- f44818 Add more states to canvas composite ref tests. (#2133)
- f7fcc6 Cache pipelines between batches for expression tests
- 142289 Optimize expression shaders for `inputSource="uniform"`
- f3764e Unclutter the URL
- 6a7b90 Add Buffer.mapState test (#2130)
Created with './tools/run cts roll'
Change-Id: I8cfc04e78f1bfc387d49926344a1792c6d319760
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117000
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
This patch enables the WebGPU CTS test on the compilation info with
unicode after all the related patches landed in Chromium and Dawn.
Bug: dawn:1357
Change-Id: Ifebc42b36697bb6d757254c313e1832e9966fefa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116923
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This CL adds an issue number for the compute_builtin expectations.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Bug: tint:1801
Change-Id: Id8c5a5985fe36a941fa293dbe98821f043da6cd3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116689
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This CL adds an issue number for the `dot` expectations.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Bug: tint:1790
Change-Id: I424f7ffcadbb58334f29061f31a9a7edd242738a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116685
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
The HLSL `sign` method returns an `int` result (scalar or vector). The
WGSL `sign` expects the result to be the same type as the argument. This
CL injects a cast to the correct type after the `sign` call in the HLSL
generated source.
Bug: tint:1795
Change-Id: I51fed24b5b8b752b6b27fdfb5dd47eb803902793
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116692
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Regenerated:
- expectations.txt
- ts_sources.txt
- test_list.txt
- cache_list.txt
- resource_files.txt
- webtest .html files
fdf9e7c129..0d52602a41
- 0d5260 [wgs] Sync keyword and reserved word list to spec. (#2141)
- 690ad7 Add a ResizeObserve test
- 2515d1 Test you can not create 1d, 2d-array, and 3d multisampled textures (#2111)
- b30685 Remove class=reftest-wait from a -ref.html (#2140)
- cfdfa0 remove <link rel=match> from -ref.html (#2137)
- 23ff9b Test texture descriptor validation in GPUCanvasContext (#2126)
Created with './tools/run cts roll'
Change-Id: I2c834baf6aea6ae9c8811a418c9dab96f53624ef
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116780
Kokoro: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
This CL adds an issue number the F32 remainder expectations. The other arithmetic tests are passing and are removed from the expectation file.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Bug: tint:1799
Change-Id: I170d8631c952eb99e40afa039d604072af6a3f34
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116687
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This CL adds a tracking issue to the `sign` expectations
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Bug: tint:1795
Change-Id: Ibfb90b62db6006a237247b97a82c976d4f96aab2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116686
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This CL adds a tracking issue for the `countTrailingZeros` expectations.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Bug: tint:1794
Change-Id: I43473e9ce771de65073935fc543d29c36f787ad3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116683
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
This CL adds a tracking issue for the `firstTrailingBit` expectations.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Bug: tint:1794
Change-Id: I1566641df3bd37c6d72baf6e3fc6a7c1c3a22204
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116684
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
The below WebGPU CTS tests fail consistently on Win10 Intel FYI bots
and we have to suppress them temporarily:
- validation,error_scope:current_scope:* with StackDepth=100000
Bug: chromium:1406064
Change-Id: Ib74fb76c529c522fb7389fadec8a23cd9d99d806
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116690
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
The const-eval work is complete in Tint, enable the const-eval tests in
the expectation file.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Change-Id: I64986982967031fc818522f8fc60b3faad382781
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116681
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Various updates have been made to the way the CTS runs tests which
should make this faster and non-flaky.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Change-Id: I2c241efabf240e82d700780e018bd1ce636c6f87
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116680
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
With the CTS global timeout extended, and tweaks to how const-eval loops are emitted, we now have a whole lot of passing tests.
Adjust the 'Slow' threshold to account for the new global timeout.
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Change-Id: I9a4d3278048e72e6560552164522395423dedf99
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116296
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Re-enable External Texture CTS for Mac/VideoFrame following test
expectations being revised.
Bug: dawn:1631
Bug: chromium:1316671
Change-Id: I7423c274b5d77832e3c98706829f66425f97e23b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116370
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Brandon1 Jones <brandon1.jones@intel.com>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
This patch enables all the CTS tests about stencil copy on Win10
Intel bots after the driver of the bots being upgraded to
31.0.101.2111.
Bug: dawn:1487
Change-Id: Ib6fae45da4d5db73b165d9d6a1f9dc8c4310d5a0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116401
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
And unroll const-eval expression test loops on non-windows platforms, in an
attempt to avoid test timeouts on devices that perform poorly with constant array
indexing inside loops.
Regenerated:
- expectations.txt
- ts_sources.txt
- test_list.txt
- cache_list.txt
- resource_files.txt
- webtest .html files
0673bb68c2..6d3a80420d
- 6d3a80 Add flag to unroll const-eval loops
Created with './tools/run cts roll'
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Change-Id: Ida17dbab3eeed1e30610af63d036c3d43ceafa68
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116292
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Start using Tint's ClampFragDepth transform in the Vulkan backend when
needed in order to correctly clamp @builtin(frag_depth) on Vulkan. Do
this by always reserving 8 bytes of push constant space to contain the
f32 min and max values from the last viewport command.
Reenables relevant CTS tests that were suppressed on Vulkan.
Bug: dawn:1125, dawn:1576, dawn:1616
Change-Id: I38f4f6c3c51c99b5e591a780fea9859537529534
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105642
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Regenerated:
- expectations.txt
- ts_sources.txt
- test_list.txt
- cache_list.txt
- resource_files.txt
- webtest .html files
09447faf1a..0673bb68c2
- 0673bb Fix silencing of DOMExceptions (#2102)
- d85507 Test beginComputePass/RenderPass after encoder.finish() in call_after_successful_finish (#2093)
- 861b20 Update kMaxQueryCount to 4096 (#2104)
- 030f44 Add some progress
- 62dbcc Support dark mode
- 6a7030 Buffer.mapAsync pending map error shouldn't be a validation error (#2080)
- 44173e Test all stencil formats, and address some nits in depth_bias/stencil tests (#2096)
- 172002 op: Update 'stencil_compare_func' test in stencil.spec.ts (#2094)
- f12820 op: Implement 'depth_bias_24bit_format' test in depth_bias.spec.ts (#2095)
- 5f2708 Add earlyRejection parameter to testMapAsyncCall() (#2052)
- dcdcb3 op: Implement 'stencil_depthFailOp_operation' test in stencil.spec.ts (#2092)
- d13c42 op: Update 'stencil_test_fail' test (#2091)
- 5daf3c Fix wrong _errorLine in operation/shader_module/compilation_info.spec.ts (#2088)
- 47d19f op: Introduce depth_bias.spec.ts file with a 'depth_bias' test (#2075)
- 7a679a Prefix subcase recorder error stacks with the subcase name (#2086)
- 17522c fix requestAdapter test.
- 5a5838 Implement CTS requestAdapter test
- e583fa Add 'skipUndefined' Comparator (#2082)
- e0e735 Remove usage of Case Cache in `pack2x16float`
- eb5794 Update copyTextureToTexture tests to allow both encodings of -1 for 8-byte snorm formats (#2073)
- 516d19 Expect DataCloneError when transferring a detached mapped ArrayBuffer (#2076)
- 8985b5 Filter inputs that will cause const-eval to fail validation due to OOB
- 216c8e Remove attempting to emit infinities in WGSL (#2059)
- b99b81 Adds explicit check that mapAsync rejects when buffer is destroyed. (#2069)
- ae20ff Add code coverage collection feature to the server
- 1ff6ae Implement generate*Cases functions and use them (#2062)
- 7e99a7 op: Implement 'depth_test_fail' test in depth.spec.ts (#2067)
- b701c5 Add val:*_pipeline,overrides,value,type_error/validation_error (#2061)
- b6f758 op: Implement 'stencil_reference_initialized' test in stencil.spec.ts (#2063)
- 89bf5e Also test depthWriteEnabled:true in depth_write_disabled (#2065)
- 40e3ae op: Implement 'depth_disabled' test in depth.spec.ts (#2050)
- 677ece op: Implement 'depth_write_disabled' test in depth.spec.ts (#2024)
- a6b97c Remove infinities from all f32 test inputs (#2056)
- 41a1e5 Replace usage of vector inputs with fullF32Range for arithmetic tests (#2053)
- 16bb08 wgsl: Add tests for preservation of padding bytes (#2051)
- 7d16f8 op: Implmenet 'stencil_pass_operation' test in stencil.spec.ts (#2055)
- dcc430 op: Implement stencil_read_write_mask test in stencil.spec.ts (#2043)
- f539a2 op: Implement stencil_fail_operation test in stencil.spec.ts (#2044)
- 8041ca update deps for various packages (#2041)
- 09b30e op: Implement 'stencil_compare_func' test in stencil.spec.ts (#2032)
- c6efbf Except a TypeError when transferring a mapped ArrayBuffer (#2019)
- dd4316 op: Add more parameters to 'color_write_mask,channel_work' test (#2025)
- b66a1a Replace calls to F32Interval constructor with toF32Interval (#2037)
- fdab6c Clean up a couple of .map in f32_interval.spec.ts tests (#2038)
- 40abc0 Test buffer.mapAsync() early rejection (#2033)
- 25ddea Handle inputs that are arrays in `cartesianProduct` (#2031)
- 0e790f Only try to generate errors for testable error filters (#2034)
- 57304e Fix workgroup array size limit validation test (#2035)
Created with './tools/run cts roll'
Change-Id: I9b6e2b8526fc62acbf915b5e8153d32ae02c7a14
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116420
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
The metal validation layer complains when copying from a 3D texture to
a buffer if the stride for the destination buffer is larger then 2048
bytes.
Bug: dawn:1430
Change-Id: I6ba4508d71610c35dfb0fab7d2bebc91d37504e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113426
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
This immediate rejection has been implemented in Native but
hasn't been yet in Wire. This commit adds the implementation
to Wire.
Also the commit changes the MapAsync callback firing timing
if pending map buffer is unmapped or destroyed. With this
commit the callback will be fired immediately Unmap or
Destroy is called to match the WebGPU spec. Currently the
callback is fired when the client receives a response from
server but it mismatches the spec.
Change-Id: Ia48d62be31912fd0384e23271e9de516f9d71d6c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113607
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Takahiro <hogehoge@gachapin.jp>
Reviewed-by: Austin Eng <enga@chromium.org>
Without this, the next update will rebuild these expectations, without the Skip.
They appear to be flakey, preventing rolls from landing.
Change-Id: I09eacf9596fd4d984e2c6ac600076dbaeafe5347
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114700
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Disable GPU uploading path on linux ensure it hit on fallback CPU
uploading path. Test cases should work on that path.
Bug: chromium:1309194
Change-Id: Ic50314e780f287569cccfdbb3503c8c3df10f532
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112000
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This is a reland of commit cde5589953
Original change's description:
> Add expectations.txt validation to presubmit
>
> Change-Id: Ibabdfbdf44b027a6e6441e140f23b2c2488f32dc
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112120
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
Change-Id: I013eeec03e27b3147023ea094f5bde011561edd1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113540
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Austin Eng <enga@chromium.org>