encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
11,048 Commits 2 Branches 0 Tags 145 MiB
Commit Graph

11048 Commits

Author SHA1 Message Date
Li, Hao ad57a58488 Add suppressed end2end tests back on Intel Windows Vulkan 
Vulkan backend had been disabled on Intel Windows Vulkan driver <
30.0.101.2111, these suppressed end2end tests are fixed on that version
and later, we can remove the suppression.

Bug: dawn:1392, dawn:819, dawn:1172, dawn:1489
Change-Id: I91a8dfac833b068e8e3bb70d9f9af977f7b6026c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113610
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
 2022-12-12 17:10:40 +00:00
Yan,Shaobo 6bd13328fb Enable copyToTexture cases on linux 
Disable GPU uploading path on linux ensure it hit on fallback CPU
uploading path. Test cases should work on that path.

Bug: chromium:1309194
Change-Id: Ic50314e780f287569cccfdbb3503c8c3df10f532
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112000
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
 2022-12-12 17:10:06 +00:00
Dawn Autoroller b6df89147a Roll SwiftShader from 36e043fa6d46 to 9bfd96203d19 (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/36e043fa6d46..9bfd96203d19

2022-12-12 sugoi@google.com Fix Kokoro presubmit checks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: Iac8f0e793aeaa5a7ea1b6577c16bdd3b7bb6689b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113761
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-12 16:07:40 +00:00
Antonio Maiorano 7c9e639e35 tint: const eval of mix builtin 
Bug: tint:1581
Change-Id: I3b9f0ff3a58956616daf17b3d4a922979fc30216
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113680
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-12 15:31:21 +00:00
Dawn Autoroller b5fedb7b5a Roll ANGLE from f8980c98b28d to b1b4640104fc (1 revision) 
f8980c98b2..b1b4640104

2022-12-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3b96c02c7465 to 1c9a08119fdd (378 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I12d03b2a7e078ea32a6f1350eb6b35b8704b112d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113760
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-12 10:39:24 +00:00
dawn-autoroll 3f96cc8bb8 Roll vulkan-deps from a500751650f8 to 4513d3d91ac3 (2 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/a500751650f8..4513d3d91ac3

Changed dependencies:
* vulkan-validation-layers: 9487f4b06c..7140eba938

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: Iacaf36028c09e80f36539da73bddf85f363d2a96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113609
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-12 06:26:41 +00:00
Dawn Autoroller 8b18988385 Roll ANGLE from fd75686e8380 to f8980c98b28d (6 revisions) 
fd75686e83..f8980c98b2

2022-12-10 cclao@google.com Vulkan: Make ReadWriteResource subclass from Resource
2022-12-10 cclao@google.com Vulkan: Use finishQueueSerial for queueSubmitOneOff
2022-12-10 cclao@google.com Vulkan: Remove Resource::isCurrentlyInUse
2022-12-09 cclao@google.com Vulkan: mapRangeImpl should call flushImpl if unflushed write
2022-12-09 cclao@google.com Vulkan: Make PipelineHelper go through normal collectGarbage
2022-12-09 syoussefi@chromium.org Vulkan: Move desc set updates cache to share group

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I59f0373f81b5e662b3593e4d8495ab8594f66a42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113721
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-10 12:50:08 +00:00
Dawn Autoroller f87773947c Roll SwiftShader from 6ebc3347af9d to 36e043fa6d46 (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/6ebc3347af9d..36e043fa6d46

2022-12-10 capn@google.com Add a macro for indicating unoptimized code paths

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I525c8c32677909e8a896eacfa7ff7f975f3beaae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113720
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-10 04:53:47 +00:00
dawn-autoroll da9dcd34f8 Roll vulkan-deps from 89b9b4762b94 to a500751650f8 (10 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/89b9b4762b94..a500751650f8

Changed dependencies:
* glslang: ed257e2bdf..6d8b00b1c6
* vulkan-headers: bf3b3fb14e..9b48e83ef8
* vulkan-tools: f846ef57a0..ffa89a4447
* vulkan-validation-layers: 934d2bddab..9487f4b06c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I7cb4682c653096e48fd7c6d2b2601a19e124c615
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113603
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-10 02:10:15 +00:00
Ben Clayton e38993feb1 CMake: Expand TINT_EMIT_COVERAGE to DAWN_EMIT_COVERAGE 
Change-Id: I0caf174ecc68ffd3272e5ebfd6bf68f9bb4e53c1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113640
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-12-10 00:15:57 +00:00
Dawn Autoroller f681d00f39 Roll ANGLE from c9e7fd9c25c9 to fd75686e8380 (13 revisions) 
c9e7fd9c25..fd75686e83

2022-12-09 syoussefi@chromium.org Vulkan: Fix EGL image queue change vs threads
2022-12-09 ynovikov@chromium.org Skip couple non-deterministic angle_restricted_trace_gold_tests
2022-12-09 lexa.knyazev@gmail.com GL: Support clip and cull distance redeclarations
2022-12-09 cclao@google.com Vulkan: Remove CommandQueue::mQueueSerialMutex
2022-12-09 syoussefi@chromium.org Vulkan: Remove the unused shadowBuffer feature
2022-12-09 cclao@google.com Vulkan: Remove ImageHelper::mImageAndViewGarbage
2022-12-09 ynovikov@chromium.org Enable angle_restricted_trace_gold_tests retries on Win Intel UHD630
2022-12-09 penghuang@chromium.org Workaround GetModulePath() returns incorrect path for exe in Chrome
2022-12-09 chris@rive.app Improve PLS load and store op tokens
2022-12-09 jmadill@chromium.org Better support for "vulkan-null" backend in trace tests.
2022-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4affe58949d3 to 89b9b4762b94 (5 revisions)
2022-12-09 gert.wollny@collabora.com Capture/Replay: Only create active secondary contexts in MEC
2022-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from eb46dc0d0fce to 3b96c02c7465 (547 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I0de746baed051f90d89ec6c93d47a0db0b3b17a2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113700
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-09 23:26:06 +00:00
Antonio Maiorano 28779af91c tint: impement short-circuiting for const eval of logical and/or 
Bug: tint:1581
Change-Id: I44852bfeb0e55771009a89ed199ea60ca51e8477
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113431
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-09 21:28:51 +00:00
David Neto 24c8440eb6 Update spirv-reader docs: supports texture and sampler func args 
Change-Id: I893f050e3377c2aebe933a55d6e75c505c3e23d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113560
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
 2022-12-09 19:53:27 +00:00
dawn-autoroll ca01ec4689 Roll vulkan-deps from e6dba61053b8 to 89b9b4762b94 (1 revision) 
https://chromium.googlesource.com/vulkan-deps.git/+log/e6dba61053b8..89b9b4762b94

Changed dependencies:
* vulkan-validation-layers: 2bbe7a9dfd..934d2bddab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I99b7b4f479fe36784810b29372b4e4c4fc77654f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113601
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-09 13:10:10 +00:00
Ben Clayton f528d33d52 tint/transform: fix PromoteInitializersToLet for constant expressions 
Fix more edge cases uncovered with tint:1781

Fixed: tint:1781
Change-Id: I58d120185f47c10bc9fe55dd95a198d496c4ec94
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113024
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
 2022-12-09 12:34:36 +00:00
Dawn Autoroller dd0d45102a Roll ANGLE from 28290e34215a to c9e7fd9c25c9 (6 revisions) 
28290e3421..c9e7fd9c25

2022-12-08 sugoi@chromium.org Revert "Skip AssignAssignmentToSwizzled on SwS Linux/Win"
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5e89361766f7 to 4affe58949d3 (3 revisions)
2022-12-08 syoussefi@chromium.org Vulkan: Use VK_EXT_pipeline_protected_access
2022-12-08 cclao@google.com Vulkan: Remove synchronous commands from CommandProcessor
2022-12-08 cclao@google.com Vulkan: Remove QueryVk::hasUnsubmittedUse()
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7935ee7ccbc0 to 5e89361766f7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I57a75a326f4cd483c6c86e4d7a0ee49a732848c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113580
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-09 08:51:33 +00:00
dan sinclair 837b8042d3 Rename TypeManager to Manager. 
With the move to the type:: hierarchy rename type::TypeManager to
type::Manager.

Bug: tint:1718
Change-Id: I1c8e2c2e469e20b959676232e9f3d62c9b3a789e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113429
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-12-09 05:00:07 +00:00
dawn-autoroll 0dc71406da Roll vulkan-deps from 7935ee7ccbc0 to e6dba61053b8 (8 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/7935ee7ccbc0..e6dba61053b8

Changed dependencies:
* vulkan-headers: b75e5a02b6..bf3b3fb14e
* vulkan-loader: 82d4232f0f..b43758588b
* vulkan-tools: ce45337c51..f846ef57a0
* vulkan-validation-layers: 1e422524e7..2bbe7a9dfd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I3efe6a8e909f4a843ce444bfbb7e4b029f7ec628
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113542
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-09 00:04:44 +00:00
dan sinclair 98705d417e Remove type:: prefix in type/ folder. 
Remove type:: namespaces added during the file moves.

Bug: tint:1718
Change-Id: I9862296cf93aad92e6c2b2e54d06d1c53d3a9b09
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113428
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 22:21:24 +00:00
dan sinclair 946858ad56 Move array to type/ 
This CL moves array to the type/ folder. Namespaces are updated as
needed. A FriendlyName method was added to ArrayCount so the sem::
ArrayCount entries do not need to be referenced inside type/.

Bug: tint:1718
Change-Id: I16a8f32b3fab1131b284a6981a5c386081138b08
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113427
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 22:21:24 +00:00
dan sinclair f53b2b5b2e Split sem/struct into sem and type. 
This CL moves the Base entries from sem/struct into type. The class
names are maintained as Base over the move and will be renamed in a
followup.

Bug: tint:1718
Change-Id: I07bed013167c58fc83f0069c781404d8197966ee
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113425
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 22:21:24 +00:00
dan sinclair d8a084585f Move atomic to type/ 
This CL moves atomic to type/ and updates the namespaces.

Bug: tint:1718
Change-Id: I3331bc0dfae2ccede52b5589b7d3cc443366096a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113424
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 22:21:24 +00:00
dan sinclair 0e780da882 Move vector and matrix to type/. 
This CL moves vector and matrix to type/ and updates the namespaces as
needed.

Bug: tint:1718
Change-Id: I48423b37f15cd69c03ab288143b2d36564789fbf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113423
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 22:21:24 +00:00
Austin Eng 100d4bf339 Reland "Add expectations.txt validation to presubmit" 
This is a reland of commit cde5589953

Original change's description:
> Add expectations.txt validation to presubmit
>
> Change-Id: Ibabdfbdf44b027a6e6441e140f23b2c2488f32dc
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112120
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>

Change-Id: I013eeec03e27b3147023ea094f5bde011561edd1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113540
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Austin Eng <enga@chromium.org>
 2022-12-08 21:57:55 +00:00
Ben Clayton 31090e3096 cts: Fix expectation collisions 
Change-Id: I79ae5afa25dd2bd7ea0bb269212f5228a196319f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113480
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
 2022-12-08 21:53:33 +00:00
Austin Eng 68a74c82c3 Suppress tests failing with Metal backend validation layers 
Bug: dawn:1430
Change-Id: Id8fad88bd5014a2a90e0d580d9df6831dd507b5d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113500
Reviewed-by: Gregg Tavares <gman@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 21:23:56 +00:00
Ben Clayton 5f55990471 tools/cts: Fix expectations update failure 
appendConsumedResultsForSkippedTests() adds fake results for expectations that are 'Skip'ed, so that these sub-trees aren't collapsed as all passing.

However, this code was not handling the fact that there might actually be results for the cases.
This happened because there was an expectation collision in the expectations.txt file, and tests were not being skipped even though there was an expectation with a Skip (a collision expectation was used instead).

Change-Id: I2a1543d231db44dc8aa6683d051f884f4cb96853
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113520
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
 2022-12-08 20:59:01 +00:00
Ben Clayton 06c1af47bd tint: Fix Renamer transform with type short-names 
Fixed: tint:1783
Change-Id: I0ffd5860405651f15961dc8fe753eeac6edc8434
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113441
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-12-08 20:45:54 +00:00
Dawn Autoroller 384e2bee88 Roll SwiftShader from 6f73609d079a to 6ebc3347af9d (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/6f73609d079a..6ebc3347af9d

2022-12-08 swiftshader.regress@gmail.com Regres: Update test lists @ 6f73609d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I8a8117a77b2bf04083b134c2c64f76822074193f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113461
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 20:05:49 +00:00
Dawn Autoroller 293bf3d50b Roll ANGLE from 15ae19c00c77 to 28290e34215a (5 revisions) 
15ae19c00c..28290e3421

2022-12-08 ynovikov@chromium.org Skip Texture2DTestES3.NonZeroBaseEmulatedClear/ES3_Vulkan on Win Intel
2022-12-08 ynovikov@chromium.org Enable tests on Win Intel Optiplex 7080 experimental bot
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0c98167cb31e to 6ebc3347af9d (6 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b1141d77c69a to eb46dc0d0fce (599 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 81e6bda0f261 to b1141d77c69a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I3b0ed43609498da28d734f034a99aa175f010305
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113460
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 19:14:22 +00:00
Ben Clayton d00663d882 tint: Move resolver/type_alias to type/short_name 
'Short-name' is way less overloaded than 'alias' and 'builtin'.

The package move allows transforms to use these enums.

Change-Id: I61c6b3f7deee8e835990a948cd5427c07034fa5e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113440
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
 2022-12-08 19:07:06 +00:00
James Price 04f792de9f tint/transform: Use InsertFront to add attribute 
This is simpler than reconstructing the attribute list and manually
cloning the struct member.

Change-Id: I3d0bd4039030b47e53ce618d9de7ee572b9698f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113422
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 19:01:17 +00:00
James Price 48802bb9ea tint/transform: Remove commented out code 
Change-Id: Ie5fc57bdcc17e4b96173e43e0a230d4f00f58a93
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113421
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
 2022-12-08 19:01:17 +00:00
dan sinclair 4d56b48bbf Move pointer and ref to type/ 
This CL moves the pointer and reference files over to type/ and updates
the namespaces.

Bug: tint:1718
Change-Id: I487a37ef2f6a3884d2ff51af4ac63869c3e03698
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113420
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-12-08 17:50:50 +00:00
Corentin Wallez 92ccab037f Add test for a depth sampling issue. 
Bug: dawn:1187

Change-Id: Ib4187377c6a117b35ca3e77d2f5b8a7a7d07b939
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68944
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
 2022-12-08 17:17:04 +00:00
dan sinclair d37ecf9055 Move scalar types over to type/ folder. 
This CL moves Bool, F16, F32, I32, U32, and Void over to the type folder
and updates namespaces as needed.

Bug: tint:1718
Change-Id: If3056521e5283ac2d9e1fd09c6daf0f647dd3846
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113342
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-12-08 16:39:59 +00:00
David Neto c223ae26ec spirv-reader: support SSign extended instruction 
Fixed: tint:1062
Change-Id: I568f4fad0e5d110d06f2515fde1a31764c65e39a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113320
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: David Neto <dneto@google.com>
 2022-12-08 16:35:49 +00:00
dan sinclair 094ace6f63 Move abstract types to type folder. 
This CL moves the abstract files from sem to type and updates namespaces
as needed.

Bug: tint:1718
Change-Id: I5f0be7e820fc66ea72c1ebe612a6d28034e88be6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113341
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
 2022-12-08 15:33:01 +00:00
dan sinclair 5ee58b60a8 Move sampler to type. 
This CL moves the sampler from sem to type and updates the namespace.

Bug: tint:1718
Change-Id: I22d228df5d24e154dbebecb43e7c6730475e08d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113283
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 15:25:18 +00:00
dan sinclair 4595fb7989 Move texture types to type/ folder. 
This CL moves the texture types into the type folder and namespace.

Bug: tint:1718
Change-Id: I3088e4f8174855043313f4497b384b3947dc6aaf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113282
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
 2022-12-08 14:14:10 +00:00
dan sinclair c9949ac59e Move type_manager to type/ folder 
This CL moves the type_manager from sem to type and updates the
namespace as needed.

Bug: tint:1718
Change-Id: I1fe0c2be08146221e68a9d2e7450283d102afdfa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113280
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-12-08 12:03:53 +00:00
dawn-autoroll 3e14a76425 Roll vulkan-deps from bd21ce27a2a1 to 7935ee7ccbc0 (2 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/bd21ce27a2a1..7935ee7ccbc0

Changed dependencies:
* glslang: 77551c429f..ed257e2bdf
* vulkan-headers: 891c40de1a..b75e5a02b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: Id440851839c7da7e01d3fcd1c3981fa5c7a611c2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113400
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-08 08:48:22 +00:00
Dawn Autoroller 190586048a Roll SwiftShader from fab1949ad09f to 6f73609d079a (4 revisions) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/fab1949ad09f..6f73609d079a

2022-12-07 sugoi@google.com Add missing include <string>
2022-12-07 sugoi@google.com Add early exits for OOB index buffer offset or first index
2022-12-07 sugoi@google.com Fix VK_EXT_graphics_pipeline_library related crash
2022-12-07 sugoi@google.com Fix Regres false crash reports

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I493540e2491c2dea0ba2012568c400f822799bc1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113361
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-08 05:52:34 +00:00
Dawn Autoroller c8803dbbb0 Roll ANGLE from 9dc82cb3ddaa to 15ae19c00c77 (14 revisions) 
9dc82cb3dd..15ae19c00c

2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 716fac091414 to 81e6bda0f261 (2 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1c2e19edc873 to 716fac091414 (3 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a497ee9d6755 to 7935ee7ccbc0 (10 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9edf8e710ec9 to 1c2e19edc873 (5 revisions)
2022-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 998dcf5599d0 to 9edf8e710ec9 (8 revisions)
2022-12-07 chris@rive.app Use typed UAV loads for pixel local storage, when supported
2022-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ee01bc900c32 to 998dcf5599d0 (21 revisions)
2022-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ee01bc900c32 to 17b77809b4ca (1 revision)
2022-12-07 cclao@google.com Vulkan: Remove UsedInRunningCommands
2022-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6a123e5dfc29 to ee01bc900c32 (481 revisions)
2022-12-07 jmadill@chromium.org infra: Remove toolchain from CI dashboard.
2022-12-07 jmadill@chromium.org infra: Remove UBSAN-specific configs.
2022-12-07 jmadill@chromium.org infra: Enable UBSAN together with ASAN and LSAN.
2022-12-07 ynovikov@chromium.org Skip FramebufferExtensionsTest.ColorBufferHalfFloat on iOS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I5d5a1dbcfad7d2ef12b70b72606aa6a54900c79d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113360
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-08 05:10:38 +00:00
Takahiro e536775b40 Distinguish Map request callback fired by device 
Currently Buffer doesn't distinguish Map request callback fired
by device. For example if buffer.MapAsync(), buffer.Unmap(),
and buffer.MapAsync() are called in this order before the first
MapAsync() finishes the MapAsync callback provided by application
for the first MapAsync() is fired when Map request callback
for the first MapAsync() is fired by device although the first
MapAsync callback provided by application shouldn't be fired
because it is already unmapped.

This commit resolves this problem by assigning MapRequestId to
Map request and distinguishing the callback fired by device.

Change-Id: Ic29b02d27cffb254616dc7b48a60151c39f667e2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113222
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
 2022-12-08 04:49:32 +00:00
dan sinclair 5f764d8527 Move type base classes into type/ folder. 
This CL moves sem/type and copies sem/node into the type/ folder. The
type subclasses are moved over to using type::Type while remaining in
the sem:: namespace. They will be moved over in followup CLs.

Bug: tint:1718
Change-Id: I3f3495328d734f88e4fc2dfbc6705343f1198dc5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113180
Reviewed-by: Ben Clayton <bclayton@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-12-08 00:32:27 +00:00
shrekshao ad71dc1ab2 Add validation for pipeline overrides value type error for i32/u32/f32 
Follow WebIDL TypeError for float and EnforceRange. Generate
a validation error is the number is not representable.

Bug: dawn:1597
Change-Id: I9a683f65ed0bfadb936d5de358670b01a2036848
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112920
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
 2022-12-07 23:32:33 +00:00
Ben Clayton 7017ec264c tint: Implement signed-int overloads of sign() 
Bug: tint:1581
Fixed: tint:1782
Change-Id: Ia029bf9d1ce1d978c5cabc3016cb8ad1b4bac06a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113243
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-12-07 19:52:49 +00:00
dawn-autoroll 8e56c8baa7 Roll vulkan-deps from 0c4f620f2412 to bd21ce27a2a1 (6 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/0c4f620f2412..bd21ce27a2a1

Changed dependencies:
* glslang: a7603c132d..77551c429f
* vulkan-validation-layers: 1f2848428c..1e422524e7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I63b9da169fc40267deb93a3bb45239dae8431378
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113225
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-12-07 19:52:29 +00:00
Ben Clayton d839931a37 tint/resolver: Clean up const eval builtin case functions 
Change-Id: I37a687a9831dcae748153a351f631d611d196f50
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113242
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-12-07 19:43:05 +00:00