Ben Clayton
b062bbdce8
Replace TextureType::(Is|As)Sampled with Castable
...
Change-Id: Id997f118a8ce9f4f7c42bed306368d3f204b6607
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34279
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
0441bd1756
Replace TextureType::(Is|As)Multisampled with Castable
...
Change-Id: I9a0e2ba4c6b0950134cef4b291cd1ba5cae1198c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34277
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
8a083ce9c8
Replace Type::(Is|As)Vector with Castable
...
Change-Id: Ic838aa783a279d0939a972773206fee2e33c4bff
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34274
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
d11ced4765
Replace Type::(Is|As)U32 with Castable
...
Change-Id: I4999d45950fdffe4345cf0abae1b026244abba1d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34273
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
38409c79dc
Replace Type::(Is|As)Texture with Castable
...
Change-Id: I53bbccc3e1e7b88ad8c201997cf7e2e485ad9c81
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34272
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
d734dd0c10
Replace Type::(Is|As)Struct with Castable
...
Change-Id: I0bc5645d65d7b53058bda7b343a991a9614741be
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34271
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
d8457c15f1
Replace Type::(Is|As)Matrix with Castable
...
Change-Id: I861aed231604a8bfba1f4cf3659b4863556fc3c4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34268
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
9857f81e94
Replace Type::(Is|As)I32 with Castable
...
Change-Id: Id130581f72e762bd398a4c1c509cdbe21739e750
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34267
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
75f39be976
Replace Type::(Is|As)F32 with Castable
...
Change-Id: I75e5a34034360c1d4c96ae0ce293bc6cbfc1c33d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34266
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
af37c4ae83
Replace Type::(Is|As)Array with Castable
...
Change-Id: I8d9b916f5977121380325d373c4e2f805b691fae
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34264
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
a8d87788da
Replace Type::(Is|As)AccessControl with Castable
...
Change-Id: I833c92be270236fefd1e77a7a145dede757e93e9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34262
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-30 23:30:58 +00:00
Ben Clayton
4bfe461646
Big cleanup now that AST nodes are raw pointers
...
Remove all redundant std::move()s. I've also removed calls to
std::move() in tests, even if they act as an optimization. This is for
two reasons:
(a) Performance is not important for testing, and this helps with
readability.
(b) A whole bunch tests were relying on std::move() clearing vectors so
they can be repopulated and used again. This is undefined behavior:
> Objects of types defined in the C++ standard library may be moved from
> (12.8). Move operations may be explicitly specified or implicitly
> generated. Unless otherwise specified, such moved-from objects shall
> be placed in a valid but unspecified state.
All of these UB cases have been fixed.
Removed all duplicate variables left over from:
`auto* foo_ptr = foo.get()`
which became:
`auto* foo_ptr = foo`
Bug: tint:322
Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900
Commit-Queue: Ben Clayton <bclayton@google.com >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-16 16:41:47 +00:00
Ben Clayton
b053acf796
Replace use of std::unique_ptr<T> with T* for AST nodes
...
This is a minimal effort to fix up the code. There's substantial code
cleanup which can now be done, which is done in the next change.
Bug: tint:322
Change-Id: Iafcf5e814837d9534889e8c21333de4931a19cfa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32864
Commit-Queue: dan sinclair <dsinclair@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-16 16:31:07 +00:00
dan sinclair
196e097730
Place the namer into the context object.
...
This CL moves the namer into the context object and makes it a parameter
to the various generators. The old constructor is maintained until we've
updated downstream repos.
Bug: tint:273
Change-Id: I49b2519c4250be21fb73374b16e7c702b727078f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32580
Commit-Queue: dan sinclair <dsinclair@chromium.org >
Reviewed-by: David Neto <dneto@google.com >
2020-11-13 18:13:24 +00:00
Ryan Harrison
8ca4561b25
[inspector] Add Multisampled Texture data extraction
...
BUG=tint:257
Change-Id: I3feff89822762014e12e098f00474484139f83c9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32382
Commit-Queue: David Neto <dneto@google.com >
Reviewed-by: David Neto <dneto@google.com >
2020-11-12 21:50:50 +00:00
Ryan Harrison
1980095da7
[inspector] Convert GetRemapped to be a pass through
...
This is a temporary fix to get Tint rolling into Dawn again and will
be removed in a future patch.
BUG=tint:273
Change-Id: I632e71711146eb4055f46c1bebfbd6d3ff5772fa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32520
Reviewed-by: dan sinclair <dsinclair@chromium.org >
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
2020-11-12 15:43:00 +00:00
Ryan Harrison
2b706110f6
[inspector] Add better support for remapped entry point names
...
Add remapped_name to entry point structure, also supply method to find
the remapped name for individual entry points.
BUG=tint:312
Change-Id: I5f2cc02bc37c17e99c453b16108bc8e10c602fba
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32383
Reviewed-by: dan sinclair <dsinclair@chromium.org >
Reviewed-by: Austin Eng <enga@chromium.org >
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
2020-11-11 21:35:36 +00:00
Ryan Harrison
dbcc1e0e80
[inspector] Extract Sampled Texture data
...
BUG=tint:257
Change-Id: I146591d052edfc959df33ccf235ea466cb59e59d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32260
Reviewed-by: dan sinclair <dsinclair@chromium.org >
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
2020-11-10 22:30:56 +00:00
dan sinclair
84f827506a
[spirv-writer] Hash names
...
This Cl hashes the OpName, OpEntryPoint and OpMemberName strings so we
are no longer passing user provided strings through into the resulting
SPIR-V binary.
Bug: tint:273
Change-Id: I0ca2c65d0cd2800c54d867ab698c7751c341778c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32061
Commit-Queue: dan sinclair <dsinclair@chromium.org >
Reviewed-by: David Neto <dneto@google.com >
2020-11-10 21:49:56 +00:00
Ryan Harrison
110af53089
[inspector] Extract ComparisonSampler resource binding information
...
Adds in method to get resource binding information for comparison
samplers along with tests.
BUG=tint:257
Change-Id: I60f675347d2b9596308b1599d0a9b846615d547e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31980
Commit-Queue: David Neto <dneto@google.com >
Reviewed-by: David Neto <dneto@google.com >
2020-11-06 17:53:45 +00:00
Ryan Harrison
cc2305dd95
[inspector] Extract Sampler resource binding information
...
Adds in method to get resource binding information for non-comparison
samplers along with tests. Additionally some of the infrastructure for
implementing an equivalent comparison sampler code path is included.
BUG=tint:257
Change-Id: I5775bbd6233e1014bea54c5281d460544ab8383d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31920
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-05 20:09:50 +00:00
Ryan Harrison
77f7bb5b00
[inspector] Refactor to handle access control wrapped uniform-buffers
...
Updates the extraction code to assume that the StructType will be
wrapped by an AccessControlType. Tests are changed to match this
behaviour, and some minor naming clean up occured.
BUG=tint:257
Change-Id: I888ac2fae228531e956437afb937082a142d5736
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31780
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
Commit-Queue: dan sinclair <dsinclair@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-04 16:08:00 +00:00
Ryan Harrison
e862fde45c
[inspector] Extract Read Only Storage Buffer data
...
BUG=tint:257
Change-Id: Ie9486726b2a164971d720f4496a87a0bd118ebde
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31760
Reviewed-by: dan sinclair <dsinclair@chromium.org >
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
2020-11-03 22:19:50 +00:00
Ryan Harrison
a28d19b18d
Add tests for MinBufferBindingSize
...
BUG=tint:283
Change-Id: Id198175d232680ca89e04561b8b7510f41d982f7
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31106
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-11-03 16:53:59 +00:00
dan sinclair
d5fd7e02ba
Fixup lint errors.
...
This CL fixes up the various lint errors.
Change-Id: If4d3077b55aadec33980452c43917194d803fac6
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31680
Reviewed-by: Ben Clayton <bclayton@google.com >
Reviewed-by: Ryan Harrison <rharrison@chromium.org >
Commit-Queue: dan sinclair <dsinclair@chromium.org >
2020-11-03 16:26:09 +00:00
Ryan Harrison
fcbc6efa8f
[inspector] Extract storage-buffer information
...
BUG=tint:257
Change-Id: Ib85d76a3b972226b401e57ba2a632d6252e95f8f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31080
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-10-27 18:03:09 +00:00
Ryan Harrison
88d705dc85
[inspector] Extract UBO information
...
Also includes adding in sizing information for various types.
BUG=tint:257
Change-Id: Iaaa8a7c28851d14790285b5bd14636bf3ae2b9b0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/30704
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
Commit-Queue: dan sinclair <dsinclair@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-10-22 19:31:31 +00:00
Ryan Harrison
8904253837
Add getting constant ID information from Inspector
...
This also involves a reorganization of the code into its own
subdirectory.
BUG=tint:253
Change-Id: If05018da2662e923e659b485576704f3a6bcd062
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/30340
Commit-Queue: Ryan Harrison <rharrison@chromium.org >
Reviewed-by: dan sinclair <dsinclair@chromium.org >
2020-10-16 02:26:54 +00:00