Commit Graph

10119 Commits

Author SHA1 Message Date
Dawn Autoroller 3c7171485c Roll ANGLE from c7306ecddbe0 to 818a8ace5ef9 (7 revisions)
c7306ecddb..818a8ace5e

2022-09-26 geofflang@chromium.org Revert "Vulkan: Add missing part for supporting GBM Platform type"
2022-09-26 penghuang@chromium.org Fix CFI problem in SystemInfo_vulkan.cpp
2022-09-26 romanl@google.com Cleanup: simplify merge_bps.
2022-09-26 geofflang@google.com Metal: Remove unpackLastRowSeparatelyForPaddingInclusion
2022-09-26 geofflang@google.com Metal: Avoid locking IOSurfaces in glReadPixels on AMD.
2022-09-26 romanl@google.com Cleanup: readability and make --genAndroidBp non-destructive.
2022-09-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0dd58092b204 to 4f495efb55d4 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I743edb94c8bef42978ece08c0e96cfa73114ad25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103920
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-26 23:54:15 +00:00
Antonio Maiorano 4bffb56cca tint: Fix failing e2e tests due to updated spirv-val
These were marked as SKIP a couple months ago when vulkan-deps were
updated, and our spir-v reader started failing (see
https://dawn-review.googlesource.com/c/dawn/+/98020).

Change-Id: I1206fd5a941b38f00094ab00d0675cd46df77adf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103821
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-26 20:21:25 +00:00
dan sinclair cb41b8f97f Convert `align` attribute to expressions.
This CL updates the align attribute to parse expressions.

Bug: tint:1633
Change-Id: I5412180ff62e6b286b35ea3297e2b4f136899960
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102841
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-09-26 15:54:55 +00:00
Antonio Maiorano 5b0bab84be tint/fxc: regen e2e tests that are not actual FXC timeouts
- write-before-break/0-opt.wgsl/spvasm compiles correctly and quickly.
- cov-multiple-one-iteration-loops-global-counter-write-matrices\0-opt.wgsl/spvasm fails with a different FXC error.

Change-Id: Ic0d57494bac8d4ca423fbdcd7bca7e918935b522
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103761
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-09-26 15:17:45 +00:00
Antonio Maiorano f56d8954e3 tint/fxc: delete and regen skips for e2e tests to capture FXC error messages in expected file
Helps with triaging.

Change-Id: I596fb33d9d60e2e364175cdd0ff1966f71423e99
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103640
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-26 14:24:35 +00:00
Ben Clayton 4c70d7fff2 tint: Make uniformity analysis failures a hard error
These have been warnings for multiple months.
Time to properly turn this on.

Bug: tint:880
Change-Id: I3b38f672309b5acd48c12a38dc5a1675f3c62470
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103480
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-09-26 12:30:05 +00:00
Corentin Wallez 03199c2b44 Protect against aspectReadOnly of unused DS attachements aspects
Unused aspects of depth-stencil attachments that are tagged as read-only
used to leak that read-only state to backends, even if the validation
made it seems like they always match (they only need to match if the
texture has both aspects). This confused backends like Vulkan which
checked for depthReadOnly || stencilReadOnly to choose between code
paths.

Instead reyify the depthStencilAttachement descriptor in the frontend to
protect against garbage values being passed for aspects that aren't
present in the texture.

Adds a regression test, with the caveat that a failure is only shown by
having the VVL output and error in stderr due to an unrelated issue.

Fixed: dawn:1512
Change-Id: I35d5581e46909b7f41ff4c7553d60c6ac844a56b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101121
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-26 11:13:35 +00:00
Corentin Wallez ab882c17a5 Vulkan: Fix incorrect barriers for T2T copies of DS.
T2T copies for depth-stencil formats where done one by one. Because
the two per-aspect copies where submitted with no barriers in between
them, incorrect synchronization could occur, making the end state of the
destination texture incorrect.

Fix this by using the combined aspects of the texture to perform copies,
such that depth stencil are copied in a single command instead of two
commands.

Unfortunately the VVLs don't catch this issue, but the reporter of the
issue confirmed that this commit fix the dawn_end2end_tests failures
they were seeing.

Fixed: dawn:1514
Change-Id: I2e1c5f8d9aabeb0119364d26c9d66d0763cfadcf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103421
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
2022-09-26 11:07:25 +00:00
Dawn Autoroller d811edd94b Roll ANGLE from 2aa52da7e4c3 to c7306ecddbe0 (1 revision)
2aa52da7e4..c7306ecddb

2022-09-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c4be4c7e0a43 to 73f358f3727f (154 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I4b622b353c6eaa743f2fa624fc41f13bcc644e9d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-26 10:31:05 +00:00
Dawn Autoroller c0a89492cc Roll ANGLE from b59609c5649b to 2aa52da7e4c3 (1 revision)
b59609c564..2aa52da7e4

2022-09-25 geofflang@google.com Metal: Upload IOSurface data with staging buffers on AMD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I7e882fa0b637978138e1a1d52006ceb73f906afa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103720
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-25 12:32:34 +00:00
Dawn Autoroller 6ab95781c3 Roll ANGLE from 1fc6c49c4a06 to b59609c5649b (1 revision)
1fc6c49c4a..b59609c564

2022-09-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a63c34f9ead3 to c4be4c7e0a43 (867 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: Ib957b0dd49282d77fd03c4acbe09e90d2c3b47f7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103700
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-24 23:03:54 +00:00
Ben Clayton 34aed5db41 Roll third_party/webgpu-cts/ 0fee76f32..deb4ba9f3 (12 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


0fee76f32e..deb4ba9f33
 - deb4ba wgsl: Remove gradients_in_varying_loop tests
 - e84b11 Add 'render_pass_and_bundle,device_mismatch' test to attachment_compatibility.spec.ts (#1858)
 - cca406 webgpu/shader/execution: More tightly scope validation to batches
 - 2e8bb0 webgpu/shader/execution: Reduce `const` case batch size
 - 042ae7 wgsl: Fix emission of f32 and f16 infinities. (#1862)
 - 050429 Update canvas_composite_alpha to test opaque alpha mode canvas composite (#1856)
 - 2a4dfd Update 'multisampled_validation' test in createBindGroupLayout.spec.ts (#1777)
 - b09c17 Update texture_must_have_correct_dimension test to handle storageTexture as well (#1851)
 - 09db86 Add a doc about Floating Point math as background on numeric testing (#1847)
 - 0860ad Update align tests for const expressions. (#1854)
 - e77a9f Implement  test in operation/rendering/blending.spec.ts (#1845)
 - 46e737 Update multisampled_validation test to check the sampleType as well (#1850)

Created with './tools/run cts roll'

Change-Id: Ic58d621db0aab0c847cf30deddb07b5108c466b6
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103600
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-09-24 18:36:24 +00:00
Dawn Autoroller b77e651f01 Roll ANGLE from 7d82f62a2bf8 to 1fc6c49c4a06 (10 revisions)
7d82f62a2b..1fc6c49c4a

2022-09-24 romanl@google.com Log additional info when "failed to record some samples"
2022-09-24 pkasting@chromium.org Roll third_party/jsoncpp.
2022-09-24 syoussefi@chromium.org GLES1/Vulkan: Enable GL_EXT_multisample_compatibility
2022-09-24 syoussefi@chromium.org GLES1: Move lighting to vertex shader
2022-09-24 sywow.choi@samsung.com Vulkan: Add missing part for supporting GBM Platform type
2022-09-24 syoussefi@chromium.org GLES1: Fix material color update when COLOR_MATERIAL
2022-09-24 penghuang@chromium.org Add driverApiVersion in GPUDeviceInfo
2022-09-23 djg@apple.com EGL: Implement eglCopyMetalSharedEventANGLE
2022-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c9e298759959 to 9af2b2b2ef97 (1 revision)
2022-09-23 cnorthrop@google.com Tests: Add Eve Echoes trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: Ib53ed5fe1cf9549bc0d065091cfd74207b8f9ed0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103543
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-24 10:07:57 +00:00
Antonio Maiorano 5f33facbc1 tint: const eval of binary left shift
Bug: tint:1581
Change-Id: I8c1b01bcae2a205e712b8004573cc26a3366785a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103061
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-23 21:58:29 +00:00
Dawn Autoroller b46c6d7c1d Roll ANGLE from 5d15e9c65433 to 7d82f62a2bf8 (2 revisions)
5d15e9c654..7d82f62a2b

2022-09-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bd8f8a8fc544 to 0dd58092b204 (1 revision)
2022-09-23 syoussefi@chromium.org Automatically query status of features for tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I6b9324b81a2a3cf5612339ce614743116ef04d00
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103541
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-23 17:27:47 +00:00
Yunchao He ef6696089d D3D12 Intel: change the driver version for array texture corruption issue
The previous driver version I got from Intel driver team is
not correct. That driver does contain the fix but it is not the
first version with the fix.

Bug: dawn:949, dawn:1507

Change-Id: I0044a181e4266b50f77734bbbf9cc8755a8334d9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103502
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-23 16:03:37 +00:00
Corentin Wallez 05e7332ac8 Rework how combined aspects are handled in TextureVk
At the moment the computations to decide whether aspects should be
combined are executed on every call related to aspect in TextureVk.
These computations never change and can be computed once at the creation
of TextureVk and reused at runtime.

This is meant to be a noop change as a slight rework prior to fixing
depth-stencil T2T copies no using the combined aspects.

Bug: dawn:1514

Change-Id: I1177cdcf42d072bb2bc2c3a2f149dc480fe79f2f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103420
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-23 09:56:06 +00:00
Dawn Autoroller e9a245e5cc Roll ANGLE from 0d34d4f8810a to 5d15e9c65433 (7 revisions)
0d34d4f881..5d15e9c654

2022-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 90c58209c2e3 to c9e298759959 (2 revisions)
2022-09-22 gman@chromium.org Metal: ProvokingVertexHelper stop using a separate cmdbuffer
2022-09-22 hob@chromium.org Avoid ANGLE formats on dmabuf-backed EGL images
2022-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a373f5689ff to 90c58209c2e3 (3 revisions)
2022-09-22 jmadill@chromium.org Android Test Runner: Skip APK install if hash matches.
2022-09-22 sharma.loic@gmail.com Make astc_encoder optional
2022-09-22 constantine.shablya@collabora.com Stubs for paletted images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I6a3bd194642d2b3b2151f5a993dea77534375869
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103540
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-23 03:54:56 +00:00
Sunny Sachanandani 85e6337027 d3d12: Move NextSerial out of ExecuteCommandList
Reverts to the code flow before fences were implemented. NextSerial is
now the reponsibility of the caller of ExecutePendingCommandContext like
it was before. We now use GetPendingCommandSerial to store the signal
fence value instead of GetLastSubmittedCommandSerial and check that the
signal fence value was submitted in EndAccess.

Bug: dawn:576
Change-Id: I616840a0932ec17f77fcab38058773006dfae32f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103501
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-23 00:52:56 +00:00
Jiawei Shao 5a0f8d32a2 Support optional query on adapter power preference
This patch adds DawnAdapterPropertiesPowerPreferenceDescriptor for
querying adapter power preference which is useful to distinguish
different logical adapters created on same physical device but with
different power preferences.

Bug: dawn:1516
Test: dawn_unittests
Change-Id: I12ed6e370f8b57c860520154565765f0ee894831
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102780
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-09-23 00:29:46 +00:00
Loko Kung 3354bf0d91 Add cleanup when encoding indirect draw validations.
- Cleanup is necessary because otherwise encoded render commands may be
  leaked if the validation encoding fails. (The leaked render commands
  can then trigger an assert in ~Device::Cache because the commands can
  hold a ref to an AttachmentState that was not destroyed, and hence
  still be in the device cache.
- Added explicit check in EncoderIndirectDrawValidationCommands for
  device 'alive-ness' since it may create new objects later and hit the
  same error later on anyways.
- Added regression test.

Fixed: chromium:1365011
Change-Id: I342479a4227fc43d82ea35f662d049e6db2b1740
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103340
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-22 23:45:36 +00:00
Ben Clayton c4ebf2cc57 tint: Implement textureSampleBaseClampToEdge
Fixed: tint:1671
Change-Id: Iaae5b5d571a4401c0255de727245bf8dbbe06740
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102642
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-09-22 22:59:16 +00:00
dan sinclair 78f8067fd5 Fix overrides in array size.
This CL fixes the usage of overrides in array sizes. Currently
the usage will generate a validation error as we check that the
array size is const.

Bug: tint:1660
Change-Id: Ibf440905c30a73b581d55b0c071b8621b61605e6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101900
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: dan sinclair <dsinclair@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-09-22 22:28:21 +00:00
Austin Eng 534a198f88 Validate that the device is alive when wrapping external images
Will be tested in Chromium's webgpu_mailbox_unittest.cc

Bug: chromium:1359106
Change-Id: I8a9bf01cd593f2835e2876fa04139fd3afda9b2e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103462
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-22 22:10:56 +00:00
Takahiro d4dd547bae Implement "rg11b10ufloat-renderable" feature
Implement "rg11b10ufloat-renderable" feature that allows
the RENDER_ATTACHMENT usage on textures with format
"rg11b10ufloat", and also allows textures of that format
to be multisampled.

Bug: dawn:1518
Change-Id: I4109dc0e9d90f4c0803219292edea554927a187a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102000
Commit-Queue: Takahiro <hogehoge@gachapin.jp>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-22 16:38:06 +00:00
Dawn Autoroller 00093a35b7 Roll ANGLE from 3700a05997b6 to 0d34d4f8810a (5 revisions)
3700a05997..0d34d4f881

2022-09-22 abdolrashidi@google.com Suppress more VVL errors about vkCmdDraw*-None
2022-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 495c41ce34af to bd8f8a8fc544 (2 revisions)
2022-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2c406fc99b42 to a63c34f9ead3 (560 revisions)
2022-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 13962002fdf0 to 3a373f5689ff (20 revisions)
2022-09-22 penghuang@chromium.org Fix crash in vkGetPhysicalDeviceProperties2()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: Iaf7d5811d8ef0298863ecc8590371b36a9c835e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103363
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-22 14:48:25 +00:00
Li Hao cbd3ef4bb9 Suppress TimestampQueryTests.ResolveTwiceToSameBuffer/D3D12 on Intel Gen12
This is a D3D driver regression on Intel Gen12 GPUs, the test could pass
on old driver version and pass with disable_timestamp_query_conversion
toggle on latest driver.

Bug: dawn:1546
Change-Id: I8cf63824d5147bb78f53a284cada8efdc653a3ce
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103380
Commit-Queue: Hao Li <hao.x.li@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-22 09:52:35 +00:00
Dawn Autoroller 1a27c55aa5 Roll ANGLE from bc33b1584ff3 to 3700a05997b6 (15 revisions)
bc33b1584f..3700a05997

2022-09-22 gman@chromium.org Revert "Add ReadPixels Perf Test"
2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7d70d765a648 to 13962002fdf0 (7 revisions)
2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d9371f187fcc to 7d70d765a648 (1 revision)
2022-09-21 chris@rive.app Implement the ANGLE_shader_pixel_local_storage API
2022-09-21 sharma.loic@gmail.com Only close COM if it was initialized
2022-09-21 syoussefi@chromium.org GLES1: Enable PointAntiAlias and RescaleNormal tests
2022-09-21 syoussefi@chromium.org GLES1: Fix behavior with incomplete mipmap textures
2022-09-21 abdolrashidi@google.com Suppress VVL error about vkCmdDraw-None
2022-09-21 robert.mader@collabora.com EGL: Implement EGL_EXT_image_dma_buf_import_modifiers
2022-09-21 syoussefi@chromium.org Vulkan: Fix validation error with unset-logic-op in UtilsVk
2022-09-21 abdolrashidi@google.com Suppress VVL error about input attachment desc
2022-09-21 gman@chromium.org Add ReadPixels Perf Test
2022-09-21 ynovikov@chromium.org End Mac 12.5.1 qualification for ANGLE on Intel
2022-09-21 lubosz.sarnecki@collabora.com FrameCapture: Capture Texture Environment in MEC.
2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b405d5dd04c4 to 495c41ce34af (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I977c5854c1a4e277ef3fdb8ec0762fe434accd1d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103362
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-22 01:50:35 +00:00
dawn-autoroll 50447f602a Roll vulkan-deps from 90c58209c2e3 to ab0162f25025 (10 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/90c58209c2e3..ab0162f25025

Changed dependencies:
* glslang: b40f87f1d3..8243ca3c30
* spirv-cross: adf0995bb9..ddaa2da629
* spirv-headers: 87d5b782be..4bd8fc0c8c
* spirv-tools: 11d0d16227..f98473ceeb
* vulkan-validation-layers: 8e2c50886a..db7cc3d338

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I258b1963bc6ce1ed433b788e259d210e6e1756a5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103341
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-22 00:55:45 +00:00
Austin Eng 9087a5c28d Revert "Update WebGPU expectations.txt"
This reverts commit 8b7a83b85e.

Reason for revert: Failing Dawn->Chromium roll
https://chromium-review.googlesource.com/c/chromium/src/+/3911684/

Original change's description:
> Update WebGPU expectations.txt
>
> Bug: chromium:1344876, chromium:1359106, dawn:1250
> Change-Id: I80aedd357f3e067064bc0c7c73c83036cb5c3b4c
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103301
> Reviewed-by: Loko Kung <lokokung@google.com>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>

TBR=enga@chromium.org,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com

Change-Id: Ie41d2f43f9e6372b076acff9f0bbc28f18d673c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1344876, chromium:1359106, dawn:1250
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103342
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-09-21 23:46:35 +00:00
Austin Eng 8b7a83b85e Update WebGPU expectations.txt
Bug: chromium:1344876, chromium:1359106, dawn:1250
Change-Id: I80aedd357f3e067064bc0c7c73c83036cb5c3b4c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103301
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-21 21:30:35 +00:00
Ben Clayton 490d9889a7 tint: Simplify workgroup size resolving
A `@workgroup_size()` value must be a constant or override expression.
There's nothing specific here about literals or variable expressions.

Remove the semantic tracking of override variables, as these can be override expressions.
The backends will require the `SubstituteOverride` transform to be run, so gut the workgroup_size override handling from the backends.

Bug: tint:1633
Change-Id: Ib3ff843fc64a3595d49223c661b4d58130c0ab30
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100142
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-09-21 21:05:45 +00:00
Austin Eng 45a2c5193a Return false from IsTextureSubresourceInitialized for error textures
Otherwise, callers of this method will hit an ASSERT for error
textures.

Bug: chromium:1359106
Change-Id: I2602d209d837b3b27916221578f9ac4041f8848b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103281
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-21 20:18:30 +00:00
Kenneth Russell 417acaf650 Temporarily disable dawn_use_angle on Android.
It's adding dependencies on ANGLE's libEGL.so and libGLESv2.so which
Chromium's linker on Android doesn't allow. Temporarily disable it
(and, implicitly, WebGPU/Compat) in order to get Dawn's unit and
end2end tests running on the CI bots while this is investigated.

Bug: dawn:286
Bug: dawn:1545
Change-Id: Idd35c4e2b95454dca3faf9c522c028e0ff129e55
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103300
Reviewed-by: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kenneth Russell <kbr@google.com>
2022-09-21 19:17:16 +00:00
Ben Clayton f92830b623 dawn: Enable OpenGLBackend for ComputeLayoutMemoryBufferTests
The layout issues should now be fixed with the Std140 transform.

Bug: dawn:942
Change-Id: I714c2edb39f27b39f66c1e913f22232ad7908896
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103000
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-09-21 18:13:14 +00:00
Brandon Jones 773800b68d Reland "Implement maxBindingsPerBindGroup limit"
This is a reland of commit 4d67a883b6
Underlying issue fixed in https://dawn-review.googlesource.com/c/dawn/+/102461

Original change's description:
> Implement maxBindingsPerBindGroup limit
>
> Bug: dawn:1523
> Change-Id: Ifcf83f6836a5d7ed447080ccb033e4163970432e
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100706
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Brandon Jones <bajones@chromium.org>

Bug: dawn:1523
Change-Id: If0824b6f8fcb7c152feceb95a2709d0a3b8ce582
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103280
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-21 17:42:24 +00:00
Ben Clayton f2c1d0aa5b tint: Add test cases for tint:1666
This change does not attempt to fix this issue.

Bug: tint:1665
Bug: tint:1666
Change-Id: I9b40a25279b939977c826f38592518b6b086c06b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101161
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-09-21 17:19:04 +00:00
Ben Clayton 4953dabab7 dawn/tests: Remove OverridesWithZeroDefault test
It's not invalid to have create a shader module using zero-defaulted `override`s as workgroup size parameters.
These can be initialized with non-zero pipeline override values.

Bug: dawn:1504
Change-Id: I2636cbe2d26a6604735b0c8b0f5526bbc14e8ce2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103220
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-21 16:42:34 +00:00
Zhaoming Jiang 849dff2ada Expectation: Clean up built-in constant evaluation and timestampWrites
This CL organizes the expectation of new added built-in constant
evaluation and timestampWrties test cases.

Bug: dawn:1250, tint:1613
Change-Id: I380129098873a543aeb72b1d4b8973ae92465c19
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102108
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-21 14:49:14 +00:00
dan sinclair 1662f5578e Fixup some grammar.
This Cl updates some double negative grammar to be a bit more readable.

Change-Id: Id5d9c64acc1dd8422b8116d8a6c1bf149f99e592
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103260
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-09-21 14:44:33 +00:00
Ben Clayton 05f3891eb6 go.mod: Pin github.com/sergi/go-diff to v1.1.0
v1.2.0 has a severe bug, causing some diffs to be garbage. See https://github.com/sergi/go-diff/issues/123

Change-Id: I64d98c178db746a726a0354e699c5e50e9715d5e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103240
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-09-21 14:12:33 +00:00
Ben Clayton 4d8fa43663 docs/tint: Fix OT notes.
Move notes in M106 which should have been in a new M107 section.

Change-Id: Id3cbe39b4889054d3b23202fb0da1d85afbab48b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103200
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-09-21 13:20:13 +00:00
Dawn Autoroller 4e40f0ed59 Roll ANGLE from 7353de23153a to bc33b1584ff3 (13 revisions)
7353de2315..bc33b1584f

2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a34a3f07bf17 to 2c406fc99b42 (426 revisions)
2022-09-21 syoussefi@chromium.org GLES1: Implement logic op through framebuffer fetch
2022-09-21 cnorthrop@google.com FrameCapture: Ignore GetActiveAttrib
2022-09-21 cnorthrop@google.com FrameCapture: Improve renderbuffer reset
2022-09-21 constantine.shablya@collabora.com Add GLES 1.x lighting tests
2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c8b930c34ad9 to d9371f187fcc (1 revision)
2022-09-21 djg@apple.com EGL: Implement ANGLE_metal_shared_event_sync on metal
2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fc6a5c804833 to c8b930c34ad9 (1 revision)
2022-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3811e73c4b6f to fc6a5c804833 (1 revision)
2022-09-20 penghuang@chromium.org Handle Mesa llvmpipe in GetSystemInfoVulkanWithICD
2022-09-20 syoussefi@chromium.org GLES1: Fix Fog rendering
2022-09-20 j.vigil@samsung.com Vulkan: Fix native ID for GBM configs
2022-09-20 syoussefi@chromium.org GLES1: Implement logic op through ANGLE_logic_op

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I266f47bf85224357aac26f1fd1f0bcd34f0febf5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103180
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-21 11:03:22 +00:00
dawn-autoroll a20b970cfb Roll vulkan-deps from 3a373f5689ff to 90c58209c2e3 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3a373f5689ff..90c58209c2e3

Changed dependencies:
* spirv-tools: 91c29a197f..11d0d16227
* vulkan-validation-layers: 5f9b0a44e9..8e2c50886a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: Iea258030cc4911e24d0397208e833c8f5ab0315a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103140
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-21 10:57:03 +00:00
Dawn Autoroller eb7e66147c Roll ANGLE from 8181116607c9 to 7353de23153a (8 revisions)
8181116607..7353de2315

2022-09-20 romanl@google.com Use python3 instead of python (python2 on skia roller)
2022-09-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bf1e383b4aa1 to a34a3f07bf17 (1216 revisions)
2022-09-20 penghuang@chromium.org Collect vulkan driverID with GetSystemInfoVulkan()
2022-09-20 syoussefi@chromium.org Vulkan: Remove static variable from DisplayVkLinux::queryDmaBufFormats
2022-09-20 syoussefi@chromium.org Infra: Run GLES1 conformance tests on Pixel 4 bots
2022-09-20 shaobo.yan@intel.com Remove extra '# if defined(ANGLE_PLATFORM_WINDOWS)'
2022-09-20 syoussefi@chromium.org Vulkan: Implement GL_ANGLE_logic_op
2022-09-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9e96423f7ed2 to b405d5dd04c4 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I797ceb1158cd21599b3764df59d1b13e966b1786
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103080
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-20 21:43:02 +00:00
dawn-autoroll 139f938477 Roll vulkan-deps from c35160c4b19d to 3a373f5689ff (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/c35160c4b19d..3a373f5689ff

Changed dependencies:
* glslang: c0cf8ad876..b40f87f1d3
* spirv-cross: 1ad6006130..adf0995bb9
* vulkan-validation-layers: 5531a09308..5f9b0a44e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I2984298bece976ab9e531af0e38554b33da3dc2d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103060
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-20 21:00:02 +00:00
Ben Clayton 7fe75f4a68 expectations.txt: Remove inputSource="const" [ Skip ] expectations
The new heartbeat logic can now detect that these are just slow, and no longer trigger the timeout failures.

Fixed: tint:1613
Change-Id: I2e29b0e2b7002f29984841ed4f421ec6e47be83f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102960
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-20 20:34:04 +00:00
Corentin Wallez 30f51b94da Delete the remove_stale_autogen_files mechanism.
Previously when moving around directories for generated files, Dawn ran
into an issue where stale files where #included instead of the new ones,
causing compilation failures. To get around this a
remove_stale_autogen_files mechanism was added that scans the gen/
directory for files not in an allow-list of directories.

This mechanism is now causing problems for bringing up Dawn standalone
tests on Android as these test also generate files in Dawn's gen/
directories, and their files get deleted by remove_stale_autogen_files.

We are not foresseing any additional shuffling of directories and it's
safe to expect that all stale files have been removed from CI builder
caches at this time. So remove_stale_autogen_files can go. This is what
this CL does.

Fixed: dawn:1543
Change-Id: I7dbf1eae6c55b7659f3837b6d4a565052001ce57
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103040
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-20 17:28:33 +00:00
Corentin Wallez eebb7d5e52 Fix leak of the eager exportable VkSemaphore.
Exporting an exportable VkSemaphore doesn't implicitly destroy the
VkSemaphore object. So instead of Detach()ing the VkSemaphore when it is
first consumed, just let it go out of the scope and be destroyed with
RAII. This also fixes the RAII by not destroying the VkSemaphore
immediately and instead wait until it becomes unused.

Found by running dawn_end2end_tests with the VVLs.

Bug: chromium:1258986
Change-Id: I858839b3094eee0f575c07a8f18504680afb53e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103024
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-20 17:02:32 +00:00
Corentin Wallez 1d100e4270 Dedent OnDebugUtilsCallback
While trying to debug why VVL failures don't cause test failures I
reworked this code a little bit. There is not CL that fixes the
behavior, but the code is marginally better with less indentation so
here's a CL to check that in.

Bug: None
Change-Id: I6fc460c4b4b7959ae405219615a03230bfb9847a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103022
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-20 16:01:31 +00:00