mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-10-28 12:39:52 +00:00
642009261e
This is a reland of 96c4019214e0b2d7c0843eacf96398a6a1198d1f It includes a fix to add a dummy descriptor count if the VkDescriptorPool would be empty, and adds a test that a bind group with an empty bind group layout may be created and used. Original change's description: > Slab-allocate VkDescriptorSets > > This introduces a slab allocator for VkDescriptorSets which creates > a VkDescriptorPool pre-allocated with multiple VkDescriptorSets per > BindGroupLayout. In the future, we can deduplicate pools that have > the same, or roughly the same, descriptor counts. > > This CL also removes the old DescriptorSetService and moves most of > the functionality onto the DescriptorSetAllocator itself to keep > the tracking logic in one place. > > Bug: dawn:340 > Change-Id: I785b17f4353fb3d40c9ccc33746600d6794efe7c > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19320 > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> Bug: dawn:340 Change-Id: Iabb744f110d0cab442bb857b31c87ba46bf0ad7a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20321 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
51 lines
1.7 KiB
C++
51 lines
1.7 KiB
C++
// Copyright 2018 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef DAWNNATIVE_VULKAN_BINDGROUPVK_H_
|
|
#define DAWNNATIVE_VULKAN_BINDGROUPVK_H_
|
|
|
|
#include "dawn_native/BindGroup.h"
|
|
|
|
#include "common/PlacementAllocated.h"
|
|
#include "common/vulkan_platform.h"
|
|
#include "dawn_native/vulkan/BindGroupLayoutVk.h"
|
|
#include "dawn_native/vulkan/DescriptorSetAllocation.h"
|
|
|
|
namespace dawn_native { namespace vulkan {
|
|
|
|
class Device;
|
|
|
|
class BindGroup final : public BindGroupBase, public PlacementAllocated {
|
|
public:
|
|
static ResultOrError<BindGroup*> Create(Device* device,
|
|
const BindGroupDescriptor* descriptor);
|
|
|
|
BindGroup(Device* device,
|
|
const BindGroupDescriptor* descriptor,
|
|
DescriptorSetAllocation descriptorSetAllocation);
|
|
|
|
VkDescriptorSet GetHandle() const;
|
|
|
|
private:
|
|
~BindGroup() override;
|
|
|
|
// The descriptor set in this allocation outlives the BindGroup because it is owned by
|
|
// the BindGroupLayout which is referenced by the BindGroup.
|
|
DescriptorSetAllocation mDescriptorSetAllocation;
|
|
};
|
|
|
|
}} // namespace dawn_native::vulkan
|
|
|
|
#endif // DAWNNATIVE_VULKAN_BINDGROUPVK_H_
|