mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-02 10:15:50 +00:00
Only load extension entry points if the extension is supported. From the eglGetProcAddress manpage: "A non-NULL return value does not guarantee that an extension function is actually supported at runtime. The client must also make a corresponding query, such as glGetString(GL_EXTENSIONS) for OpenGL and OpenGL ES extensions [...] to determine if a function is supported by EGL or a specific client API context." This required moving extension initialization from OpenGLFunctions into OpenGLFunctionsBase. Change-Id: Ib4e8360ba455818701990b4476689b651d097ca8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/121760 Commit-Queue: Stephen White <senorblanco@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
45 lines
1.5 KiB
C++
45 lines
1.5 KiB
C++
// Copyright 2019 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "dawn/native/opengl/OpenGLFunctions.h"
|
|
|
|
#include <cctype>
|
|
|
|
namespace dawn::native::opengl {
|
|
|
|
MaybeError OpenGLFunctions::Initialize(GetProcAddress getProc) {
|
|
DAWN_TRY(mVersion.Initialize(getProc));
|
|
if (mVersion.IsES()) {
|
|
DAWN_TRY(LoadOpenGLESProcs(getProc, mVersion.GetMajor(), mVersion.GetMinor()));
|
|
} else {
|
|
DAWN_TRY(LoadDesktopGLProcs(getProc, mVersion.GetMajor(), mVersion.GetMinor()));
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
const OpenGLVersion& OpenGLFunctions::GetVersion() const {
|
|
return mVersion;
|
|
}
|
|
|
|
bool OpenGLFunctions::IsAtLeastGL(uint32_t majorVersion, uint32_t minorVersion) const {
|
|
return mVersion.IsDesktop() && mVersion.IsAtLeast(majorVersion, minorVersion);
|
|
}
|
|
|
|
bool OpenGLFunctions::IsAtLeastGLES(uint32_t majorVersion, uint32_t minorVersion) const {
|
|
return mVersion.IsES() && mVersion.IsAtLeast(majorVersion, minorVersion);
|
|
}
|
|
|
|
} // namespace dawn::native::opengl
|