mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-17 09:21:45 +00:00
36aa48ce36
Remove the direct use of BuilderImpl from TestHelperBase to cut down the amount of internal state management required by the tests, and removing confusing conflation between the BuilderImpl and Builder. This change removes the following methods from TestHelperBase: * CreateBuilder() * InjectFlowBlock() * CreateEmptyBuilder() * FlowNodeForAstNode() Tests now just use FromProgram() function for testing AST -> IR. The downside to the black-box testing is that the per-method granularity of the unit testing increases to whole FromProgram() granularity. However, my personal opinion is that this is more than offset by the lack of state leakage from the implementation to the tests. Bug tint:1718 Change-Id: Iba2560e0fbcbd3dfb936694e50997d716f09fbd8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/132960 Kokoro: Ben Clayton <bclayton@google.com> Reviewed-by: Dan Sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>