mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-10 07:05:54 +00:00
48183b8f58
Vulkan requires that linear and opaque resources be placed in different "pages" of bufferImageGranularity size, as some hardware uses the page table to contain some compression bits or other stuff. Make Dawn honor this limit by aligning all allocations to bufferImageGranularity. This is pretty bad and should be improved later. Also does some cleanups: - Add kMappableBufferUsage to represent all mappable usages. - Remove the proxy function for resource management from vulkan::Device and call ResourceMemoryAllocator directly. - Use an enum to make the difference between mappable, linear and opaque resources. This issue was found while doing a change of the memory type selection in Vulkan, that started failing some unrelated tests on Nvidia. Without knowing the details of the HW or the driver it is really hard to write tests, except by copy-pasting a failing test. This is why there is no test added in this CL, and instead will rely on tests not failing with the follow-up CL. Bug: dawn:659 Change-Id: Ib7c1f3f1949457e04ca8e23d212dc60af7046213 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/52920 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>