mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-05 06:03:34 +00:00
Remove all redundant std::move()s. I've also removed calls to std::move() in tests, even if they act as an optimization. This is for two reasons: (a) Performance is not important for testing, and this helps with readability. (b) A whole bunch tests were relying on std::move() clearing vectors so they can be repopulated and used again. This is undefined behavior: > Objects of types defined in the C++ standard library may be moved from > (12.8). Move operations may be explicitly specified or implicitly > generated. Unless otherwise specified, such moved-from objects shall > be placed in a valid but unspecified state. All of these UB cases have been fixed. Removed all duplicate variables left over from: `auto* foo_ptr = foo.get()` which became: `auto* foo_ptr = foo` Bug: tint:322 Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
145 lines
3.8 KiB
C++
145 lines
3.8 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/else_statement.h"
|
|
|
|
#include "src/ast/bool_literal.h"
|
|
#include "src/ast/discard_statement.h"
|
|
#include "src/ast/if_statement.h"
|
|
#include "src/ast/scalar_constructor_expression.h"
|
|
#include "src/ast/test_helper.h"
|
|
#include "src/ast/type/bool_type.h"
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
namespace {
|
|
|
|
using ElseStatementTest = TestHelper;
|
|
|
|
TEST_F(ElseStatementTest, Creation) {
|
|
ast::type::BoolType bool_type;
|
|
auto* cond = create<ScalarConstructorExpression>(
|
|
create<BoolLiteral>(&bool_type, true));
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* discard = body->get(0);
|
|
|
|
ElseStatement e(cond, body);
|
|
EXPECT_EQ(e.condition(), cond);
|
|
ASSERT_EQ(e.body()->size(), 1u);
|
|
EXPECT_EQ(e.body()->get(0), discard);
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, Creation_WithSource) {
|
|
ElseStatement e(Source{Source::Location{20, 2}}, create<BlockStatement>());
|
|
auto src = e.source();
|
|
EXPECT_EQ(src.range.begin.line, 20u);
|
|
EXPECT_EQ(src.range.begin.column, 2u);
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, IsElse) {
|
|
ElseStatement e(create<BlockStatement>());
|
|
EXPECT_TRUE(e.IsElse());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, HasCondition) {
|
|
ast::type::BoolType bool_type;
|
|
auto* cond = create<ScalarConstructorExpression>(
|
|
create<BoolLiteral>(&bool_type, true));
|
|
ElseStatement e(cond, create<BlockStatement>());
|
|
EXPECT_TRUE(e.HasCondition());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, HasContition_NullCondition) {
|
|
ElseStatement e(create<BlockStatement>());
|
|
EXPECT_FALSE(e.HasCondition());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, IsValid) {
|
|
ElseStatement e(create<BlockStatement>());
|
|
EXPECT_TRUE(e.IsValid());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, IsValid_WithBody) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
ElseStatement e(body);
|
|
EXPECT_TRUE(e.IsValid());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, IsValid_WithNullBodyStatement) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
body->append(nullptr);
|
|
|
|
ElseStatement e(body);
|
|
EXPECT_FALSE(e.IsValid());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, IsValid_InvalidCondition) {
|
|
auto* cond = create<ScalarConstructorExpression>();
|
|
ElseStatement e(cond, create<BlockStatement>());
|
|
EXPECT_FALSE(e.IsValid());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, IsValid_InvalidBodyStatement) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<IfStatement>(nullptr, create<ast::BlockStatement>()));
|
|
|
|
ElseStatement e(body);
|
|
EXPECT_FALSE(e.IsValid());
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, ToStr) {
|
|
ast::type::BoolType bool_type;
|
|
auto* cond = create<ScalarConstructorExpression>(
|
|
create<BoolLiteral>(&bool_type, true));
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
ElseStatement e(cond, body);
|
|
std::ostringstream out;
|
|
e.to_str(out, 2);
|
|
EXPECT_EQ(out.str(), R"( Else{
|
|
(
|
|
ScalarConstructor[not set]{true}
|
|
)
|
|
{
|
|
Discard{}
|
|
}
|
|
}
|
|
)");
|
|
}
|
|
|
|
TEST_F(ElseStatementTest, ToStr_NoCondition) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
ElseStatement e(body);
|
|
std::ostringstream out;
|
|
e.to_str(out, 2);
|
|
EXPECT_EQ(out.str(), R"( Else{
|
|
{
|
|
Discard{}
|
|
}
|
|
}
|
|
)");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace ast
|
|
} // namespace tint
|