encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-05-15 20:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/src/ast/function_test.cc
Ben Clayton 4bfe461646 Big cleanup now that AST nodes are raw pointers 
Remove all redundant std::move()s. I've also removed calls to
std::move() in tests, even if they act as an optimization. This is for
two reasons:
(a) Performance is not important for testing, and this helps with
    readability.
(b) A whole bunch tests were relying on std::move() clearing vectors so
    they can be repopulated and used again. This is undefined behavior:

> Objects of types defined in the C++ standard library may be moved from
> (12.8). Move operations may be explicitly specified or implicitly
> generated. Unless otherwise specified, such moved-from objects shall
> be placed in a valid but unspecified state.

All of these UB cases have been fixed.

Removed all duplicate variables left over from:
  `auto* foo_ptr = foo.get()`
which became:
  `auto* foo_ptr = foo`

Bug: tint:322
Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-16 16:41:47 +00:00

407 lines
12 KiB
C++
Raw Blame History

// Copyright 2020 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "src/ast/function.h"
#include "src/ast/builtin_decoration.h"
#include "src/ast/decorated_variable.h"
#include "src/ast/discard_statement.h"
#include "src/ast/location_decoration.h"
#include "src/ast/pipeline_stage.h"
#include "src/ast/test_helper.h"
#include "src/ast/type/f32_type.h"
#include "src/ast/type/i32_type.h"
#include "src/ast/type/void_type.h"
#include "src/ast/variable.h"
#include "src/ast/workgroup_decoration.h"
namespace tint {
namespace ast {
namespace {
using FunctionTest = TestHelper;
TEST_F(FunctionTest, Creation) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
auto* var = params[0];
Function f("func", params, &void_type, create<ast::BlockStatement>());
EXPECT_EQ(f.name(), "func");
ASSERT_EQ(f.params().size(), 1u);
EXPECT_EQ(f.return_type(), &void_type);
EXPECT_EQ(f.params()[0], var);
}
TEST_F(FunctionTest, Creation_WithSource) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
Function f(Source{Source::Location{20, 2}}, "func", params, &void_type,
create<ast::BlockStatement>());
auto src = f.source();
EXPECT_EQ(src.range.begin.line, 20u);
EXPECT_EQ(src.range.begin.column, 2u);
}
TEST_F(FunctionTest, AddDuplicateReferencedVariables) {
type::VoidType void_type;
type::I32Type i32;
Variable v("var", StorageClass::kInput, &i32);
Function f("func", VariableList{}, &void_type, create<ast::BlockStatement>());
f.add_referenced_module_variable(&v);
ASSERT_EQ(f.referenced_module_variables().size(), 1u);
EXPECT_EQ(f.referenced_module_variables()[0], &v);
f.add_referenced_module_variable(&v);
ASSERT_EQ(f.referenced_module_variables().size(), 1u);
Variable v2("var2", StorageClass::kOutput, &i32);
f.add_referenced_module_variable(&v2);
ASSERT_EQ(f.referenced_module_variables().size(), 2u);
EXPECT_EQ(f.referenced_module_variables()[1], &v2);
}
TEST_F(FunctionTest, GetReferenceLocations) {
type::VoidType void_type;
type::I32Type i32;
DecoratedVariable loc1(
create<ast::Variable>("loc1", StorageClass::kInput, &i32));
loc1.set_decorations({create<ast::LocationDecoration>(0, Source{})});
DecoratedVariable loc2(
create<ast::Variable>("loc2", StorageClass::kInput, &i32));
loc2.set_decorations({create<ast::LocationDecoration>(1, Source{})});
DecoratedVariable builtin1(
create<ast::Variable>("builtin1", StorageClass::kInput, &i32));
builtin1.set_decorations(
{create<ast::BuiltinDecoration>(ast::Builtin::kPosition, Source{})});
DecoratedVariable builtin2(
create<ast::Variable>("builtin2", StorageClass::kInput, &i32));
builtin2.set_decorations(
{create<ast::BuiltinDecoration>(ast::Builtin::kFragDepth, Source{})});
Function f("func", VariableList{}, &void_type, create<ast::BlockStatement>());
f.add_referenced_module_variable(&loc1);
f.add_referenced_module_variable(&builtin1);
f.add_referenced_module_variable(&loc2);
f.add_referenced_module_variable(&builtin2);
ASSERT_EQ(f.referenced_module_variables().size(), 4u);
auto ref_locs = f.referenced_location_variables();
ASSERT_EQ(ref_locs.size(), 2u);
EXPECT_EQ(ref_locs[0].first, &loc1);
EXPECT_EQ(ref_locs[0].second->value(), 0u);
EXPECT_EQ(ref_locs[1].first, &loc2);
EXPECT_EQ(ref_locs[1].second->value(), 1u);
}
TEST_F(FunctionTest, GetReferenceBuiltins) {
type::VoidType void_type;
type::I32Type i32;
DecoratedVariable loc1(
create<ast::Variable>("loc1", StorageClass::kInput, &i32));
loc1.set_decorations({create<ast::LocationDecoration>(0, Source{})});
DecoratedVariable loc2(
create<ast::Variable>("loc2", StorageClass::kInput, &i32));
loc2.set_decorations({create<ast::LocationDecoration>(1, Source{})});
DecoratedVariable builtin1(
create<ast::Variable>("builtin1", StorageClass::kInput, &i32));
builtin1.set_decorations(
{create<ast::BuiltinDecoration>(ast::Builtin::kPosition, Source{})});
DecoratedVariable builtin2(
create<ast::Variable>("builtin2", StorageClass::kInput, &i32));
builtin2.set_decorations(
{create<ast::BuiltinDecoration>(ast::Builtin::kFragDepth, Source{})});
Function f("func", VariableList{}, &void_type, create<ast::BlockStatement>());
f.add_referenced_module_variable(&loc1);
f.add_referenced_module_variable(&builtin1);
f.add_referenced_module_variable(&loc2);
f.add_referenced_module_variable(&builtin2);
ASSERT_EQ(f.referenced_module_variables().size(), 4u);
auto ref_locs = f.referenced_builtin_variables();
ASSERT_EQ(ref_locs.size(), 2u);
EXPECT_EQ(ref_locs[0].first, &builtin1);
EXPECT_EQ(ref_locs[0].second->value(), ast::Builtin::kPosition);
EXPECT_EQ(ref_locs[1].first, &builtin2);
EXPECT_EQ(ref_locs[1].second->value(), ast::Builtin::kFragDepth);
}
TEST_F(FunctionTest, AddDuplicateEntryPoints) {
ast::type::VoidType void_type;
Function f("func", VariableList{}, &void_type, create<ast::BlockStatement>());
f.add_ancestor_entry_point("main");
ASSERT_EQ(1u, f.ancestor_entry_points().size());
EXPECT_EQ("main", f.ancestor_entry_points()[0]);
f.add_ancestor_entry_point("main");
ASSERT_EQ(1u, f.ancestor_entry_points().size());
EXPECT_EQ("main", f.ancestor_entry_points()[0]);
}
TEST_F(FunctionTest, IsValid) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
auto* block = create<ast::BlockStatement>();
block->append(create<DiscardStatement>());
Function f("func", params, &void_type, create<ast::BlockStatement>());
f.set_body(block);
EXPECT_TRUE(f.IsValid());
}
TEST_F(FunctionTest, IsValid_EmptyName) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
Function f("", params, &void_type, create<ast::BlockStatement>());
EXPECT_FALSE(f.IsValid());
}
TEST_F(FunctionTest, IsValid_MissingReturnType) {
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
Function f("func", params, nullptr, create<ast::BlockStatement>());
EXPECT_FALSE(f.IsValid());
}
TEST_F(FunctionTest, IsValid_NullParam) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
params.push_back(nullptr);
Function f("func", params, &void_type, create<ast::BlockStatement>());
EXPECT_FALSE(f.IsValid());
}
TEST_F(FunctionTest, IsValid_InvalidParam) {
type::VoidType void_type;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, nullptr));
Function f("func", params, &void_type, create<ast::BlockStatement>());
EXPECT_FALSE(f.IsValid());
}
TEST_F(FunctionTest, IsValid_NullBodyStatement) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
auto* block = create<ast::BlockStatement>();
block->append(create<DiscardStatement>());
block->append(nullptr);
Function f("func", params, &void_type, create<ast::BlockStatement>());
f.set_body(block);
EXPECT_FALSE(f.IsValid());
}
TEST_F(FunctionTest, IsValid_InvalidBodyStatement) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
auto* block = create<ast::BlockStatement>();
block->append(create<DiscardStatement>());
block->append(nullptr);
Function f("func", params, &void_type, create<ast::BlockStatement>());
f.set_body(block);
EXPECT_FALSE(f.IsValid());
}
TEST_F(FunctionTest, ToStr) {
type::VoidType void_type;
type::I32Type i32;
auto* block = create<ast::BlockStatement>();
block->append(create<DiscardStatement>());
Function f("func", {}, &void_type, create<ast::BlockStatement>());
f.set_body(block);
std::ostringstream out;
f.to_str(out, 2);
EXPECT_EQ(out.str(), R"( Function func -> __void
()
{
Discard{}
}
)");
}
TEST_F(FunctionTest, ToStr_WithDecoration) {
type::VoidType void_type;
type::I32Type i32;
auto* block = create<ast::BlockStatement>();
block->append(create<DiscardStatement>());
Function f("func", {}, &void_type, create<ast::BlockStatement>());
f.set_body(block);
f.add_decoration(create<WorkgroupDecoration>(2, 4, 6, Source{}));
std::ostringstream out;
f.to_str(out, 2);
EXPECT_EQ(out.str(), R"( Function func -> __void
WorkgroupDecoration{2 4 6}
()
{
Discard{}
}
)");
}
TEST_F(FunctionTest, ToStr_WithParams) {
type::VoidType void_type;
type::I32Type i32;
VariableList params;
params.push_back(create<Variable>("var", StorageClass::kNone, &i32));
auto* block = create<ast::BlockStatement>();
block->append(create<DiscardStatement>());
Function f("func", params, &void_type, create<ast::BlockStatement>());
f.set_body(block);
std::ostringstream out;
f.to_str(out, 2);
EXPECT_EQ(out.str(), R"( Function func -> __void
(
Variable{
var
none
__i32
}
)
{
Discard{}
}
)");
}
TEST_F(FunctionTest, TypeName) {
type::VoidType void_type;
Function f("func", {}, &void_type, create<ast::BlockStatement>());
EXPECT_EQ(f.type_name(), "__func__void");
}
TEST_F(FunctionTest, TypeName_WithParams) {
type::VoidType void_type;
type::I32Type i32;
type::F32Type f32;
VariableList params;
params.push_back(create<Variable>("var1", StorageClass::kNone, &i32));
params.push_back(create<Variable>("var2", StorageClass::kNone, &f32));
Function f("func", params, &void_type, create<ast::BlockStatement>());
EXPECT_EQ(f.type_name(), "__func__void__i32__f32");
}
TEST_F(FunctionTest, GetLastStatement) {
type::VoidType void_type;
VariableList params;
auto* body = create<ast::BlockStatement>();
auto* stmt = create<DiscardStatement>();
body->append(stmt);
Function f("func", params, &void_type, create<ast::BlockStatement>());
f.set_body(body);
EXPECT_EQ(f.get_last_statement(), stmt);
}
TEST_F(FunctionTest, GetLastStatement_nullptr) {
type::VoidType void_type;
VariableList params;
auto* body = create<ast::BlockStatement>();
Function f("func", params, &void_type, create<ast::BlockStatement>());
f.set_body(body);
EXPECT_EQ(f.get_last_statement(), nullptr);
}
TEST_F(FunctionTest, WorkgroupSize_NoneSet) {
type::VoidType void_type;
Function f("f", {}, &void_type, create<ast::BlockStatement>());
uint32_t x = 0;
uint32_t y = 0;
uint32_t z = 0;
std::tie(x, y, z) = f.workgroup_size();
EXPECT_EQ(x, 1u);
EXPECT_EQ(y, 1u);
EXPECT_EQ(z, 1u);
}
TEST_F(FunctionTest, WorkgroupSize) {
type::VoidType void_type;
Function f("f", {}, &void_type, create<ast::BlockStatement>());
f.add_decoration(create<WorkgroupDecoration>(2u, 4u, 6u, Source{}));
uint32_t x = 0;
uint32_t y = 0;
uint32_t z = 0;
std::tie(x, y, z) = f.workgroup_size();
EXPECT_EQ(x, 2u);
EXPECT_EQ(y, 4u);
EXPECT_EQ(z, 6u);
}
} // namespace
} // namespace ast
} // namespace tint
Reference in New Issue View Git Blame Copy Permalink