mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-05 06:03:34 +00:00
Remove all redundant std::move()s. I've also removed calls to std::move() in tests, even if they act as an optimization. This is for two reasons: (a) Performance is not important for testing, and this helps with readability. (b) A whole bunch tests were relying on std::move() clearing vectors so they can be repopulated and used again. This is undefined behavior: > Objects of types defined in the C++ standard library may be moved from > (12.8). Move operations may be explicitly specified or implicitly > generated. Unless otherwise specified, such moved-from objects shall > be placed in a valid but unspecified state. All of these UB cases have been fixed. Removed all duplicate variables left over from: `auto* foo_ptr = foo.get()` which became: `auto* foo_ptr = foo` Bug: tint:322 Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
189 lines
5.1 KiB
C++
189 lines
5.1 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/loop_statement.h"
|
|
|
|
#include <memory>
|
|
#include <sstream>
|
|
|
|
#include "src/ast/discard_statement.h"
|
|
#include "src/ast/if_statement.h"
|
|
#include "src/ast/test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
namespace {
|
|
|
|
using LoopStatementTest = TestHelper;
|
|
|
|
TEST_F(LoopStatementTest, Creation) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
auto* b = body->last();
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, continuing);
|
|
ASSERT_EQ(l.body()->size(), 1u);
|
|
EXPECT_EQ(l.body()->get(0), b);
|
|
ASSERT_EQ(l.continuing()->size(), 1u);
|
|
EXPECT_EQ(l.continuing()->get(0), continuing->last());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, Creation_WithSource) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(Source{Source::Location{20, 2}}, body, continuing);
|
|
auto src = l.source();
|
|
EXPECT_EQ(src.range.begin.line, 20u);
|
|
EXPECT_EQ(src.range.begin.column, 2u);
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsLoop) {
|
|
LoopStatement l(create<BlockStatement>(), create<BlockStatement>());
|
|
EXPECT_TRUE(l.IsLoop());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, HasContinuing_WithoutContinuing) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, {});
|
|
EXPECT_FALSE(l.has_continuing());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, HasContinuing_WithContinuing) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, continuing);
|
|
EXPECT_TRUE(l.has_continuing());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, continuing);
|
|
EXPECT_TRUE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid_WithoutContinuing) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, create<BlockStatement>());
|
|
EXPECT_TRUE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid_WithoutBody) {
|
|
LoopStatement l(create<BlockStatement>(), create<BlockStatement>());
|
|
EXPECT_TRUE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid_NullBodyStatement) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
body->append(nullptr);
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, continuing);
|
|
EXPECT_FALSE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid_InvalidBodyStatement) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
body->append(create<IfStatement>(nullptr, create<BlockStatement>()));
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, continuing);
|
|
EXPECT_FALSE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid_NullContinuingStatement) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
continuing->append(nullptr);
|
|
|
|
LoopStatement l(body, continuing);
|
|
EXPECT_FALSE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, IsValid_InvalidContinuingStatement) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
continuing->append(create<IfStatement>(nullptr, create<BlockStatement>()));
|
|
|
|
LoopStatement l(body, continuing);
|
|
EXPECT_FALSE(l.IsValid());
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, ToStr) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, {});
|
|
std::ostringstream out;
|
|
l.to_str(out, 2);
|
|
EXPECT_EQ(out.str(), R"( Loop{
|
|
Discard{}
|
|
}
|
|
)");
|
|
}
|
|
|
|
TEST_F(LoopStatementTest, ToStr_WithContinuing) {
|
|
auto* body = create<BlockStatement>();
|
|
body->append(create<DiscardStatement>());
|
|
|
|
auto* continuing = create<BlockStatement>();
|
|
continuing->append(create<DiscardStatement>());
|
|
|
|
LoopStatement l(body, continuing);
|
|
std::ostringstream out;
|
|
l.to_str(out, 2);
|
|
EXPECT_EQ(out.str(), R"( Loop{
|
|
Discard{}
|
|
continuing {
|
|
Discard{}
|
|
}
|
|
}
|
|
)");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace ast
|
|
} // namespace tint
|