mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-05 06:03:34 +00:00
4bfe461646
Remove all redundant std::move()s. I've also removed calls to
std::move() in tests, even if they act as an optimization. This is for
two reasons:
(a) Performance is not important for testing, and this helps with
readability.
(b) A whole bunch tests were relying on std::move() clearing vectors so
they can be repopulated and used again. This is undefined behavior:
> Objects of types defined in the C++ standard library may be moved from
> (12.8). Move operations may be explicitly specified or implicitly
> generated. Unless otherwise specified, such moved-from objects shall
> be placed in a valid but unspecified state.
All of these UB cases have been fixed.
Removed all duplicate variables left over from:
`auto* foo_ptr = foo.get()`
which became:
`auto* foo_ptr = foo`
Bug: tint:322
Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
104 lines
3.4 KiB
C++
104 lines
3.4 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "src/ast/constant_id_decoration.h"
|
|
#include "src/ast/decorated_variable.h"
|
|
#include "src/ast/float_literal.h"
|
|
#include "src/ast/module.h"
|
|
#include "src/ast/scalar_constructor_expression.h"
|
|
#include "src/ast/type/array_type.h"
|
|
#include "src/ast/type/f32_type.h"
|
|
#include "src/ast/type_constructor_expression.h"
|
|
#include "src/ast/variable.h"
|
|
#include "src/writer/hlsl/test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace writer {
|
|
namespace hlsl {
|
|
namespace {
|
|
|
|
using HlslGeneratorImplTest_ModuleConstant = TestHelper;
|
|
|
|
TEST_F(HlslGeneratorImplTest_ModuleConstant, Emit_ModuleConstant) {
|
|
ast::type::F32Type f32;
|
|
ast::type::ArrayType ary(&f32, 3);
|
|
|
|
ast::ExpressionList exprs;
|
|
exprs.push_back(create<ast::ScalarConstructorExpression>(
|
|
create<ast::FloatLiteral>(&f32, 1.0f)));
|
|
exprs.push_back(create<ast::ScalarConstructorExpression>(
|
|
create<ast::FloatLiteral>(&f32, 2.0f)));
|
|
exprs.push_back(create<ast::ScalarConstructorExpression>(
|
|
create<ast::FloatLiteral>(&f32, 3.0f)));
|
|
|
|
auto* var = create<ast::Variable>("pos", ast::StorageClass::kNone, &ary);
|
|
var->set_is_const(true);
|
|
var->set_constructor(create<ast::TypeConstructorExpression>(&ary, exprs));
|
|
|
|
ASSERT_TRUE(gen.EmitProgramConstVariable(out, var)) << gen.error();
|
|
EXPECT_EQ(
|
|
result(),
|
|
"static const float pos[3] = {1.00000000f, 2.00000000f, 3.00000000f};\n");
|
|
}
|
|
|
|
TEST_F(HlslGeneratorImplTest_ModuleConstant, Emit_SpecConstant) {
|
|
ast::type::F32Type f32;
|
|
|
|
ast::VariableDecorationList decos;
|
|
decos.push_back(create<ast::ConstantIdDecoration>(23, Source{}));
|
|
|
|
auto* var = create<ast::DecoratedVariable>(
|
|
create<ast::Variable>("pos", ast::StorageClass::kNone, &f32));
|
|
var->set_decorations(decos);
|
|
var->set_is_const(true);
|
|
var->set_constructor(create<ast::ScalarConstructorExpression>(
|
|
create<ast::FloatLiteral>(&f32, 3.0f)));
|
|
|
|
ASSERT_TRUE(gen.EmitProgramConstVariable(out, var)) << gen.error();
|
|
EXPECT_EQ(result(), R"(#ifndef WGSL_SPEC_CONSTANT_23
|
|
#define WGSL_SPEC_CONSTANT_23 3.00000000f
|
|
#endif
|
|
static const float pos = WGSL_SPEC_CONSTANT_23;
|
|
#undef WGSL_SPEC_CONSTANT_23
|
|
)");
|
|
}
|
|
|
|
TEST_F(HlslGeneratorImplTest_ModuleConstant, Emit_SpecConstant_NoConstructor) {
|
|
ast::type::F32Type f32;
|
|
|
|
ast::VariableDecorationList decos;
|
|
decos.push_back(create<ast::ConstantIdDecoration>(23, Source{}));
|
|
|
|
auto* var = create<ast::DecoratedVariable>(
|
|
create<ast::Variable>("pos", ast::StorageClass::kNone, &f32));
|
|
var->set_decorations(decos);
|
|
var->set_is_const(true);
|
|
|
|
ASSERT_TRUE(gen.EmitProgramConstVariable(out, var)) << gen.error();
|
|
EXPECT_EQ(result(), R"(#ifndef WGSL_SPEC_CONSTANT_23
|
|
#error spec constant required for constant id 23
|
|
#endif
|
|
static const float pos = WGSL_SPEC_CONSTANT_23;
|
|
#undef WGSL_SPEC_CONSTANT_23
|
|
)");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace hlsl
|
|
} // namespace writer
|
|
} // namespace tint
|