mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-27 14:05:44 +00:00
4bfe461646
Remove all redundant std::move()s. I've also removed calls to
std::move() in tests, even if they act as an optimization. This is for
two reasons:
(a) Performance is not important for testing, and this helps with
readability.
(b) A whole bunch tests were relying on std::move() clearing vectors so
they can be repopulated and used again. This is undefined behavior:
> Objects of types defined in the C++ standard library may be moved from
> (12.8). Move operations may be explicitly specified or implicitly
> generated. Unless otherwise specified, such moved-from objects shall
> be placed in a valid but unspecified state.
All of these UB cases have been fixed.
Removed all duplicate variables left over from:
`auto* foo_ptr = foo.get()`
which became:
`auto* foo_ptr = foo`
Bug: tint:322
Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
67 lines
2.2 KiB
C++
67 lines
2.2 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <memory>
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "src/ast/call_expression.h"
|
|
#include "src/ast/call_statement.h"
|
|
#include "src/ast/identifier_expression.h"
|
|
#include "src/writer/wgsl/generator_impl.h"
|
|
#include "src/writer/wgsl/test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace writer {
|
|
namespace wgsl {
|
|
namespace {
|
|
|
|
using WgslGeneratorImplTest = TestHelper;
|
|
|
|
TEST_F(WgslGeneratorImplTest, EmitExpression_Call_WithoutParams) {
|
|
auto* id = create<ast::IdentifierExpression>("my_func");
|
|
ast::CallExpression call(id, {});
|
|
|
|
ASSERT_TRUE(gen.EmitExpression(&call)) << gen.error();
|
|
EXPECT_EQ(gen.result(), "my_func()");
|
|
}
|
|
|
|
TEST_F(WgslGeneratorImplTest, EmitExpression_Call_WithParams) {
|
|
auto* id = create<ast::IdentifierExpression>("my_func");
|
|
ast::ExpressionList params;
|
|
params.push_back(create<ast::IdentifierExpression>("param1"));
|
|
params.push_back(create<ast::IdentifierExpression>("param2"));
|
|
ast::CallExpression call(id, params);
|
|
|
|
ASSERT_TRUE(gen.EmitExpression(&call)) << gen.error();
|
|
EXPECT_EQ(gen.result(), "my_func(param1, param2)");
|
|
}
|
|
|
|
TEST_F(WgslGeneratorImplTest, EmitStatement_Call) {
|
|
auto* id = create<ast::IdentifierExpression>("my_func");
|
|
ast::ExpressionList params;
|
|
params.push_back(create<ast::IdentifierExpression>("param1"));
|
|
params.push_back(create<ast::IdentifierExpression>("param2"));
|
|
|
|
ast::CallStatement call(create<ast::CallExpression>(id, params));
|
|
|
|
gen.increment_indent();
|
|
ASSERT_TRUE(gen.EmitStatement(&call)) << gen.error();
|
|
EXPECT_EQ(gen.result(), " my_func(param1, param2);\n");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace wgsl
|
|
} // namespace writer
|
|
} // namespace tint
|