mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-15 17:45:58 +00:00
In order to avoid declaring too many function parameters, we previously modified this transform to redeclare private variables that are only used inside a single function as function-scope variables. This was broken as it meant that their values did not persist across multiple calls to the same function. Instead, wrap all private variables in a structure and pass it around as a pointer. Fixed: tint:1875 Change-Id: I83f5eb1071d57b9c6af56d6cf21b3a32c6e94260 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124800 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com>
59 lines
1.3 KiB
Plaintext
59 lines
1.3 KiB
Plaintext
#include <metal_stdlib>
|
|
|
|
using namespace metal;
|
|
struct tint_private_vars_struct {
|
|
int a;
|
|
int b;
|
|
int c;
|
|
};
|
|
|
|
void uses_a(thread tint_private_vars_struct* const tint_private_vars) {
|
|
(*(tint_private_vars)).a = as_type<int>((as_type<uint>((*(tint_private_vars)).a) + as_type<uint>(1)));
|
|
}
|
|
|
|
void uses_b(thread tint_private_vars_struct* const tint_private_vars) {
|
|
(*(tint_private_vars)).b = as_type<int>((as_type<uint>((*(tint_private_vars)).b) * as_type<uint>(2)));
|
|
}
|
|
|
|
void uses_a_and_b(thread tint_private_vars_struct* const tint_private_vars) {
|
|
(*(tint_private_vars)).b = (*(tint_private_vars)).a;
|
|
}
|
|
|
|
void no_uses() {
|
|
}
|
|
|
|
void outer(thread tint_private_vars_struct* const tint_private_vars) {
|
|
(*(tint_private_vars)).a = 0;
|
|
uses_a(tint_private_vars);
|
|
uses_a_and_b(tint_private_vars);
|
|
uses_b(tint_private_vars);
|
|
no_uses();
|
|
}
|
|
|
|
kernel void main1() {
|
|
thread tint_private_vars_struct tint_private_vars = {};
|
|
tint_private_vars.a = 42;
|
|
uses_a(&(tint_private_vars));
|
|
return;
|
|
}
|
|
|
|
kernel void main2() {
|
|
thread tint_private_vars_struct tint_private_vars = {};
|
|
tint_private_vars.b = 7;
|
|
uses_b(&(tint_private_vars));
|
|
return;
|
|
}
|
|
|
|
kernel void main3() {
|
|
thread tint_private_vars_struct tint_private_vars = {};
|
|
outer(&(tint_private_vars));
|
|
no_uses();
|
|
return;
|
|
}
|
|
|
|
kernel void main4() {
|
|
no_uses();
|
|
return;
|
|
}
|
|
|